You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "hamza-tam (via GitHub)" <gi...@apache.org> on 2023/03/17 22:58:26 UTC
[GitHub] [parquet-mr] hamza-tam opened a new pull request, #1041: Uniformizing booleans naming in ParquetWriter
hamza-tam opened a new pull request, #1041:
URL: https://github.com/apache/parquet-mr/pull/1041
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR does not need testing for this extremely good reason: Only variable renaming
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] yabola commented on a diff in pull request #1041: Uniformizing booleans naming in ParquetWriter
Posted by "yabola (via GitHub)" <gi...@apache.org>.
yabola commented on code in PR #1041:
URL: https://github.com/apache/parquet-mr/pull/1041#discussion_r1158495442
##########
parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java:
##########
@@ -130,7 +130,7 @@ private ParquetProperties(Builder builder) {
this.maxBloomFilterBytes = builder.maxBloomFilterBytes;
this.pageRowCountLimit = builder.pageRowCountLimit;
this.pageWriteChecksumEnabled = builder.pageWriteChecksumEnabled;
- this.enableByteStreamSplit = builder.enableByteStreamSplit;
+ this.byteStreamSplitEnabled = builder.enableByteStreamSplit;
Review Comment:
`builder.enableByteStreamSplit` should also rename as `byteStreamSplitEnabled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #1041: Uniformizing booleans naming in ParquetWriter
Posted by "shangxinli (via GitHub)" <gi...@apache.org>.
shangxinli commented on PR #1041:
URL: https://github.com/apache/parquet-mr/pull/1041#issuecomment-1559497609
Yeah, public ones are tricky and we need to make it compatible. But overall, this is a great effort to improve our code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Uniformizing booleans naming in ParquetWriter [parquet-mr]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #1041:
URL: https://github.com/apache/parquet-mr/pull/1041#issuecomment-1767000064
Unfortunately, we cannot change public static methods, since other projects might be using them. If we want this we first need to deprecate the old values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org