You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2015/09/11 23:01:29 UTC
Review Request 38317: DB name should be case insensitive in HDFS sync
plugin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38317/
-----------------------------------------------------------
Review request for sentry and Lenni Kuff.
Bugs: sentry-885
https://issues.apache.org/jira/browse/sentry-885
Repository: sentry
Description
-------
DB name should be case insensitive in HDFS sync plugin
Diffs
-----
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java 093d21a8a06e8dbf6d472a1267cf87e609848ace
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java d7b5d5a265c6e89692528ea8d3ebd46a40644080
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java 7587a1d1ace4c5f60f9969c1c7051f4b3894238b
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java e61dff0e8f926c9802b9840856b3cfcae3de5043
Diff: https://reviews.apache.org/r/38317/diff/
Testing
-------
Added e2e tests.
Thanks,
Sravya Tirukkovalur
Re: Review Request 38317: DB name should be case insensitive in HDFS
sync plugin
Posted by Lenni Kuff <ls...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38317/#review99139
-----------------------------------------------------------
Ship it!
Ship It!
- Lenni Kuff
On Sept. 15, 2015, 11:38 p.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38317/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2015, 11:38 p.m.)
>
>
> Review request for sentry and Lenni Kuff.
>
>
> Bugs: sentry-885
> https://issues.apache.org/jira/browse/sentry-885
>
>
> Repository: sentry
>
>
> Description
> -------
>
> DB name should be case insensitive in HDFS sync plugin
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java 093d21a8a06e8dbf6d472a1267cf87e609848ace
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java d7b5d5a265c6e89692528ea8d3ebd46a40644080
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java 7587a1d1ace4c5f60f9969c1c7051f4b3894238b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java e61dff0e8f926c9802b9840856b3cfcae3de5043
>
> Diff: https://reviews.apache.org/r/38317/diff/
>
>
> Testing
> -------
>
> Added e2e tests.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request 38317: DB name should be case insensitive in HDFS
sync plugin
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38317/
-----------------------------------------------------------
(Updated Sept. 15, 2015, 11:38 p.m.)
Review request for sentry and Lenni Kuff.
Bugs: sentry-885
https://issues.apache.org/jira/browse/sentry-885
Repository: sentry
Description
-------
DB name should be case insensitive in HDFS sync plugin
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java 093d21a8a06e8dbf6d472a1267cf87e609848ace
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java d7b5d5a265c6e89692528ea8d3ebd46a40644080
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java 7587a1d1ace4c5f60f9969c1c7051f4b3894238b
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java e61dff0e8f926c9802b9840856b3cfcae3de5043
Diff: https://reviews.apache.org/r/38317/diff/
Testing
-------
Added e2e tests.
Thanks,
Sravya Tirukkovalur
Re: Review Request 38317: DB name should be case insensitive in HDFS
sync plugin
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38317/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 9:07 p.m.)
Review request for sentry and Lenni Kuff.
Bugs: sentry-885
https://issues.apache.org/jira/browse/sentry-885
Repository: sentry
Description
-------
DB name should be case insensitive in HDFS sync plugin
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java 093d21a8a06e8dbf6d472a1267cf87e609848ace
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java d7b5d5a265c6e89692528ea8d3ebd46a40644080
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java 7587a1d1ace4c5f60f9969c1c7051f4b3894238b
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java e61dff0e8f926c9802b9840856b3cfcae3de5043
Diff: https://reviews.apache.org/r/38317/diff/
Testing
-------
Added e2e tests.
Thanks,
Sravya Tirukkovalur
Re: Review Request 38317: DB name should be case insensitive in HDFS
sync plugin
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38317/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 6:29 p.m.)
Review request for sentry and Lenni Kuff.
Changes
-------
Updated based on review comments
Bugs: sentry-885
https://issues.apache.org/jira/browse/sentry-885
Repository: sentry
Description
-------
DB name should be case insensitive in HDFS sync plugin
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java 093d21a8a06e8dbf6d472a1267cf87e609848ace
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java d7b5d5a265c6e89692528ea8d3ebd46a40644080
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java 7587a1d1ace4c5f60f9969c1c7051f4b3894238b
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java e61dff0e8f926c9802b9840856b3cfcae3de5043
Diff: https://reviews.apache.org/r/38317/diff/
Testing
-------
Added e2e tests.
Thanks,
Sravya Tirukkovalur
Re: Review Request 38317: DB name should be case insensitive in HDFS
sync plugin
Posted by Lenni Kuff <ls...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38317/#review98713
-----------------------------------------------------------
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java (line 123)
<https://reviews.apache.org/r/38317/#comment155272>
Comment someplace that db names are case-insensitive
Shoudl we just convernt the dbName to lowercase at the start instead of calling toLowerCase() a bunch of times?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (line 631)
<https://reviews.apache.org/r/38317/#comment155273>
Do we also have test cases for table case name case sensitivity?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (line 633)
<https://reviews.apache.org/r/38317/#comment155274>
Can you change this to "grant all on database ExTdB ..." (use different casing in the DB name in the grant)
- Lenni Kuff
On Sept. 11, 2015, 9:01 p.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38317/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 9:01 p.m.)
>
>
> Review request for sentry and Lenni Kuff.
>
>
> Bugs: sentry-885
> https://issues.apache.org/jira/browse/sentry-885
>
>
> Repository: sentry
>
>
> Description
> -------
>
> DB name should be case insensitive in HDFS sync plugin
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java 093d21a8a06e8dbf6d472a1267cf87e609848ace
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java d7b5d5a265c6e89692528ea8d3ebd46a40644080
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java 7587a1d1ace4c5f60f9969c1c7051f4b3894238b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java e61dff0e8f926c9802b9840856b3cfcae3de5043
>
> Diff: https://reviews.apache.org/r/38317/diff/
>
>
> Testing
> -------
>
> Added e2e tests.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>