You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/05/07 23:15:06 UTC
[Impala-ASF-CR] IMPALA-9585: update mt dop docs
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15883
Change subject: IMPALA-9585: update mt_dop docs
......................................................................
IMPALA-9585: update mt_dop docs
Updated to reflect changes in IMPALA-9099
Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
---
M docs/topics/impala_mt_dop.xml
1 file changed, 27 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/15883/1
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9585: update mt dop docs
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15883
to look at the new patch set (#2).
Change subject: IMPALA-9585: update mt_dop docs
......................................................................
IMPALA-9585: update mt_dop docs
Updated to reflect changes in IMPALA-9099 and IMPALA-9736.
Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
---
M docs/topics/impala_mt_dop.xml
1 file changed, 27 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/15883/2
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9585: [DOCS] update mt dop docs
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15883 )
Change subject: IMPALA-9585: [DOCS] update mt_dop docs
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 22:39:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9585: update mt dop docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15883 )
Change subject: IMPALA-9585: update mt_dop docs
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/593/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 00:26:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9585: update mt dop docs
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15883 )
Change subject: IMPALA-9585: update mt_dop docs
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15883/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15883/2//COMMIT_MSG@7
PS2, Line 7:
nit: [DOCS] tag is missing.
http://gerrit.cloudera.org:8080/#/c/15883/2/docs/topics/impala_mt_dop.xml
File docs/topics/impala_mt_dop.xml:
http://gerrit.cloudera.org:8080/#/c/15883/2/docs/topics/impala_mt_dop.xml@83
PS2, Line 83: only
: only
nit: Doubled 'only'.
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 07:10:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9585: update mt dop docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15883 )
Change subject: IMPALA-9585: update mt_dop docs
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/593/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 00:07:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9585: [DOCS] update mt dop docs
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15883 )
Change subject: IMPALA-9585: [DOCS] update mt_dop docs
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15883/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15883/2//COMMIT_MSG@7
PS2, Line 7:
> nit: [DOCS] tag is missing.
Done
http://gerrit.cloudera.org:8080/#/c/15883/2/docs/topics/impala_mt_dop.xml
File docs/topics/impala_mt_dop.xml:
http://gerrit.cloudera.org:8080/#/c/15883/2/docs/topics/impala_mt_dop.xml@83
PS2, Line 83: only
: only
> nit: Doubled 'only'.
Done
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 17:54:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9585: update mt dop docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15883 )
Change subject: IMPALA-9585: update mt_dop docs
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/592/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 23:33:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9585: [DOCS] update mt dop docs
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15883 )
Change subject: IMPALA-9585: [DOCS] update mt_dop docs
......................................................................
Patch Set 3: Code-Review+1
Thanks Tim! LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 18:02:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9585: [DOCS] update mt dop docs
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Shajini Thayasingh, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15883
to look at the new patch set (#3).
Change subject: IMPALA-9585: [DOCS] update mt_dop docs
......................................................................
IMPALA-9585: [DOCS] update mt_dop docs
Updated to reflect changes in IMPALA-9099 and IMPALA-9736.
Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
---
M docs/topics/impala_mt_dop.xml
1 file changed, 27 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/15883/3
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9585: [DOCS] update mt dop docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15883 )
Change subject: IMPALA-9585: [DOCS] update mt_dop docs
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/595/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 17:54:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9585: [DOCS] update mt dop docs
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15883 )
Change subject: IMPALA-9585: [DOCS] update mt_dop docs
......................................................................
IMPALA-9585: [DOCS] update mt_dop docs
Updated to reflect changes in IMPALA-9099 and IMPALA-9736.
Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Reviewed-on: http://gerrit.cloudera.org:8080/15883
Reviewed-by: Tamas Mate <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
---
M docs/topics/impala_mt_dop.xml
1 file changed, 27 insertions(+), 12 deletions(-)
Approvals:
Tamas Mate: Looks good to me, but someone else must approve
Impala Public Jenkins: Verified
Bikramjeet Vig: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9585: [DOCS] update mt dop docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15883 )
Change subject: IMPALA-9585: [DOCS] update mt_dop docs
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/595/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 18:13:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9585: update mt dop docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15883 )
Change subject: IMPALA-9585: update mt_dop docs
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/592/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7511fede5f9b36ae8250d3acf8d0061b48106f
Gerrit-Change-Number: 15883
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 23:15:17 +0000
Gerrit-HasComments: No