You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@opendal.apache.org by "asukaminato0721 (via GitHub)" <gi...@apache.org> on 2025/02/18 07:46:36 UTC

Re: [PR] feat(bindings/python): let path can be PathLike [opendal]

asukaminato0721 commented on PR #5636:
URL: https://github.com/apache/opendal/pull/5636#issuecomment-2664845002

   ok, I find the problem.
   
   https://github.com/apache/opendal/blob/7455995092c697863ab6d326b962b8543756c0ca/core/src/layers/blocking.rs#L216
   
   the origin crate use `&str` so
   
   1. change the whole crate to use `AsRef<Path>`, to much change.
   2. do the type change on python binding, I prefer this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org