You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/08/02 09:38:51 UTC
[GitHub] zeppelin pull request #1259: [ZEPPELIN-1260] R interpreter doesn't work with...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/1259
[ZEPPELIN-1260] R interpreter doesn't work with Spark 2.0
### What is this PR for?
This PR fixes R interpreter doesn't work with Spark 2.0
### What type of PR is it?
Bug Fix
### Todos
* [x] - Create and inject SparkSession into SparkRInterpreter
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1260
### How should this be tested?
Run Zeppelin with Spark 2.0 and run following codes and see if it returns `[1] 3`
```
%r
localDF <- data.frame(name=c("a", "b", "c"), age=c(19, 23, 18))
df <- createDataFrame(spark, localDF)
count(df)
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-1260
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1259
----
commit 6bd112811d81aa871b077c655fa0980802e3bc71
Author: Lee moon soo <mo...@apache.org>
Date: 2016-08-02T09:30:23Z
Create and inject spark session into sparkr interpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1259
Looks great to me, modulo question above.
Thank you for prompt fix @Leemoonsoo !
Shall this be merged to master or branch-0.6 as well? Asking as JIRA fix version is not set for this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1259: [ZEPPELIN-1260] R interpreter doesn't work with...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1259
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1259
@bzz Thanks for quick review. Updated the indent.
This should be merged to branch-0.6 as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] zeppelin pull request #1259: [ZEPPELIN-1260] R
interpreter doesn't work with...
Posted by mina lee <mi...@apache.org>.
This is merged to master and branch-0.6 branch, you will be able to run r
interpreter if you build from master.
On Thu, Aug 4, 2016 at 3:07 AM Sourav Mazumder <so...@gmail.com>
wrote:
> Hi,
>
> Is this now put back to the main branch ?
>
> Or do I need to pull this from ZEPPELIN-1260 ?
>
> Regards,
> Sourav
>
> On Tue, Aug 2, 2016 at 2:38 AM, Leemoonsoo <gi...@git.apache.org> wrote:
>
> > GitHub user Leemoonsoo opened a pull request:
> >
> > https://github.com/apache/zeppelin/pull/1259
> >
> > [ZEPPELIN-1260] R interpreter doesn't work with Spark 2.0
> >
> > ### What is this PR for?
> > This PR fixes R interpreter doesn't work with Spark 2.0
> >
> >
> > ### What type of PR is it?
> > Bug Fix
> >
> > ### Todos
> > * [x] - Create and inject SparkSession into SparkRInterpreter
> >
> > ### What is the Jira issue?
> > https://issues.apache.org/jira/browse/ZEPPELIN-1260
> >
> > ### How should this be tested?
> > Run Zeppelin with Spark 2.0 and run following codes and see if it
> > returns `[1] 3`
> > ```
> > %r
> > localDF <- data.frame(name=c("a", "b", "c"), age=c(19, 23, 18))
> > df <- createDataFrame(spark, localDF)
> > count(df)
> > ```
> >
> > ### Screenshots (if appropriate)
> > 
> >
> > ### Questions:
> > * Does the licenses files need update? no
> > * Is there breaking changes for older versions? no
> > * Does this needs documentation? no
> >
> >
> >
> > You can merge this pull request into a Git repository by running:
> >
> > $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-1260
> >
> > Alternatively you can review and apply these changes as the patch at:
> >
> > https://github.com/apache/zeppelin/pull/1259.patch
> >
> > To close this pull request, make a commit to your master/trunk branch
> > with (at least) the following in the commit message:
> >
> > This closes #1259
> >
> > ----
> > commit 6bd112811d81aa871b077c655fa0980802e3bc71
> > Author: Lee moon soo <mo...@apache.org>
> > Date: 2016-08-02T09:30:23Z
> >
> > Create and inject spark session into sparkr interpreter
> >
> > ----
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
> >
>
Re: [GitHub] zeppelin pull request #1259: [ZEPPELIN-1260] R
interpreter doesn't work with...
Posted by Sourav Mazumder <so...@gmail.com>.
Hi,
Is this now put back to the main branch ?
Or do I need to pull this from ZEPPELIN-1260 ?
Regards,
Sourav
On Tue, Aug 2, 2016 at 2:38 AM, Leemoonsoo <gi...@git.apache.org> wrote:
> GitHub user Leemoonsoo opened a pull request:
>
> https://github.com/apache/zeppelin/pull/1259
>
> [ZEPPELIN-1260] R interpreter doesn't work with Spark 2.0
>
> ### What is this PR for?
> This PR fixes R interpreter doesn't work with Spark 2.0
>
>
> ### What type of PR is it?
> Bug Fix
>
> ### Todos
> * [x] - Create and inject SparkSession into SparkRInterpreter
>
> ### What is the Jira issue?
> https://issues.apache.org/jira/browse/ZEPPELIN-1260
>
> ### How should this be tested?
> Run Zeppelin with Spark 2.0 and run following codes and see if it
> returns `[1] 3`
> ```
> %r
> localDF <- data.frame(name=c("a", "b", "c"), age=c(19, 23, 18))
> df <- createDataFrame(spark, localDF)
> count(df)
> ```
>
> ### Screenshots (if appropriate)
> 
>
> ### Questions:
> * Does the licenses files need update? no
> * Is there breaking changes for older versions? no
> * Does this needs documentation? no
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-1260
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/zeppelin/pull/1259.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #1259
>
> ----
> commit 6bd112811d81aa871b077c655fa0980802e3bc71
> Author: Lee moon soo <mo...@apache.org>
> Date: 2016-08-02T09:30:23Z
>
> Create and inject spark session into sparkr interpreter
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1259
Thanks @echarles for the review. I have exposed sqlContext as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/1259
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/1259
@minahlee Just saw you comment on ZEPPELIN-1260, but @Leemoonsoo has been fast...
I have tested the changes, and now sparkr dataframes are working well (with the `spark` variable which referts to the new Spark2 session).
The R tutorial note refers to sqlContext which is no more present
```
Error in dispatchFunc("createDataFrame(data, schema = NULL, samplingRatio = 1.0)", : object 'sqlContext' not found
```
Patch could also expose sqlContext.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1259
Merge it into master and branch-0.6 if there're no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---