You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2019/03/12 23:23:23 UTC
[DISCUSS] Moving redis to a separate module
I created a PR to move our redis support to a separate module. Let me know
what you think:
https://github.com/apache/geode/pull/3284
Geode servers will still include redis on the classpath, so the only effect
of this is that if you are launching a server based on the maven
dependencies, you will need geode-core and geode-redis to launch a server
with redis.
In addition to making it easier to find the redis specific code this also
removes 4 dependencies from geode-core.
-Dan
Re: [DISCUSS] Moving redis to a separate module
Posted by Dan Smith <ds...@pivotal.io>.
Feedback seems to be positive, I'll go ahead and merge this. I'll create a
separate PR to split out memcached - I think that is a good idea.
Thanks!
-Dan
On Tue, Mar 12, 2019 at 5:56 PM Anilkumar Gingade <ag...@pivotal.io>
wrote:
> +1
>
> On Tue, Mar 12, 2019 at 5:32 PM John Blum <jb...@pivotal.io> wrote:
>
> > Definitely a reasonable change. Perhaps, for consistency sake, the same
> > should be applied to Geode's Memcached support? (in another PR).
> >
> >
> > On Tue, Mar 12, 2019 at 4:23 PM Dan Smith <ds...@pivotal.io> wrote:
> >
> > > I created a PR to move our redis support to a separate module. Let me
> > know
> > > what you think:
> > >
> > > https://github.com/apache/geode/pull/3284
> > >
> > > Geode servers will still include redis on the classpath, so the only
> > effect
> > > of this is that if you are launching a server based on the maven
> > > dependencies, you will need geode-core and geode-redis to launch a
> server
> > > with redis.
> > >
> > > In addition to making it easier to find the redis specific code this
> also
> > > removes 4 dependencies from geode-core.
> > >
> > > -Dan
> > >
> >
> >
> > --
> > -John
> > john.blum10101 (skype)
> >
>
Re: [DISCUSS] Moving redis to a separate module
Posted by Anilkumar Gingade <ag...@pivotal.io>.
+1
On Tue, Mar 12, 2019 at 5:32 PM John Blum <jb...@pivotal.io> wrote:
> Definitely a reasonable change. Perhaps, for consistency sake, the same
> should be applied to Geode's Memcached support? (in another PR).
>
>
> On Tue, Mar 12, 2019 at 4:23 PM Dan Smith <ds...@pivotal.io> wrote:
>
> > I created a PR to move our redis support to a separate module. Let me
> know
> > what you think:
> >
> > https://github.com/apache/geode/pull/3284
> >
> > Geode servers will still include redis on the classpath, so the only
> effect
> > of this is that if you are launching a server based on the maven
> > dependencies, you will need geode-core and geode-redis to launch a server
> > with redis.
> >
> > In addition to making it easier to find the redis specific code this also
> > removes 4 dependencies from geode-core.
> >
> > -Dan
> >
>
>
> --
> -John
> john.blum10101 (skype)
>
Re: [DISCUSS] Moving redis to a separate module
Posted by John Blum <jb...@pivotal.io>.
Definitely a reasonable change. Perhaps, for consistency sake, the same
should be applied to Geode's Memcached support? (in another PR).
On Tue, Mar 12, 2019 at 4:23 PM Dan Smith <ds...@pivotal.io> wrote:
> I created a PR to move our redis support to a separate module. Let me know
> what you think:
>
> https://github.com/apache/geode/pull/3284
>
> Geode servers will still include redis on the classpath, so the only effect
> of this is that if you are launching a server based on the maven
> dependencies, you will need geode-core and geode-redis to launch a server
> with redis.
>
> In addition to making it easier to find the redis specific code this also
> removes 4 dependencies from geode-core.
>
> -Dan
>
--
-John
john.blum10101 (skype)