You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Jonathan Hsieh (JIRA)" <ji...@apache.org> on 2011/09/05 06:33:09 UTC
[jira] [Created] (FLUME-758) Test Excludes on maven build doesn't
always work.
Test Excludes on maven build doesn't always work.
-------------------------------------------------
Key: FLUME-758
URL: https://issues.apache.org/jira/browse/FLUME-758
Project: Flume
Issue Type: Bug
Components: Build
Affects Versions: v0.9.5
Reporter: Jonathan Hsieh
Fix For: v0.9.5
FLUME-716 added the ability to exclude and include specific builds by using a test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion was not working properly. This should get fixed so that we can exclude multiple tests by adding a
'-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-758) Test Excludes on maven build doesn't
always work.
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097031#comment-13097031 ]
Jonathan Hsieh commented on FLUME-758:
--------------------------------------
HBase didn't include a specific version of surefire in its pom. It ends up uses surefire v2.5. Flume had explicitly specified surefire 2.8.1. Removing the version from surefire version from the Flume pom makes it default to v2.5 as HBase does. The test exclude now works as desired.
This was unexpected.
> Test Excludes on maven build doesn't always work.
> -------------------------------------------------
>
> Key: FLUME-758
> URL: https://issues.apache.org/jira/browse/FLUME-758
> Project: Flume
> Issue Type: Bug
> Components: Build
> Affects Versions: v0.9.5
> Reporter: Jonathan Hsieh
> Fix For: v0.9.5
>
>
> FLUME-716 added the ability to exclude and include specific builds by using a test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion was not working properly. This should get fixed so that we can exclude multiple tests by adding a
> '-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-758) Test Excludes on maven build doesn't
always work.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097213#comment-13097213 ]
jiraposter@reviews.apache.org commented on FLUME-758:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1716/
-----------------------------------------------------------
(Updated 2011-09-05 16:57:00.394808)
Review request for Flume, Arvind Prabhakar and Eric Sammer.
Changes
-------
updated test info with example to prove this
Summary
-------
commit 27e37dade789b8f77b313573e33fd8fb4d652405
Author: Jonathan Hsieh <jo...@cloudera.com>
Date: Sun Sep 4 12:24:27 2011 -0700
FLUME-758: Test Excludes on maven build doesn't always work
Surefire 2.8.1 does not allow for lists of excluded tests to be specified via command line.
We force the build to use surefire 2.6 which does.
Verions 2.9, 2.8, 2.7.2, 2.7.1 and 2.7 were also tested and they failed to exclude.
This addresses bug flume-758.
https://issues.apache.org/jira/browse/flume-758
Diffs
-----
pom.xml d93d7de
Diff: https://reviews.apache.org/r/1716/diff
Testing (updated)
-------
Tested against versions specified above.
Version 2.8.1 based build.
jon@grimlock:~/proj/cdh-flume$ mvn test -Dtest.exclude.pattern="**/TestA*.java,**/TestF*.java"
...
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running dk.brics.automaton.TestAutomaton
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.089 sec
Running com.cloudera.flume.shell.TestFlumeShell
...
Version 2.6 based build.
jon@grimlock:~/proj/cdh-flume$ mvn test
...
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running com.cloudera.util.consistenthash.TestConsistentHash
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.288 sec
Running com.cloudera.flume.master.TestMasterReport
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.487 sec
Running com.cloudera.flume.agent.diskfailover.TestConcurrentDFOMan
Tests run: 11, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 17.853 sec
Running com.cloudera.util.TestNetUtils
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.959 sec
Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
^CDestroying 1 processes
Destroying process..
Destroyed 1 processes
jon@grimlock:~/proj/cdh-flume$ mvn test -Dtest.exclude.pattern=**/TestC*.java,**/TestM*.java
...
Running com.cloudera.util.TestNetUtils
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.65 sec
Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
^CDestroying 1 processes
Thanks,
jmhsieh
> Test Excludes on maven build doesn't always work.
> -------------------------------------------------
>
> Key: FLUME-758
> URL: https://issues.apache.org/jira/browse/FLUME-758
> Project: Flume
> Issue Type: Bug
> Components: Build
> Affects Versions: v0.9.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: v0.9.5
>
> Attachments: 0001-FLUME-758-Test-Excludes-on-maven-build-doesn-t-alway.patch
>
>
> FLUME-716 added the ability to exclude and include specific builds by using a test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion was not working properly. This should get fixed so that we can exclude multiple tests by adding a
> '-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-758) Test Excludes on maven build doesn't
always work.
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097203#comment-13097203 ]
Jonathan Hsieh commented on FLUME-758:
--------------------------------------
Going to hard code v2.6
> Test Excludes on maven build doesn't always work.
> -------------------------------------------------
>
> Key: FLUME-758
> URL: https://issues.apache.org/jira/browse/FLUME-758
> Project: Flume
> Issue Type: Bug
> Components: Build
> Affects Versions: v0.9.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: v0.9.5
>
>
> FLUME-716 added the ability to exclude and include specific builds by using a test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion was not working properly. This should get fixed so that we can exclude multiple tests by adding a
> '-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-758) Test Excludes on maven build doesn't
always work.
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097202#comment-13097202 ]
Jonathan Hsieh commented on FLUME-758:
--------------------------------------
Tested against Sure fire versions
2.5 Excludes properly
2.6 Excludes properly
2.7 Fails to exclude
2.7.1 Fails to exclude
2.7.2 Fails to exclude
2.8 Fails to exclude
2.9 Fails to exclude
> Test Excludes on maven build doesn't always work.
> -------------------------------------------------
>
> Key: FLUME-758
> URL: https://issues.apache.org/jira/browse/FLUME-758
> Project: Flume
> Issue Type: Bug
> Components: Build
> Affects Versions: v0.9.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: v0.9.5
>
>
> FLUME-716 added the ability to exclude and include specific builds by using a test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion was not working properly. This should get fixed so that we can exclude multiple tests by adding a
> '-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-758) Test Excludes on maven build doesn't
always work.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098370#comment-13098370 ]
jiraposter@reviews.apache.org commented on FLUME-758:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1716/#review1773
-----------------------------------------------------------
Ship it!
lgtm too.
- Arvind
On 2011-09-05 16:57:00, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1716/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-05 16:57:00)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. commit 27e37dade789b8f77b313573e33fd8fb4d652405
bq. Author: Jonathan Hsieh <jo...@cloudera.com>
bq. Date: Sun Sep 4 12:24:27 2011 -0700
bq.
bq. FLUME-758: Test Excludes on maven build doesn't always work
bq.
bq. Surefire 2.8.1 does not allow for lists of excluded tests to be specified via command line.
bq. We force the build to use surefire 2.6 which does.
bq.
bq. Verions 2.9, 2.8, 2.7.2, 2.7.1 and 2.7 were also tested and they failed to exclude.
bq.
bq.
bq. This addresses bug flume-758.
bq. https://issues.apache.org/jira/browse/flume-758
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. pom.xml d93d7de
bq.
bq. Diff: https://reviews.apache.org/r/1716/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against versions specified above.
bq.
bq. Version 2.8.1 based build.
bq. jon@grimlock:~/proj/cdh-flume$ mvn test -Dtest.exclude.pattern="**/TestA*.java,**/TestF*.java"
bq. ...
bq. -------------------------------------------------------
bq. T E S T S
bq. -------------------------------------------------------
bq. Running dk.brics.automaton.TestAutomaton
bq. Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.089 sec
bq. Running com.cloudera.flume.shell.TestFlumeShell
bq. ...
bq.
bq. Version 2.6 based build.
bq. jon@grimlock:~/proj/cdh-flume$ mvn test
bq. ...
bq. -------------------------------------------------------
bq. T E S T S
bq. -------------------------------------------------------
bq. Running com.cloudera.util.consistenthash.TestConsistentHash
bq. Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.288 sec
bq. Running com.cloudera.flume.master.TestMasterReport
bq. Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.487 sec
bq. Running com.cloudera.flume.agent.diskfailover.TestConcurrentDFOMan
bq. Tests run: 11, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 17.853 sec
bq. Running com.cloudera.util.TestNetUtils
bq. Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.959 sec
bq. Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
bq. ^CDestroying 1 processes
bq. Destroying process..
bq. Destroyed 1 processes
bq.
bq. jon@grimlock:~/proj/cdh-flume$ mvn test -Dtest.exclude.pattern=**/TestC*.java,**/TestM*.java
bq. ...
bq. Running com.cloudera.util.TestNetUtils
bq. Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.65 sec
bq. Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
bq. ^CDestroying 1 processes
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> Test Excludes on maven build doesn't always work.
> -------------------------------------------------
>
> Key: FLUME-758
> URL: https://issues.apache.org/jira/browse/FLUME-758
> Project: Flume
> Issue Type: Bug
> Components: Build
> Affects Versions: v0.9.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: v0.9.5
>
> Attachments: 0001-FLUME-758-Test-Excludes-on-maven-build-doesn-t-alway.patch
>
>
> FLUME-716 added the ability to exclude and include specific builds by using a test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion was not working properly. This should get fixed so that we can exclude multiple tests by adding a
> '-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-758) Test Excludes on maven build doesn't
always work.
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097653#comment-13097653 ]
Jonathan Hsieh commented on FLUME-758:
--------------------------------------
I have filed an issue on the SUREFIRE jira detailing the problem here: http://jira.codehaus.org/browse/SUREFIRE-766
> Test Excludes on maven build doesn't always work.
> -------------------------------------------------
>
> Key: FLUME-758
> URL: https://issues.apache.org/jira/browse/FLUME-758
> Project: Flume
> Issue Type: Bug
> Components: Build
> Affects Versions: v0.9.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: v0.9.5
>
> Attachments: 0001-FLUME-758-Test-Excludes-on-maven-build-doesn-t-alway.patch
>
>
> FLUME-716 added the ability to exclude and include specific builds by using a test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion was not working properly. This should get fixed so that we can exclude multiple tests by adding a
> '-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-758) Test Excludes on maven build doesn't
always work.
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated FLUME-758:
---------------------------------
Status: Patch Available (was: Open)
> Test Excludes on maven build doesn't always work.
> -------------------------------------------------
>
> Key: FLUME-758
> URL: https://issues.apache.org/jira/browse/FLUME-758
> Project: Flume
> Issue Type: Bug
> Components: Build
> Affects Versions: v0.9.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: v0.9.5
>
> Attachments: 0001-FLUME-758-Test-Excludes-on-maven-build-doesn-t-alway.patch
>
>
> FLUME-716 added the ability to exclude and include specific builds by using a test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion was not working properly. This should get fixed so that we can exclude multiple tests by adding a
> '-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLUME-758) Test Excludes on maven build doesn't
always work.
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh reassigned FLUME-758:
------------------------------------
Assignee: Jonathan Hsieh
> Test Excludes on maven build doesn't always work.
> -------------------------------------------------
>
> Key: FLUME-758
> URL: https://issues.apache.org/jira/browse/FLUME-758
> Project: Flume
> Issue Type: Bug
> Components: Build
> Affects Versions: v0.9.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: v0.9.5
>
>
> FLUME-716 added the ability to exclude and include specific builds by using a test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion was not working properly. This should get fixed so that we can exclude multiple tests by adding a
> '-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-758) Test Excludes on maven build doesn't
always work.
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated FLUME-758:
---------------------------------
Attachment: 0001-FLUME-758-Test-Excludes-on-maven-build-doesn-t-alway.patch
> Test Excludes on maven build doesn't always work.
> -------------------------------------------------
>
> Key: FLUME-758
> URL: https://issues.apache.org/jira/browse/FLUME-758
> Project: Flume
> Issue Type: Bug
> Components: Build
> Affects Versions: v0.9.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: v0.9.5
>
> Attachments: 0001-FLUME-758-Test-Excludes-on-maven-build-doesn-t-alway.patch
>
>
> FLUME-716 added the ability to exclude and include specific builds by using a test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion was not working properly. This should get fixed so that we can exclude multiple tests by adding a
> '-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-758) Test Excludes on maven build doesn't
always work.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097248#comment-13097248 ]
jiraposter@reviews.apache.org commented on FLUME-758:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1716/#review1748
-----------------------------------------------------------
Ship it!
lgtm. I'm sure it's obvious but we should file a surefire bug upstream.
- Eric
On 2011-09-05 16:57:00, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1716/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-05 16:57:00)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. commit 27e37dade789b8f77b313573e33fd8fb4d652405
bq. Author: Jonathan Hsieh <jo...@cloudera.com>
bq. Date: Sun Sep 4 12:24:27 2011 -0700
bq.
bq. FLUME-758: Test Excludes on maven build doesn't always work
bq.
bq. Surefire 2.8.1 does not allow for lists of excluded tests to be specified via command line.
bq. We force the build to use surefire 2.6 which does.
bq.
bq. Verions 2.9, 2.8, 2.7.2, 2.7.1 and 2.7 were also tested and they failed to exclude.
bq.
bq.
bq. This addresses bug flume-758.
bq. https://issues.apache.org/jira/browse/flume-758
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. pom.xml d93d7de
bq.
bq. Diff: https://reviews.apache.org/r/1716/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against versions specified above.
bq.
bq. Version 2.8.1 based build.
bq. jon@grimlock:~/proj/cdh-flume$ mvn test -Dtest.exclude.pattern="**/TestA*.java,**/TestF*.java"
bq. ...
bq. -------------------------------------------------------
bq. T E S T S
bq. -------------------------------------------------------
bq. Running dk.brics.automaton.TestAutomaton
bq. Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.089 sec
bq. Running com.cloudera.flume.shell.TestFlumeShell
bq. ...
bq.
bq. Version 2.6 based build.
bq. jon@grimlock:~/proj/cdh-flume$ mvn test
bq. ...
bq. -------------------------------------------------------
bq. T E S T S
bq. -------------------------------------------------------
bq. Running com.cloudera.util.consistenthash.TestConsistentHash
bq. Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.288 sec
bq. Running com.cloudera.flume.master.TestMasterReport
bq. Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.487 sec
bq. Running com.cloudera.flume.agent.diskfailover.TestConcurrentDFOMan
bq. Tests run: 11, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 17.853 sec
bq. Running com.cloudera.util.TestNetUtils
bq. Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.959 sec
bq. Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
bq. ^CDestroying 1 processes
bq. Destroying process..
bq. Destroyed 1 processes
bq.
bq. jon@grimlock:~/proj/cdh-flume$ mvn test -Dtest.exclude.pattern=**/TestC*.java,**/TestM*.java
bq. ...
bq. Running com.cloudera.util.TestNetUtils
bq. Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.65 sec
bq. Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
bq. ^CDestroying 1 processes
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> Test Excludes on maven build doesn't always work.
> -------------------------------------------------
>
> Key: FLUME-758
> URL: https://issues.apache.org/jira/browse/FLUME-758
> Project: Flume
> Issue Type: Bug
> Components: Build
> Affects Versions: v0.9.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: v0.9.5
>
> Attachments: 0001-FLUME-758-Test-Excludes-on-maven-build-doesn-t-alway.patch
>
>
> FLUME-716 added the ability to exclude and include specific builds by using a test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion was not working properly. This should get fixed so that we can exclude multiple tests by adding a
> '-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-758) Test Excludes on maven build doesn't
always work.
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated FLUME-758:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Test Excludes on maven build doesn't always work.
> -------------------------------------------------
>
> Key: FLUME-758
> URL: https://issues.apache.org/jira/browse/FLUME-758
> Project: Flume
> Issue Type: Bug
> Components: Build
> Affects Versions: v0.9.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: v0.9.5
>
> Attachments: 0001-FLUME-758-Test-Excludes-on-maven-build-doesn-t-alway.patch
>
>
> FLUME-716 added the ability to exclude and include specific builds by using a test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion was not working properly. This should get fixed so that we can exclude multiple tests by adding a
> '-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-758) Test Excludes on maven build doesn't
always work.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097205#comment-13097205 ]
jiraposter@reviews.apache.org commented on FLUME-758:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1716/
-----------------------------------------------------------
Review request for Flume, Arvind Prabhakar and Eric Sammer.
Summary
-------
commit 27e37dade789b8f77b313573e33fd8fb4d652405
Author: Jonathan Hsieh <jo...@cloudera.com>
Date: Sun Sep 4 12:24:27 2011 -0700
FLUME-758: Test Excludes on maven build doesn't always work
Surefire 2.8.1 does not allow for lists of excluded tests to be specified via command line.
We force the build to use surefire 2.6 which does.
Verions 2.9, 2.8, 2.7.2, 2.7.1 and 2.7 were also tested and they failed to exclude.
This addresses bug flume-758.
https://issues.apache.org/jira/browse/flume-758
Diffs
-----
pom.xml d93d7de
Diff: https://reviews.apache.org/r/1716/diff
Testing
-------
Tested against versions specified above.
Thanks,
jmhsieh
> Test Excludes on maven build doesn't always work.
> -------------------------------------------------
>
> Key: FLUME-758
> URL: https://issues.apache.org/jira/browse/FLUME-758
> Project: Flume
> Issue Type: Bug
> Components: Build
> Affects Versions: v0.9.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: v0.9.5
>
> Attachments: 0001-FLUME-758-Test-Excludes-on-maven-build-doesn-t-alway.patch
>
>
> FLUME-716 added the ability to exclude and include specific builds by using a test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion was not working properly. This should get fixed so that we can exclude multiple tests by adding a
> '-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira