You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Chris Hillery (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/05/27 00:00:48 UTC
Change in asterixdb[master]: Improve creating log directory
Chris Hillery has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/890
Change subject: Improve creating log directory
......................................................................
Improve creating log directory
Change-Id: I1d3df0dbdb46df30b2e6467896e3a224cb7911a6
---
M hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/90/890/1
diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
index ea220c1..e3fe959 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
@@ -140,7 +140,10 @@
pb.redirectErrorStream(true);
File log = new File(config.logdir);
if (! log.mkdirs()) {
- throw new IOException(config.logdir + ": cannot create");
+ if (! log.isDirectory()) {
+ throw new IOException(config.logdir + ": cannot create");
+ }
+ // If the directory IS there, all is well
}
File logfile = new File(config.logdir, "nc-" + ncId + ".log");
pb.redirectOutput(ProcessBuilder.Redirect.appendTo(logfile));
--
To view, visit https://asterix-gerrit.ics.uci.edu/890
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d3df0dbdb46df30b2e6467896e3a224cb7911a6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery <ce...@lambda.nu>
Change in asterixdb[master]: Improve creating log directory
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Improve creating log directory
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1513/
--
To view, visit https://asterix-gerrit.ics.uci.edu/890
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d3df0dbdb46df30b2e6467896e3a224cb7911a6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery <ce...@lambda.nu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No
Change in asterixdb[master]: Improve creating log directory
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has posted comments on this change.
Change subject: Improve creating log directory
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/890
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d3df0dbdb46df30b2e6467896e3a224cb7911a6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery <ce...@lambda.nu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No
Change in asterixdb[master]: Improve creating log directory
Posted by "Chris Hillery (Code Review)" <do...@asterixdb.incubator.apache.org>.
Chris Hillery has submitted this change and it was merged.
Change subject: Improve creating log directory
......................................................................
Improve creating log directory
Change-Id: I1d3df0dbdb46df30b2e6467896e3a224cb7911a6
Reviewed-on: https://asterix-gerrit.ics.uci.edu/890
Reviewed-by: Till Westmann <ti...@apache.org>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
---
M hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified
diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
index ea220c1..e3fe959 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
@@ -140,7 +140,10 @@
pb.redirectErrorStream(true);
File log = new File(config.logdir);
if (! log.mkdirs()) {
- throw new IOException(config.logdir + ": cannot create");
+ if (! log.isDirectory()) {
+ throw new IOException(config.logdir + ": cannot create");
+ }
+ // If the directory IS there, all is well
}
File logfile = new File(config.logdir, "nc-" + ncId + ".log");
pb.redirectOutput(ProcessBuilder.Redirect.appendTo(logfile));
--
To view, visit https://asterix-gerrit.ics.uci.edu/890
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d3df0dbdb46df30b2e6467896e3a224cb7911a6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery <ce...@lambda.nu>
Gerrit-Reviewer: Chris Hillery <ce...@lambda.nu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Change in asterixdb[master]: Improve creating log directory
Posted by "Chris Hillery (Code Review)" <do...@asterixdb.incubator.apache.org>.
Chris Hillery has posted comments on this change.
Change subject: Improve creating log directory
......................................................................
Patch Set 1:
FWIW, I acknowledge the SonarQube violation and choose to disregard. I think the code says more what it means when phrased the way it is.
--
To view, visit https://asterix-gerrit.ics.uci.edu/890
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d3df0dbdb46df30b2e6467896e3a224cb7911a6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery <ce...@lambda.nu>
Gerrit-Reviewer: Chris Hillery <ce...@lambda.nu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No