You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jayzhan211 (via GitHub)" <gi...@apache.org> on 2024/04/03 12:17:40 UTC
[I] Move PhysicalExpr and PhysicalSortExpr to `physical-expr-core` [arrow-datafusion]
jayzhan211 opened a new issue, #9921:
URL: https://github.com/apache/arrow-datafusion/issues/9921
I see -- it seems like the issue is that the accumulator implementation requires PhysicalSortExpr.
To pull the code into its own crate maybe we could pull out the relevant pieces of `datafusion-physical-expr` into `datafusion-physical-core` or something (as a follow on PR)
_Originally posted by @alamb in https://github.com/apache/arrow-datafusion/pull/9874#discussion_r1546829352_
We want to move aggregate function to `aggreagate-functions` crate but avoid importing whole `physical-expr` crate. Therefore, we need to move PhysicalSortExpr for ordering, and of course PhysicalExpr to `physical-expr-core`. Then, we can import it only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Move PhysicalExpr and PhysicalSortExpr to `physical-expr-core` [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #9921:
URL: https://github.com/apache/arrow-datafusion/issues/9921#issuecomment-2034565710
FYI @mustafasrepo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Move PhysicalExpr and PhysicalSortExpr to `physical-expr-core` [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #9921: Move PhysicalExpr and PhysicalSortExpr to `physical-expr-core`
URL: https://github.com/apache/arrow-datafusion/issues/9921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org