You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Erik van Oosten (JIRA)" <ji...@apache.org> on 2008/12/09 09:23:44 UTC
[jira] Created: (WICKET-1974) render_to_buffer does not work for
absolute URLs
render_to_buffer does not work for absolute URLs
------------------------------------------------
Key: WICKET-1974
URL: https://issues.apache.org/jira/browse/WICKET-1974
Project: Wicket
Issue Type: Improvement
Components: wicket, wicket-auth-roles
Affects Versions: 1.4-RC1
Reporter: Erik van Oosten
After installing a WebRequest instance that makes all URLs absolute, render_to_buffer does not work anymore. The problem is that WicketFilter assumes that all URLs are relative (WebFilter#getRelativePath removes the first char of the URL).
Proposed fixes:
-1- in WebApplication#addBufferedResponse remove the leading "/" from the buffer id when present
-2- or alternatively, remove the leading "/" from the URL (when present) in WebRequestCycle, just before addBudderedResponse is called
Here is the installed AbsoluteServletWebRequest:
/**
* WebServletRequest that makes bookmarkable links absolute.
*
* @author Erik van Oosten
*/
public class AbsoluteServletWebRequest extends ServletWebRequest {
public AbsoluteServletWebRequest(HttpServletRequest servletRequest) {
super(servletRequest);
}
@Override
public int getDepthRelativeToWicketHandler() {
return 0;
}
@Override
public String getRelativePathPrefixToWicketHandler() {
return "/";
}
@Override
public String getRelativePathPrefixToContextRoot() {
return "/";
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1974) render_to_buffer does not work for
absolute URLs
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-1974:
------------------------------------
Component/s: (was: wicket-auth-roles)
> render_to_buffer does not work for absolute URLs
> ------------------------------------------------
>
> Key: WICKET-1974
> URL: https://issues.apache.org/jira/browse/WICKET-1974
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Erik van Oosten
>
> After installing a WebRequest instance that makes all URLs absolute, render_to_buffer does not work anymore. The problem is that WicketFilter assumes that all URLs are relative (WebFilter#getRelativePath removes the first char of the URL).
> Proposed fixes:
> -1- in WebApplication#addBufferedResponse remove the leading "/" from the buffer id when present
> -2- or alternatively, remove the leading "/" from the URL (when present) in WebRequestCycle, just before addBudderedResponse is called
> Here is the installed AbsoluteServletWebRequest:
> /**
> * WebServletRequest that makes bookmarkable links absolute.
> *
> * @author Erik van Oosten
> */
> public class AbsoluteServletWebRequest extends ServletWebRequest {
> public AbsoluteServletWebRequest(HttpServletRequest servletRequest) {
> super(servletRequest);
> }
> @Override
> public int getDepthRelativeToWicketHandler() {
> return 0;
> }
> @Override
> public String getRelativePathPrefixToWicketHandler() {
> return "/";
> }
> @Override
> public String getRelativePathPrefixToContextRoot() {
> return "/";
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1974) render_to_buffer does not work for
absolute URLs (with patch)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892144#action_12892144 ]
Hudson commented on WICKET-1974:
--------------------------------
Integrated in Apache Wicket 1.4.x #60 (See [http://hudson.zones.apache.org/hudson/job/Apache%20Wicket%201.4.x/60/])
applied: render_to_buffer does not work for absolute URLs (with patch)
Issue: WICKET-1974
> render_to_buffer does not work for absolute URLs (with patch)
> -------------------------------------------------------------
>
> Key: WICKET-1974
> URL: https://issues.apache.org/jira/browse/WICKET-1974
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Erik van Oosten
> Assignee: Juergen Donnerstag
> Fix For: 1.4.10, 1.5-M1
>
> Attachments: WICKET-1974.patch
>
>
> After installing a WebRequest instance that makes all URLs absolute, render_to_buffer does not work anymore. The problem is that WicketFilter assumes that all URLs are relative (WebFilter#getRelativePath removes the first char of the URL).
> Proposed fixes:
> -1- in WebApplication#addBufferedResponse remove the leading "/" from the buffer id when present
> -2- or alternatively, remove the leading "/" from the URL (when present) in WebRequestCycle, just before addBudderedResponse is called
> Here is the installed AbsoluteServletWebRequest:
> /**
> * WebServletRequest that makes bookmarkable links absolute.
> * Note: use this only when WickterFilter listens on the root context.
> *
> * @author Erik van Oosten
> */
> public class AbsoluteServletWebRequest extends ServletWebRequest {
> public AbsoluteServletWebRequest(HttpServletRequest servletRequest) {
> super(servletRequest);
> }
> @Override
> public int getDepthRelativeToWicketHandler() {
> return 0;
> }
> @Override
> public String getRelativePathPrefixToWicketHandler() {
> return "/";
> }
> @Override
> public String getRelativePathPrefixToContextRoot() {
> return "/";
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1974) render_to_buffer does not work for
absolute URLs (with patch)
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-1974.
----------------------------------------
Assignee: Juergen Donnerstag
Fix Version/s: 1.4.10
1.5-M1
Resolution: Fixed
applied
> render_to_buffer does not work for absolute URLs (with patch)
> -------------------------------------------------------------
>
> Key: WICKET-1974
> URL: https://issues.apache.org/jira/browse/WICKET-1974
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Erik van Oosten
> Assignee: Juergen Donnerstag
> Fix For: 1.4.10, 1.5-M1
>
> Attachments: WICKET-1974.patch
>
>
> After installing a WebRequest instance that makes all URLs absolute, render_to_buffer does not work anymore. The problem is that WicketFilter assumes that all URLs are relative (WebFilter#getRelativePath removes the first char of the URL).
> Proposed fixes:
> -1- in WebApplication#addBufferedResponse remove the leading "/" from the buffer id when present
> -2- or alternatively, remove the leading "/" from the URL (when present) in WebRequestCycle, just before addBudderedResponse is called
> Here is the installed AbsoluteServletWebRequest:
> /**
> * WebServletRequest that makes bookmarkable links absolute.
> * Note: use this only when WickterFilter listens on the root context.
> *
> * @author Erik van Oosten
> */
> public class AbsoluteServletWebRequest extends ServletWebRequest {
> public AbsoluteServletWebRequest(HttpServletRequest servletRequest) {
> super(servletRequest);
> }
> @Override
> public int getDepthRelativeToWicketHandler() {
> return 0;
> }
> @Override
> public String getRelativePathPrefixToWicketHandler() {
> return "/";
> }
> @Override
> public String getRelativePathPrefixToContextRoot() {
> return "/";
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1974) render_to_buffer does not work for
absolute URLs
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-1974:
------------------------------------
Description:
After installing a WebRequest instance that makes all URLs absolute, render_to_buffer does not work anymore. The problem is that WicketFilter assumes that all URLs are relative (WebFilter#getRelativePath removes the first char of the URL).
Proposed fixes:
-1- in WebApplication#addBufferedResponse remove the leading "/" from the buffer id when present
-2- or alternatively, remove the leading "/" from the URL (when present) in WebRequestCycle, just before addBudderedResponse is called
Here is the installed AbsoluteServletWebRequest:
/**
* WebServletRequest that makes bookmarkable links absolute.
* Note: use this only when WickterFilter listens on the root context.
*
* @author Erik van Oosten
*/
public class AbsoluteServletWebRequest extends ServletWebRequest {
public AbsoluteServletWebRequest(HttpServletRequest servletRequest) {
super(servletRequest);
}
@Override
public int getDepthRelativeToWicketHandler() {
return 0;
}
@Override
public String getRelativePathPrefixToWicketHandler() {
return "/";
}
@Override
public String getRelativePathPrefixToContextRoot() {
return "/";
}
}
was:
After installing a WebRequest instance that makes all URLs absolute, render_to_buffer does not work anymore. The problem is that WicketFilter assumes that all URLs are relative (WebFilter#getRelativePath removes the first char of the URL).
Proposed fixes:
-1- in WebApplication#addBufferedResponse remove the leading "/" from the buffer id when present
-2- or alternatively, remove the leading "/" from the URL (when present) in WebRequestCycle, just before addBudderedResponse is called
Here is the installed AbsoluteServletWebRequest:
/**
* WebServletRequest that makes bookmarkable links absolute.
*
* @author Erik van Oosten
*/
public class AbsoluteServletWebRequest extends ServletWebRequest {
public AbsoluteServletWebRequest(HttpServletRequest servletRequest) {
super(servletRequest);
}
@Override
public int getDepthRelativeToWicketHandler() {
return 0;
}
@Override
public String getRelativePathPrefixToWicketHandler() {
return "/";
}
@Override
public String getRelativePathPrefixToContextRoot() {
return "/";
}
}
> render_to_buffer does not work for absolute URLs
> ------------------------------------------------
>
> Key: WICKET-1974
> URL: https://issues.apache.org/jira/browse/WICKET-1974
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Erik van Oosten
>
> After installing a WebRequest instance that makes all URLs absolute, render_to_buffer does not work anymore. The problem is that WicketFilter assumes that all URLs are relative (WebFilter#getRelativePath removes the first char of the URL).
> Proposed fixes:
> -1- in WebApplication#addBufferedResponse remove the leading "/" from the buffer id when present
> -2- or alternatively, remove the leading "/" from the URL (when present) in WebRequestCycle, just before addBudderedResponse is called
> Here is the installed AbsoluteServletWebRequest:
> /**
> * WebServletRequest that makes bookmarkable links absolute.
> * Note: use this only when WickterFilter listens on the root context.
> *
> * @author Erik van Oosten
> */
> public class AbsoluteServletWebRequest extends ServletWebRequest {
> public AbsoluteServletWebRequest(HttpServletRequest servletRequest) {
> super(servletRequest);
> }
> @Override
> public int getDepthRelativeToWicketHandler() {
> return 0;
> }
> @Override
> public String getRelativePathPrefixToWicketHandler() {
> return "/";
> }
> @Override
> public String getRelativePathPrefixToContextRoot() {
> return "/";
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1974) render_to_buffer does not work for
absolute URLs
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-1974:
------------------------------------
Attachment: WICKET-1974.patch
This patch will remove the leading "/" from the buffer id (when present) in WebApplication#addBufferedResponse.
mvn test
runs fine.
Please apply to wicket 1.4 branch.
If trunk is still similar, please apply there to.
> render_to_buffer does not work for absolute URLs
> ------------------------------------------------
>
> Key: WICKET-1974
> URL: https://issues.apache.org/jira/browse/WICKET-1974
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Erik van Oosten
> Attachments: WICKET-1974.patch
>
>
> After installing a WebRequest instance that makes all URLs absolute, render_to_buffer does not work anymore. The problem is that WicketFilter assumes that all URLs are relative (WebFilter#getRelativePath removes the first char of the URL).
> Proposed fixes:
> -1- in WebApplication#addBufferedResponse remove the leading "/" from the buffer id when present
> -2- or alternatively, remove the leading "/" from the URL (when present) in WebRequestCycle, just before addBudderedResponse is called
> Here is the installed AbsoluteServletWebRequest:
> /**
> * WebServletRequest that makes bookmarkable links absolute.
> * Note: use this only when WickterFilter listens on the root context.
> *
> * @author Erik van Oosten
> */
> public class AbsoluteServletWebRequest extends ServletWebRequest {
> public AbsoluteServletWebRequest(HttpServletRequest servletRequest) {
> super(servletRequest);
> }
> @Override
> public int getDepthRelativeToWicketHandler() {
> return 0;
> }
> @Override
> public String getRelativePathPrefixToWicketHandler() {
> return "/";
> }
> @Override
> public String getRelativePathPrefixToContextRoot() {
> return "/";
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1974) render_to_buffer does not work for
absolute URLs (with patch)
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-1974:
------------------------------------
Summary: render_to_buffer does not work for absolute URLs (with patch) (was: render_to_buffer does not work for absolute URLs)
> render_to_buffer does not work for absolute URLs (with patch)
> -------------------------------------------------------------
>
> Key: WICKET-1974
> URL: https://issues.apache.org/jira/browse/WICKET-1974
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Erik van Oosten
> Attachments: WICKET-1974.patch
>
>
> After installing a WebRequest instance that makes all URLs absolute, render_to_buffer does not work anymore. The problem is that WicketFilter assumes that all URLs are relative (WebFilter#getRelativePath removes the first char of the URL).
> Proposed fixes:
> -1- in WebApplication#addBufferedResponse remove the leading "/" from the buffer id when present
> -2- or alternatively, remove the leading "/" from the URL (when present) in WebRequestCycle, just before addBudderedResponse is called
> Here is the installed AbsoluteServletWebRequest:
> /**
> * WebServletRequest that makes bookmarkable links absolute.
> * Note: use this only when WickterFilter listens on the root context.
> *
> * @author Erik van Oosten
> */
> public class AbsoluteServletWebRequest extends ServletWebRequest {
> public AbsoluteServletWebRequest(HttpServletRequest servletRequest) {
> super(servletRequest);
> }
> @Override
> public int getDepthRelativeToWicketHandler() {
> return 0;
> }
> @Override
> public String getRelativePathPrefixToWicketHandler() {
> return "/";
> }
> @Override
> public String getRelativePathPrefixToContextRoot() {
> return "/";
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1974) render_to_buffer does not work for
absolute URLs (with patch)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892145#action_12892145 ]
Hudson commented on WICKET-1974:
--------------------------------
Integrated in Apache Wicket 1.5.x #172 (See [http://hudson.zones.apache.org/hudson/job/Apache%20Wicket%201.5.x/172/])
applied: render_to_buffer does not work for absolute URLs (with patch)
Issue: WICKET-1974
> render_to_buffer does not work for absolute URLs (with patch)
> -------------------------------------------------------------
>
> Key: WICKET-1974
> URL: https://issues.apache.org/jira/browse/WICKET-1974
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Erik van Oosten
> Assignee: Juergen Donnerstag
> Fix For: 1.4.10, 1.5-M1
>
> Attachments: WICKET-1974.patch
>
>
> After installing a WebRequest instance that makes all URLs absolute, render_to_buffer does not work anymore. The problem is that WicketFilter assumes that all URLs are relative (WebFilter#getRelativePath removes the first char of the URL).
> Proposed fixes:
> -1- in WebApplication#addBufferedResponse remove the leading "/" from the buffer id when present
> -2- or alternatively, remove the leading "/" from the URL (when present) in WebRequestCycle, just before addBudderedResponse is called
> Here is the installed AbsoluteServletWebRequest:
> /**
> * WebServletRequest that makes bookmarkable links absolute.
> * Note: use this only when WickterFilter listens on the root context.
> *
> * @author Erik van Oosten
> */
> public class AbsoluteServletWebRequest extends ServletWebRequest {
> public AbsoluteServletWebRequest(HttpServletRequest servletRequest) {
> super(servletRequest);
> }
> @Override
> public int getDepthRelativeToWicketHandler() {
> return 0;
> }
> @Override
> public String getRelativePathPrefixToWicketHandler() {
> return "/";
> }
> @Override
> public String getRelativePathPrefixToContextRoot() {
> return "/";
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.