You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by robdouglas <gi...@git.apache.org> on 2014/06/23 21:08:32 UTC
[GitHub] incubator-streams pull request: STREAMS-113 | Added ability to con...
GitHub user robdouglas opened a pull request:
https://github.com/apache/incubator-streams/pull/42
STREAMS-113 | Added ability to convert a Twitter User object an an Activ...
...ity object.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robdouglas/incubator-streams STREAMS-113
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit bc9fe49270e9b64e2a8deaed7924b2ab4ff22458
Author: Robert Douglas <rd...@w2odigital.com>
Date: 2014-06-23T19:07:09Z
STREAMS-113 | Added ability to convert a Twitter User object an an Activity object.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-113 | Added ability to con...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-113 | Added ability to con...
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on the pull request:
https://github.com/apache/incubator-streams/pull/42#issuecomment-46989006
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-113 | Added ability to con...
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/42#discussion_r14136531
--- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/processor/TwitterTypeConverter.java ---
@@ -158,7 +176,7 @@ public boolean isValidJSON(final String json) {
node = (ObjectNode)mapper.valueToTree(item);
// since data is coming from outside provider, we don't know what type the events are
- Class inClass = TwitterEventClassifier.detectClass((String)item);
+ Class inClass = TwitterEventClassifier.detectClass(item.toString());
--- End diff --
would be better to use mapper.writeValueAsString
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---