[jira] [Commented] (OOZIE-1560) Log messages should have a way of identifying which server they came from when using HA

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785543#comment-13785543 ] 

Hadoop QA commented on OOZIE-1560:
----------------------------------

Testing JIRA OOZIE-1560

Cleaning local svn workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:green}+1{color} the patch does adds/modifies 4 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1334
.    Tests failed: 1
.    Tests errors: 0

.    The patch failed the following testcases:

.      testGetServerUrls(org.apache.oozie.service.TestJobsConcurrencyService)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/817/

> Log messages should have a way of identifying which server they came from when using HA
> ---------------------------------------------------------------------------------------
>
>                 Key: OOZIE-1560
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1560
>             Project: Oozie
>          Issue Type: Improvement
>          Components: HA
>    Affects Versions: trunk
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: OOZIE-1560.patch
>
>
> When using HA, the only way to know which server is processing a specific job is to go into each server's log file and look for log messages about that job; when looking at the logs from the API, there is no way to know.  
> This information can be useful, so it would be good to add the server name as part of the log message.  This can either be done for logs permanently or can be done when a server is aggregating/collating logs from the other servers.  The former is probably more efficient than the latter.  If we go with the former, I'd say that we should always do it, regardless of HA so the log formatting is consistent and in case that server is added to an HA group later.
> For example, instead of this:
> {noformat}
> 2013-09-29 16:46:20,182 WARN org.apache.oozie.command.wf.ActionStartXCommand: USER[root] GROUP[-] TOKEN[] APP[demo-wf] JOB[0000000-130925230553293-oozie-oozi-W] ACTION[0000000-130925230553293-oozie-oozi-W@streaming-node] [***0000000-130925230553293-oozie-oozi-W@streaming-node***]Action status=RUNNING
> {noformat}
> we can have this:
> {noformat}
> 2013-09-29 16:46:20,182 WARN org.apache.oozie.command.wf.ActionStartXCommand: USER[root] GROUP[-] SERVER[oozieA] TOKEN[] APP[demo-wf] JOB[0000000-130925230553293-oozie-oozi-W] ACTION[0000000-130925230553293-oozie-oozi-W@streaming-node] [***0000000-130925230553293-oozie-oozi-W@streaming-node***]Action status=RUNNING
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)