You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/05/10 00:30:03 UTC

Review Request 47146: GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47146/
-----------------------------------------------------------

Review request for geode, Jens Deppe and Jinmei Liao.


Bugs: GEODE-1369
    https://issues.apache.org/jira/browse/GEODE-1369


Repository: geode


Description
-------

GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder

* use TemporaryFolder for all disk files
* re-enable testAlterUpdatesSharedConfig (might be a FlakyTest) -- was disabled for TRAC #52204 but it passes
* use static imports


Diffs
-----

  geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java c342142 

Diff: https://reviews.apache.org/r/47146/diff/


Testing
-------

precheckin


Thanks,

Kirk Lund

Re: Review Request 47146: GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder

Posted by Kirk Lund <ki...@gmail.com>.


> On May 10, 2016, 5:36 a.m., Jinmei Liao wrote:
> > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java, line 542
> > <https://reviews.apache.org/r/47146/diff/1/?file=1377229#file1377229line542>
> >
> >     Is this method used anymore?

Yes, testExportConfig invokes it 5 times for consecutive export config invocations.


- Kirk


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47146/#review132377
-----------------------------------------------------------


On May 10, 2016, 12:30 a.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47146/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 12:30 a.m.)
> 
> 
> Review request for geode, Jens Deppe and Jinmei Liao.
> 
> 
> Bugs: GEODE-1369
>     https://issues.apache.org/jira/browse/GEODE-1369
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder
> 
> * use TemporaryFolder for all disk files
> * re-enable testAlterUpdatesSharedConfig (might be a FlakyTest) -- was disabled for TRAC #52204 but it passes
> * use static imports
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java c342142 
> 
> Diff: https://reviews.apache.org/r/47146/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 47146: GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder

Posted by Jinmei Liao <ji...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47146/#review132377
-----------------------------------------------------------




geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java (line 516)
<https://reviews.apache.org/r/47146/#comment196567>

    Is this method used anymore?


- Jinmei Liao


On May 10, 2016, 12:30 a.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47146/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 12:30 a.m.)
> 
> 
> Review request for geode, Jens Deppe and Jinmei Liao.
> 
> 
> Bugs: GEODE-1369
>     https://issues.apache.org/jira/browse/GEODE-1369
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder
> 
> * use TemporaryFolder for all disk files
> * re-enable testAlterUpdatesSharedConfig (might be a FlakyTest) -- was disabled for TRAC #52204 but it passes
> * use static imports
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java c342142 
> 
> Diff: https://reviews.apache.org/r/47146/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 47146: GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder

Posted by Kevin Duling <ke...@duling.us>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47146/#review132549
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Duling


On May 9, 2016, 5:30 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47146/
> -----------------------------------------------------------
> 
> (Updated May 9, 2016, 5:30 p.m.)
> 
> 
> Review request for geode, Jens Deppe and Jinmei Liao.
> 
> 
> Bugs: GEODE-1369
>     https://issues.apache.org/jira/browse/GEODE-1369
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder
> 
> * use TemporaryFolder for all disk files
> * re-enable testAlterUpdatesSharedConfig (might be a FlakyTest) -- was disabled for TRAC #52204 but it passes
> * use static imports
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java c342142 
> 
> Diff: https://reviews.apache.org/r/47146/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 47146: GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder

Posted by Jens Deppe <jd...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47146/#review132435
-----------------------------------------------------------


Ship it!




Ship It!

- Jens Deppe


On May 10, 2016, 12:30 a.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47146/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 12:30 a.m.)
> 
> 
> Review request for geode, Jens Deppe and Jinmei Liao.
> 
> 
> Bugs: GEODE-1369
>     https://issues.apache.org/jira/browse/GEODE-1369
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder
> 
> * use TemporaryFolder for all disk files
> * re-enable testAlterUpdatesSharedConfig (might be a FlakyTest) -- was disabled for TRAC #52204 but it passes
> * use static imports
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java c342142 
> 
> Diff: https://reviews.apache.org/r/47146/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>