You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "pingtimeout (via GitHub)" <gi...@apache.org> on 2025/11/24 16:56:10 UTC
[PR] Generate release vote e-mail as Github Step Summary [polaris]
pingtimeout opened a new pull request, #3150:
URL: https://github.com/apache/polaris/pull/3150
This fixes #3079. See the last job of this https://github.com/pingtimeout/polaris/actions/runs/19641289254 workflow for a demo (screenshot attached)
<img width="1071" height="1173" alt="image" src="https://github.com/user-attachments/assets/d9f04d3d-423d-44de-a97e-e6964fba9d46" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate release vote e-mail as Github Step Summary [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #3150:
URL: https://github.com/apache/polaris/pull/3150#discussion_r2637375615
##########
.github/workflows/release-3-build-and-publish-artifacts.yml:
##########
@@ -399,3 +404,85 @@ jobs:
| Helm package | ✅ Created and signed |
| Apache dist dev repository | ✅ Staged |
EOT
+
+ generate-release-email:
+ name: Generate Release Email Body
+ runs-on: ubuntu-latest
+ needs: [prerequisite-checks, build-and-publish-artifacts, build-docker, build-and-stage-helm-chart]
+ permissions:
+ contents: read
+ env:
+ DRY_RUN: ${{ needs.prerequisite-checks.outputs.dry_run }}
+ git_tag: ${{ needs.prerequisite-checks.outputs.git_tag }}
+ version_without_rc: ${{ needs.prerequisite-checks.outputs.version_without_rc }}
+ rc_number: ${{ needs.prerequisite-checks.outputs.rc_number }}
+ staging_repository_url: ${{ needs.build-and-publish-artifacts.outputs.staging_repository_url }}
+
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6
+ with:
+ fetch-depth: 0
+
+ - name: Setup test environment
+ uses: ./.github/actions/setup-test-env
+
+ - name: Set up environment variables
+ run: |
+ echo "RELEASEY_DIR=$(pwd)/releasey" >> $GITHUB_ENV
+ echo "LIBS_DIR=$(pwd)/releasey/libs" >> $GITHUB_ENV
+
+ - name: Generate release email body
+ run: |
+ source "${LIBS_DIR}/_version.sh"
+
+ # Extract staging repository ID from URL
+ staging_repo_id=""
+ if [[ -n "${staging_repository_url}" ]]; then
+ staging_repo_id=$(echo "${staging_repository_url}" | sed -n 's|.*/\(orgapachepolaris-[0-9]*\)/$|\1|p')
+ fi
+
+ # Get current commit SHA
+ commit_sha=$(git rev-parse HEAD)
+
+ cat <<EOT >> $GITHUB_STEP_SUMMARY
+ # Vote e-mail
+
+ ## Subject
+ [VOTE] Release Apache Polaris ${version_without_rc} (rc${rc_number})
+
+ ## Body
+ Hi everyone,
+
+ I propose that we release the following RC as the official Apache Polaris ${version_without_rc} release.
+
+ This corresponds to the tag: ${git_tag}
+ * https://github.com/apache/polaris/commits/${git_tag}
+ * https://github.com/apache/polaris/tree/${commit_sha}
+
+ The release tarball, signature, and checksums are here:
+ * https://dist.apache.org/repos/dist/dev/incubator/polaris/${version_without_rc}
+
+ Helm charts are available on:
+ * https://dist.apache.org/repos/dist/dev/incubator/polaris/helm-chart
+
+ NB: you have to build the Docker images locally in order to test Helm charts.
+
+ You can find the KEYS file here:
+ * https://downloads.apache.org/incubator/polaris/KEYS
+
+ Convenience binary artifacts are staged on Nexus. The Maven repositories URLs are:
+ * ${staging_repository_url:-"https://repository.apache.org/content/repositories/${staging_repo_id:-"<ID>"}/"}
+
Review Comment:
Should add the link to the release-verification howto as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate release vote e-mail as Github Step Summary [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #3150:
URL: https://github.com/apache/polaris/pull/3150#discussion_r2637374177
##########
.github/workflows/release-3-build-and-publish-artifacts.yml:
##########
@@ -206,6 +208,9 @@ jobs:
staging_repo_url=$(grep "Created staging repository" gradle_publish_output.txt | sed --regexp-extended "s/^Created staging repository .([a-z0-9-]+). at (.*)/\2/")
fi
+ # Set output for other jobs to consume
+ echo "staging_repository_url=${staging_repo_url}" >> $GITHUB_OUTPUT
Review Comment:
This URL isn't the the "user facing" URL, but an API endpoint.
You likely want to use `staging_repo_id`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate release vote e-mail as Github Step Summary [polaris]
Posted by "pingtimeout (via GitHub)" <gi...@apache.org>.
pingtimeout commented on PR #3150:
URL: https://github.com/apache/polaris/pull/3150#issuecomment-3682751995
Thanks @snazy , it should be good now. See this run for an example : https://github.com/pingtimeout/polaris/actions/runs/20437060916. Now that it was run with dry-run mode so there was no staging repo created and the ID is missing from the URL. But the URL matches those used in previous releases so that should be good. Screenshot for posterity.
<img width="801" height="1060" alt="image" src="https://github.com/user-attachments/assets/feb1f576-e789-45e0-bd40-b23ff7147e70" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate release vote e-mail as Github Step Summary [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #3150:
URL: https://github.com/apache/polaris/pull/3150#discussion_r2637374177
##########
.github/workflows/release-3-build-and-publish-artifacts.yml:
##########
@@ -206,6 +208,9 @@ jobs:
staging_repo_url=$(grep "Created staging repository" gradle_publish_output.txt | sed --regexp-extended "s/^Created staging repository .([a-z0-9-]+). at (.*)/\2/")
fi
+ # Set output for other jobs to consume
+ echo "staging_repository_url=${staging_repo_url}" >> $GITHUB_OUTPUT
Review Comment:
This URL isn't the the "user facing" URL, but an API endpoint (example: `https://repository.apache.org/service/local/staging/deployByRepositoryId/orgapachepolaris-1046`).
You likely want to use `staging_repo_id` (example: `orgapachepolaris-1046`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate release vote e-mail as Github Step Summary [polaris]
Posted by "pingtimeout (via GitHub)" <gi...@apache.org>.
pingtimeout merged PR #3150:
URL: https://github.com/apache/polaris/pull/3150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org