[GitHub] [incubator-superset] junlincc commented on pull request #11181: fix: keep placeholder in multivalue select when a value exists

[GitBox <gi...@apache.org>]

junlincc commented on pull request #11181:
URL: https://github.com/apache/incubator-superset/pull/11181#issuecomment-708071903


   Thanks for pointing that out. @eschutho <https://github.com/eschutho> would
   you mind fixing it?🙏 in terms of the wording, we should probably put more
   thinking into it. @Srinivasa Kadamati <sr...@preset.io> @Stephen Jordan
   <st...@preset.io>  any thoughts?
   
   On Tue, Oct 13, 2020 at 4:48 PM Jesse Yang <no...@github.com> wrote:
   
   > [image: image]
   > <https://user-images.githubusercontent.com/335541/95927503-b7bdc700-0d73-11eb-9afe-aa6fe05d2ef8.png>
   >
   > Looks like the CSS broke after migrating to styled components.
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-superset/pull/11181#issuecomment-708069295>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AQFR5U7AF7OJ3H4XQPIDGQDSKTRNLANCNFSM4SGVLDUQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org