You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2013/08/11 05:37:57 UTC

[Apache Bloodhound] #630: No relations types after upgrading 0.5.3 instance

#630: No relations types after upgrading 0.5.3 instance
---------------------+-----------------
  Reporter:  olemis  |    Owner:
      Type:  defect  |   Status:  new
  Priority:  major   |  Version:  0.6.0
Resolution:          |
---------------------+-----------------
 Minutes ago after upgrading a 0.5.3 instance to 0.6.0 I noticed that
 relations types combo box was empty .

 [[Image(bh_relations_x_128_notypes.png)]]

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/630>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #630: No relations types after upgrading 0.5.3 instance

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#630: No relations types after upgrading 0.5.3 instance
------------------------+---------------------
  Reporter:  olemis     |      Owner:  nobody
      Type:  defect     |     Status:  new
  Priority:  major      |  Milestone:
 Component:  relations  |    Version:  0.6.0
Resolution:             |   Keywords:  upgrade
------------------------+---------------------
Changes (by olemis):

 * owner:   => nobody
 * keywords:   => upgrade
 * component:   => relations


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/630#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #630: No relations types after upgrading 0.5.3 instance

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#630: No relations types after upgrading 0.5.3 instance
------------------------+----------------------
  Reporter:  olemis     |      Owner:  matevzb
      Type:  defect     |     Status:  accepted
  Priority:  major      |  Milestone:
 Component:  relations  |    Version:  0.6.0
Resolution:             |   Keywords:  upgrade
------------------------+----------------------

Comment (by olemis):

 Replying to [comment:4 rjollos]:
 > Replying to [comment:3 olemis]:
 > > > and there is no bhrelations entry in the [components] section.
 > >
 > > IMO components should be explicitly enabled by users. Doing such
 things is not a good practice afaict .
 >
 > I favor at least having it enabled for //new// installations. We are
 treating relations as a core piece of Bloodhound, and I don't see how we
 could justify not enabling it while enabling !MultiProduct, Dashboard and
 Search.
 >

 + ... I was focused on upgrade scenarios rather than new installs . My
 mistake not to make that intention obvious in my previous comment.

 [...]

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/630#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #630: No relations types after upgrading 0.5.3 instance

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#630: No relations types after upgrading 0.5.3 instance
------------------------+----------------------
  Reporter:  olemis     |      Owner:  matevzb
      Type:  defect     |     Status:  accepted
  Priority:  major      |  Milestone:
 Component:  relations  |    Version:  0.6.0
Resolution:             |   Keywords:  upgrade
------------------------+----------------------

Comment (by olemis):

 Replying to [comment:2 matevzb]:
 > Confirmed, upgrade does not properly update base.ini - the
 [bhrelations_links] section is completely missing

 Should be added during the upgrade procedure .

 > and there is no bhrelations entry in the [components] section.

 IMO components should be explicitly enabled by users. Doing such things is
 not a good practice afaict .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/630#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #630: No relations types after upgrading 0.5.3 instance

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#630: No relations types after upgrading 0.5.3 instance
------------------------+-----------------------
  Reporter:  olemis     |      Owner:  matevzb
      Type:  defect     |     Status:  accepted
  Priority:  major      |  Milestone:  Release 7
 Component:  relations  |    Version:  0.6.0
Resolution:             |   Keywords:  upgrade
------------------------+-----------------------
Changes (by rjollos):

 * milestone:   => Release 7


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/630#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #630: No relations types after upgrading 0.5.3 instance

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#630: No relations types after upgrading 0.5.3 instance
------------------------+----------------------
  Reporter:  olemis     |      Owner:  matevzb
      Type:  defect     |     Status:  accepted
  Priority:  major      |  Milestone:
 Component:  relations  |    Version:  0.6.0
Resolution:             |   Keywords:  upgrade
------------------------+----------------------

Comment (by rjollos):

 Replying to [comment:3 olemis]:
 > > and there is no bhrelations entry in the [components] section.
 >
 > IMO components should be explicitly enabled by users. Doing such things
 is not a good practice afaict .

 I favor at least having it enabled for //new// installations. We are
 treating relations as a core piece of Bloodhound, and I don't see how we
 could justify not enabling it while enabling !MultiProduct, Dashboard and
 Search.

 I'm not sure I see a reason to not enable it on upgrade as well, but if we
 don't, then we need to describe in the release notes that there is a new
 component that must be manually enabled.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/630#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #630: No relations types after upgrading 0.5.3 instance

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#630: No relations types after upgrading 0.5.3 instance
------------------------+----------------------
  Reporter:  olemis     |      Owner:  matevzb
      Type:  defect     |     Status:  accepted
  Priority:  major      |  Milestone:
 Component:  relations  |    Version:  0.6.0
Resolution:             |   Keywords:  upgrade
------------------------+----------------------
Changes (by matevzb):

 * owner:  nobody => matevzb
 * status:  new => accepted


Comment:

 Confirmed, upgrade does not properly update base.ini - the
 [bhrelations_links] section is completely missing and there is no
 bhrelations entry in the [components] section.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/630#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #630: No relations types after upgrading 0.5.3 instance

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#630: No relations types after upgrading 0.5.3 instance
------------------------+----------------------
  Reporter:  olemis     |      Owner:  matevzb
      Type:  defect     |     Status:  accepted
  Priority:  major      |  Milestone:
 Component:  relations  |    Version:  0.6.0
Resolution:             |   Keywords:  upgrade
------------------------+----------------------

Comment (by olemis):

 Replying to [comment:5 astaric]:
 > It is enabled in new installations, as bloodhound_setup takes care of
 that.
 >

 ... and it shall continue that way ...

 > There is no obvious way to enable it on upgrade, as it is performed
 using trac-admin upgrade, which only upgrades already enabled modules.

 ;)

 > We could hack the environment upgrade participant of one of the existing
 component,

 -

 > but I do not think that is a good idea.

 +

 > If number of modules included by default will keep increasing, we might
 consider adding --upgrade switch to the bloodhound_setup and then using
 the script to upgrade from one version  to another.

 \o/
 excellent idea !

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/630#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #630: No relations types after upgrading 0.5.3 instance

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#630: No relations types after upgrading 0.5.3 instance
------------------------+----------------------
  Reporter:  olemis     |      Owner:  matevzb
      Type:  defect     |     Status:  accepted
  Priority:  major      |  Milestone:
 Component:  relations  |    Version:  0.6.0
Resolution:             |   Keywords:  upgrade
------------------------+----------------------

Comment (by astaric):

 It is enabled in new installations, as bloodhound_setup takes care of
 that.

 There is no obvious way to enable it on upgrade, as it is performed using
 trac-admin upgrade, which only upgrades already enabled modules. We could
 hack the environment upgrade participant of one of the existing component,
 but I do not think that is a good idea.

 If number of modules included by default will keep increasing, we might
 consider adding --upgrade switch to the bloodhound_setup and then using
 the script to upgrade from one version  to another.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/630#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #630: No relations types after upgrading 0.5.3 instance

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#630: No relations types after upgrading 0.5.3 instance
------------------------+-----------------------
  Reporter:  olemis     |      Owner:  rjollos
      Type:  defect     |     Status:  accepted
  Priority:  major      |  Milestone:  Release 7
 Component:  relations  |    Version:  0.6.0
Resolution:             |   Keywords:  upgrade
------------------------+-----------------------
Changes (by rjollos):

 * owner:  matevzb => rjollos


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/630#comment:10>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #630: No relations types after upgrading 0.5.3 instance

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#630: No relations types after upgrading 0.5.3 instance
------------------------+-----------------------
  Reporter:  olemis     |      Owner:  rjollos
      Type:  defect     |     Status:  closed
  Priority:  major      |  Milestone:  Release 7
 Component:  relations  |    Version:  0.6.0
Resolution:  fixed      |   Keywords:  upgrade
------------------------+-----------------------
Changes (by rjollos):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 (In [1515299])

 Fix for bloodhound relations configuration not being set on upgrade from a
 pre-0.6.0 version. Refs #630.

 Default `bhrelations` configuration is now specified through the option
 default values, rather than in `bloodhound_setup`. Default
 `bhrelations_links` configuration is now written when upgrading the
 environment if a `bhrelations_links` configuration section doesn't already
 exist.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/630#comment:11>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #630: No relations types after upgrading 0.5.3 instance

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#630: No relations types after upgrading 0.5.3 instance
------------------------+-----------------------
  Reporter:  olemis     |      Owner:  matevzb
      Type:  defect     |     Status:  accepted
  Priority:  major      |  Milestone:  Release 7
 Component:  relations  |    Version:  0.6.0
Resolution:             |   Keywords:  upgrade
------------------------+-----------------------

Comment (by rjollos):

 I incorrectly posted this comment to #629 last evening. There was also an
 error in my patch, which I've corrected.

 ----

 Following up on comment:3:ticket:629 and comment:4:ticket:629, I think we
 should consider adding `bhrelations_links` in the
 `IEnvironmentUpgradeParticipant` implementation, similar to how `ticket-
 workflow` is added in
 [http://trac.edgewall.org/browser/tags/trac-1.0.1/trac/ticket/default_workflow.py?marks=149,153-154#L134
 default_workflow].

 I've prepared a patch, but need to do some more testing. I'm just posting
 it now in hopes of getting initial feedback: [attachment:t630-bhrelations-
 links-2.diff].

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/630#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker