[GitHub] [fineract] abraham-menyhart commented on a diff in pull request #3411: FINERACT-1760: savings account externalId support

["abraham-menyhart (via GitHub)" <gi...@apache.org>]

abraham-menyhart commented on code in PR #3411:
URL: https://github.com/apache/fineract/pull/3411#discussion_r1311648580


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountRepository.java:
##########
@@ -65,5 +66,8 @@ SavingsAccount findByIdAndDepositAccountType(@Param("accountId") Long accountId,
 
     Page<SavingsAccount> findByStatus(Integer status, Pageable pageable);
 
-    SavingsAccount findByExternalId(String externalId);
+    SavingsAccount findByExternalId(ExternalId externalId);
+
+    @Query("SELECT sa.id FROM SavingsAccount sa WHERE sa.externalId = :externalId")

Review Comment:
   Yes, nice catch, thanks! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org