[GitHub] [zookeeper] anmolnar commented on issue #994: ZOOKEEPER-3432 Improving zookeeper trace for performance and scalability

[GitBox <gi...@apache.org>]

anmolnar commented on issue #994: ZOOKEEPER-3432 Improving zookeeper trace for performance and scalability
URL: https://github.com/apache/zookeeper/pull/994#issuecomment-562845949
 
 
   I'm probably already a dinosaur, because logging in general, especially logging to a separate process/server is just `syslog`. Full stop. (and forks: rsyslog, syslog-ng, etc.) I'm sure it can be easily achieved by log4j as well.
   
   However I like the approach in this patch especially if it's already proven stable in production, so I'm not against committing a solution which already works nicely.
   
   I agree with @hanm 's suggestions: documentation is super critical here and an on/off switch would also be beneficial.
   
   @gmcatsf This patch has been outstanding for a long time. Any plans on rebasing? You definitely want to do it sooner rather than later, if you want to hit 3.6.0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services