You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by Kay Ousterhout <ka...@gmail.com> on 2014/12/02 21:23:09 UTC
keeping PR titles / descriptions up to date
Hi all,
I've noticed a bunch of times lately where a pull request changes to be
pretty different from the original pull request, and the title /
description never get updated. Because the pull request title and
description are used as the commit message, the incorrect description lives
on forever, making it harder to understand the reason behind a particular
commit without going back and reading the entire conversation on the pull
request. If folks could try to keep these up to date (and committers, try
to remember to verify that the title and description are correct before
making merging pull requests), that would be awesome.
-Kay
Re: keeping PR titles / descriptions up to date
Posted by Andrew Or <an...@databricks.com>.
I realize we're not voting, but +1 to this proposal since commit messages
can't be changed whereas JIRA issues can always be updated after the fact.
2014-12-02 13:05 GMT-08:00 Patrick Wendell <pw...@gmail.com>:
> Also a note on this for committers - it's possible to re-word the
> title during merging, by just running "git commit -a --amend" before
> you push the PR.
>
> - Patrick
>
> On Tue, Dec 2, 2014 at 12:50 PM, Mridul Muralidharan <mr...@gmail.com>
> wrote:
> > I second that !
> > Would also be great if the JIRA was updated accordingly too.
> >
> > Regards,
> > Mridul
> >
> >
> > On Wed, Dec 3, 2014 at 1:53 AM, Kay Ousterhout <ka...@gmail.com>
> wrote:
> >> Hi all,
> >>
> >> I've noticed a bunch of times lately where a pull request changes to be
> >> pretty different from the original pull request, and the title /
> >> description never get updated. Because the pull request title and
> >> description are used as the commit message, the incorrect description
> lives
> >> on forever, making it harder to understand the reason behind a
> particular
> >> commit without going back and reading the entire conversation on the
> pull
> >> request. If folks could try to keep these up to date (and committers,
> try
> >> to remember to verify that the title and description are correct before
> >> making merging pull requests), that would be awesome.
> >>
> >> -Kay
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@spark.apache.org
> > For additional commands, e-mail: dev-help@spark.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@spark.apache.org
> For additional commands, e-mail: dev-help@spark.apache.org
>
>
Re: keeping PR titles / descriptions up to date
Posted by Patrick Wendell <pw...@gmail.com>.
Also a note on this for committers - it's possible to re-word the
title during merging, by just running "git commit -a --amend" before
you push the PR.
- Patrick
On Tue, Dec 2, 2014 at 12:50 PM, Mridul Muralidharan <mr...@gmail.com> wrote:
> I second that !
> Would also be great if the JIRA was updated accordingly too.
>
> Regards,
> Mridul
>
>
> On Wed, Dec 3, 2014 at 1:53 AM, Kay Ousterhout <ka...@gmail.com> wrote:
>> Hi all,
>>
>> I've noticed a bunch of times lately where a pull request changes to be
>> pretty different from the original pull request, and the title /
>> description never get updated. Because the pull request title and
>> description are used as the commit message, the incorrect description lives
>> on forever, making it harder to understand the reason behind a particular
>> commit without going back and reading the entire conversation on the pull
>> request. If folks could try to keep these up to date (and committers, try
>> to remember to verify that the title and description are correct before
>> making merging pull requests), that would be awesome.
>>
>> -Kay
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@spark.apache.org
> For additional commands, e-mail: dev-help@spark.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@spark.apache.org
For additional commands, e-mail: dev-help@spark.apache.org
Re: keeping PR titles / descriptions up to date
Posted by Mridul Muralidharan <mr...@gmail.com>.
I second that !
Would also be great if the JIRA was updated accordingly too.
Regards,
Mridul
On Wed, Dec 3, 2014 at 1:53 AM, Kay Ousterhout <ka...@gmail.com> wrote:
> Hi all,
>
> I've noticed a bunch of times lately where a pull request changes to be
> pretty different from the original pull request, and the title /
> description never get updated. Because the pull request title and
> description are used as the commit message, the incorrect description lives
> on forever, making it harder to understand the reason behind a particular
> commit without going back and reading the entire conversation on the pull
> request. If folks could try to keep these up to date (and committers, try
> to remember to verify that the title and description are correct before
> making merging pull requests), that would be awesome.
>
> -Kay
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@spark.apache.org
For additional commands, e-mail: dev-help@spark.apache.org