You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/02/23 08:07:06 UTC

[kudu-CR] mvcc: clean up public API

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15276


Change subject: mvcc: clean up public API
......................................................................

mvcc: clean up public API

A bunch of MvccManager methods were public but were used only in tests
or via ScopedTransactions. This makes such methods private, and updates
most existing MVCC-related tests to use ScopedTransactions.

There are no major functional changes in this patch.

Change-Id: Ic4e8b2b5ba745b13a0ecb626473642f9d94df85f
---
M src/kudu/tablet/diff_scan-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/mvcc.h
4 files changed, 226 insertions(+), 247 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/15276/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4e8b2b5ba745b13a0ecb626473642f9d94df85f
Gerrit-Change-Number: 15276
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR] mvcc: clean up public API

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15276

to look at the new patch set (#2).

Change subject: mvcc: clean up public API
......................................................................

mvcc: clean up public API

A bunch of MvccManager methods were public but were used only in tests
or via ScopedTransactions. This makes such methods private, and updates
most existing MVCC-related tests to use ScopedTransactions.

There are no major functional changes in this patch.

Change-Id: Ic4e8b2b5ba745b13a0ecb626473642f9d94df85f
---
M src/kudu/tablet/diff_scan-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/mvcc.h
4 files changed, 227 insertions(+), 247 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/15276/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4e8b2b5ba745b13a0ecb626473642f9d94df85f
Gerrit-Change-Number: 15276
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] mvcc: clean up public API

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15276 )

Change subject: mvcc: clean up public API
......................................................................

mvcc: clean up public API

A bunch of MvccManager methods were public but were used only in tests
or via ScopedTransactions. This makes such methods private, and updates
most existing MVCC-related tests to use ScopedTransactions.

There are no major functional changes in this patch.

Change-Id: Ic4e8b2b5ba745b13a0ecb626473642f9d94df85f
Reviewed-on: http://gerrit.cloudera.org:8080/15276
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/diff_scan-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/mvcc.h
4 files changed, 227 insertions(+), 247 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4e8b2b5ba745b13a0ecb626473642f9d94df85f
Gerrit-Change-Number: 15276
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] mvcc: clean up public API

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15276 )

Change subject: mvcc: clean up public API
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4e8b2b5ba745b13a0ecb626473642f9d94df85f
Gerrit-Change-Number: 15276
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 23 Feb 2020 22:13:30 +0000
Gerrit-HasComments: No

[kudu-CR] mvcc: clean up public API

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15276 )

Change subject: mvcc: clean up public API
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4e8b2b5ba745b13a0ecb626473642f9d94df85f
Gerrit-Change-Number: 15276
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 23 Feb 2020 22:52:57 +0000
Gerrit-HasComments: No