You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "michalcukierman (via GitHub)" <gi...@apache.org> on 2023/08/26 14:02:14 UTC
[GitHub] [pulsar] michalcukierman opened a new issue, #21071: [Doc] Docker image build instructions update
michalcukierman opened a new issue, #21071:
URL: https://github.com/apache/pulsar/issues/21071
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
### What issue do you find in Pulsar docs?
The commands:
```bash
mvn clean install -DskipTests
mvn package -Pdocker,-main -am -pl docker/pulsar-all -DskipTests
```
failes due to the fact, that now tagging is done by the maven-docker-plugin. To build the image, the parameter needs to be set first.
### What is your suggestion?
Update the command to:
```bash
gitrev=$(git rev-parse HEAD | colrm 10)
mvn clean install -DskipTests -Dgit.commit.id.abbrev=${gitrev}
mvn package -Pdocker,-main -am -pl docker/pulsar-all -DskipTests -Dgit.commit.id.abbrev=${gitrev}
```
### Any reference?
_No response_
### Are you willing to submit a PR?
- [X] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Doc] Docker image build instructions update [pulsar]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #21071:
URL: https://github.com/apache/pulsar/issues/21071#issuecomment-1760644061
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on issue #21071: [Doc] Docker image build instructions update
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on issue #21071:
URL: https://github.com/apache/pulsar/issues/21071#issuecomment-1694872990
Do you mind improving the multi-arch building as well? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Doc] Docker image build instructions update [pulsar]
Posted by "yohimik (via GitHub)" <gi...@apache.org>.
yohimik commented on issue #21071:
URL: https://github.com/apache/pulsar/issues/21071#issuecomment-5610280426
A version-specific update for anyone finding this issue: current `master` now uses Gradle. [`docker/build.sh`](https://github.com/apache/pulsar/blob/5a47023fa3b29a432649352c0d056a4d3f847203/docker/build.sh) invokes `./gradlew :docker:pulsar-docker-image:dockerBuild`, and the [current Docker README](https://github.com/apache/pulsar/blob/5a47023fa3b29a432649352c0d056a4d3f847203/docker/README.md) describes that route after building the project. The Maven command discussed above needs to stay tied to the older branch it targets.
For the historical multi-arch instructions, #20420 is a useful regression case: `pulsar-all:3.0.0` contained 2.11.0, and maintainers resolved it with 3.0.1. The [3.0.0 child Dockerfile](https://github.com/apache/pulsar/blob/v3.0.0/docker/pulsar-all/Dockerfile) used `FROM apachepulsar/pulsar:latest`. A build guide should verify both the intended parent reference and the version inside each final architecture, rather than only the child tag.
I checked Docker Hub's manifests on 10 September 2026: both `apachepulsar/pulsar-all:3.0.0` and `:3.0.1` still resolve with amd64/arm64 entries. The latter index is `sha256:40835166baed562973fceeb108fc8e43adbbcb2fe8e23e84052ff39ac35ab9d2`. This was a manifest-only check, not a fresh execution of those old images; the content mismatch and repair are the maintainer-confirmed history above.
Disclosure: I maintain [dispat](https://github.com/yohimik/dispat). Its [Docker graph example](https://dispat.dev/examples/docker/) models the provider-publication-before-consumer-build boundary, but that ordering still requires an exact provider tag/digest. The smaller useful change here is to document and test that invariant in the branch-specific build instructions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Doc] Docker image build instructions update [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on issue #21071:
URL: https://github.com/apache/pulsar/issues/21071#issuecomment-6377096667
Thanks @michalcukierman for the report. The build has since moved from Maven to Gradle, and #25403 updated the instructions: the README's "Build custom docker images" section now uses `./gradlew docker` (or `./gradlew docker-all`), and those commands don't need `git.commit.id.abbrev`. Closing as fixed. If something is still wrong with the Gradle instructions, please open a new issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michalcukierman commented on issue #21071: [Doc] Docker image build instructions update
Posted by "michalcukierman (via GitHub)" <gi...@apache.org>.
michalcukierman commented on issue #21071:
URL: https://github.com/apache/pulsar/issues/21071#issuecomment-1695559425
@mattisonchao
Woud it be just adding ` -Ddocker.platforms=linux/amd64,linux/arm64` like:
```bash
gitrev=$(git rev-parse HEAD | colrm 10)
mvn clean install -DskipTests -Dgit.commit.id.abbrev=${gitrev}
mvn package -Pdocker,-main -am -pl docker/pulsar-all -DskipTests -Dgit.commit.id.abbrev=${gitrev} -Ddocker.platforms=linux/amd64,linux/arm64
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Doc] Docker image build instructions update [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat closed issue #21071: [Doc] Docker image build instructions update
URL: https://github.com/apache/pulsar/issues/21071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org