You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by ChinmaySKulkarni <gi...@git.apache.org> on 2018/09/18 23:53:39 UTC

[GitHub] phoenix pull request #339: PHOENIX-4855 Continue to write base table column ...

Github user ChinmaySKulkarni commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/339#discussion_r218630691
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java ---
    @@ -226,10 +228,13 @@ public PTableImpl(PName tenantId, PName schemaName, PName tableName, long timest
                 familyByString.put(family.getName().getString(), family);
             }
             this.families = families;
    +        if (bucketNum!=null) {
    --- End diff --
    
    Can you add a comment as to why we are leaving out the first column here?


---