[GitHub] [arrow-rs] nevi-me commented on issue #3086: Change Field::metadata to HashMap

[GitBox <gi...@apache.org>]

nevi-me commented on issue #3086:
URL: https://github.com/apache/arrow-rs/issues/3086#issuecomment-1312113650

   The Option was most likely purely out of convenience when deserialising to JSON for integration testing. The code was at at ime whenthe metadata was recently introduced (IIRC), so some tests had an empty metadata field in the JSON data while others had nothing.
   
   If integration tests continue to pass, I don't see a reason to keep it optional (perhaps there's a serde flag that can be used, not sure).
   
   And yes, we used `BTreeMap` at the time out of convenience, in hindsight I should have implemented a custom hasher for the HashMap, but TBH it didn't occur to me to do that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org