You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/02/17 07:17:00 UTC
[GitHub] [submarine] jasoonn opened a new pull request #186: Submarine 383
jasoonn opened a new pull request #186: Submarine 383
URL: https://github.com/apache/submarine/pull/186
### What is this PR for?
Implement the frontend of workspace in workbench server with Angular.
### What type of PR is it?
[Feature]
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-383
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380048295
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/project/project.component.ts
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { Component, OnInit, ViewChild, ElementRef } from '@angular/core';
+
+@Component({
+ selector: 'app-project',
+ templateUrl: './project.component.html',
+ styleUrls: ['./project.component.scss']
+})
+export class ProjectComponent implements OnInit {
+ newProject = false;
+ existProjects = [];
+
+ @ViewChild('inputElement', { static: false }) inputElement: ElementRef;
+
+ constructor() { }
+
+ //Todo : get projects data from server
Review comment:
Please refer to the above comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380045847
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/project/new-project-page/new-project-page.component.html
##########
@@ -0,0 +1,134 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<button nz-button nzType="primary" nzShape="circle" style="float:right;margin: 15px;" (click)="clearProject()"><i nz-icon
+ nzType="close" nzTheme="outline"></i></button>
+<br>
+<h1 style="margin-left: 30px;"> Create New Project</h1>
+<div style="padding-left:300px;padding-right:300px;">
+ <nz-steps [nzCurrent]="current">
+ <nz-step nzTitle="Basic Information"></nz-step>
+ <nz-step nzTitle="Initial Project"></nz-step>
+ <nz-step nzTitle="Preview project"></nz-step>
+ </nz-steps>
+</div>
+
+<div [ngSwitch]="current">
+ <div *ngSwitchCase="0">
+ <form #f="ngForm">
+ <br>
+ <div>
+ <label class="form-label"><span class="red-star">* </span> Project Name:</label>
+ <input type="text" id="username" class="form-control" [(ngModel)]="newProjectContent.projectName"
Review comment:
Can you implement the form with a Reactive Approach rather than a Template-Driven approach? The Reactive Approach provided by Angular is very useful for developers to separate the TypeScript code from the Html template, and thus the code will become more readable. You can refer to our HackMD note and this [link](https://github.com/apache/submarine/tree/master/submarine-workbench/workbench-web-ng/src/app/pages/user/register).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380465422
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/team/team.component.html
##########
@@ -0,0 +1,22 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<br>
+<nz-spin [nzSpinning]="isSpinning">
+</nz-spin>
Review comment:
No newline at the end of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jasoonn commented on issue #186: SUBMARINE-383.
Implement frontend of workspace in workbench server with Angular
Posted by GitBox <gi...@apache.org>.
jasoonn commented on issue #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#issuecomment-588636145
@kevin85421 Thank for your advice.
I have updated my pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380048475
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/project/project.component.ts
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { Component, OnInit, ViewChild, ElementRef } from '@angular/core';
+
+@Component({
+ selector: 'app-project',
+ templateUrl: './project.component.html',
+ styleUrls: ['./project.component.scss']
+})
+export class ProjectComponent implements OnInit {
+ newProject = false;
+ existProjects = [];
+
+ @ViewChild('inputElement', { static: false }) inputElement: ElementRef;
+
+ constructor() { }
+
+ //Todo : get projects data from server
+ ngOnInit() {
+ this.existProjects.push({
+ projectName: 'projectName0', description: 'description', tags: ['12', 'Tag 2'], inputTagVisibility: false, projectInputTag: ''
+ });
+ this.existProjects.push({
+ projectName: 'projectName1', description: 'description', tags: ['Unremovable', 'Tag 2'], inputTagVisibility: false, projectInputTag: ''
+ });
+ this.existProjects.push({
+ projectName: 'projectName1', description: 'description', tags: ['Unremovable', 'Tag 2', 'Tag 3'], inputTagVisibility: false, projectInputTag: ''
+ });
+ this.existProjects.push({
+ projectName: 'projectName1', description: 'description', tags: ['Unremovable', 'Tag 2', 'Tag 3'], inputTagVisibility: false, projectInputTag: ''
+ })
+ }
+ //Todo: Update tag in server
+ handleCloseTag(project, tag){
+ project.tags = project.tags.filter(itag => itag!==tag);
+ console.log(project);
+ console.log(tag);
+ }
+ //Todo update tag in server
Review comment:
Please refer to the above comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380465394
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/shared/shared.component.scss
##########
@@ -0,0 +1,18 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
Review comment:
No newline at the end of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jasoonn opened a new pull request #186: SUBMARINE-383.
Implement frontend of workspace in workbench server with Angular
Posted by GitBox <gi...@apache.org>.
jasoonn opened a new pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186
### What is this PR for?
Implement frontend of workspace in workbench server with Angular.
### What type of PR is it?
[Feature]
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-383
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement workspace in workbench-ng
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement workspace in workbench-ng
URL: https://github.com/apache/submarine/pull/186#discussion_r382912056
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/workspace.module.ts
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { NgModule } from '@angular/core';
+import { CommonModule } from '@angular/common';
+import { ComponentsModule } from '@submarine/components/components.module';
+import { NgZorroAntdModule } from 'ng-zorro-antd';
+import { ProjectComponent } from './project/project.component';
+import { ReleaseComponent } from './release/release.component';
+import { TrainingComponent } from './training/training.component';
+import { TeamComponent } from './team/team.component';
+import { SharedComponent } from './shared/shared.component';
+import { FormsModule } from '@angular/forms';
+import { NewProjectPageComponent } from './project/new-project-page/new-project-page.component';
+
+@NgModule({
+ declarations: [
+ ProjectComponent,
+ ReleaseComponent,
+ TrainingComponent,
+ TeamComponent,
+ SharedComponent,
+ NewProjectPageComponent
+ ],
+ imports: [
+ CommonModule,
+ ComponentsModule,
+ NgZorroAntdModule,
+ FormsModule
+ ],
+ exports: [
+ ProjectComponent,
+ ReleaseComponent,
+ TrainingComponent,
+ TeamComponent,
+ SharedComponent,
+ NewProjectPageComponent
+ ]
+ })
+ export class WorkspaceModule {
+ }
+
Review comment:
No newline at end of file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #186: SUBMARINE-383.
Implement workspace in workbench-ng
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #186: SUBMARINE-383. Implement workspace in workbench-ng
URL: https://github.com/apache/submarine/pull/186#issuecomment-590073532
@jasoonn @kevin85421 Thank you for contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380464855
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/project/new-project-page/new-project-page.component.html
##########
@@ -0,0 +1,134 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<button nz-button nzType="primary" nzShape="circle" style="float:right;margin: 15px;" (click)="clearProject()"><i nz-icon
+ nzType="close" nzTheme="outline"></i></button>
+<br>
+<h1 style="margin-left: 30px;"> Create New Project</h1>
+<div style="padding-left:300px;padding-right:300px;">
+ <nz-steps [nzCurrent]="current">
+ <nz-step nzTitle="Basic Information"></nz-step>
+ <nz-step nzTitle="Initial Project"></nz-step>
+ <nz-step nzTitle="Preview project"></nz-step>
+ </nz-steps>
+</div>
+
+<div [ngSwitch]="current">
+ <div *ngSwitchCase="0">
+ <form #f="ngForm">
+ <br>
+ <div>
+ <label class="form-label"><span class="red-star">* </span> Project Name:</label>
+ <input type="text" id="username" class="form-control" [(ngModel)]="newProjectContent.projectName"
+ name="username" required>
+ </div>
+ <div>
+ <label class="form-label"><span class="red-star">* </span>Description:</label>
+ <textarea rows="6" class="form-control" name="projectDescriptin" [(ngModel)]="newProjectContent.description"
+ required></textarea>
+ </div>
+ <div>
+ <label class="form-label"><span class="red-star">* </span>Visibility:</label>
+ <nz-radio-group name="visibility" [(ngModel)]="newProjectContent.visibility">
+ <label class="darkLabel" nz-radio nzValue="Private">Private - Only project collaborators can view or edit the
+ project.</label>
+ <label class="darkLabel" nz-radio nzValue="Team">Team - All members of the team can view the project.</label>
+ <div *ngIf="newProjectContent.visibility==='Team'">
+ <nz-select [(ngModel)]="newProjectContent.team" name="team" nzAllowClear nzPlaceHolder="Choose" style="margin-top: 10px;">
+ <nz-option *ngFor="let team of teams" [nzValue]="team" [nzLabel]="team"></nz-option>
+ </nz-select>
+ </div>
+ <label class="darkLabel" nz-radio nzValue="Public">Public - All authenticated users can view the
+ project.</label>
+ </nz-radio-group>
+ </div>
+ <div *ngIf="newProjectContent.visibility==='Team'||newProjectContent.visibility==='Public'">
+ <label class="form-label"><span class="red-star">* </span>Permission:</label>
+ <nz-radio-group name="permission" [(ngModel)]="newProjectContent.permission">
+ <label class="darkLabel" nz-radio nzValue="View">Can View - All members can view the project.</label>
+ <label class="darkLabel" nz-radio nzValue="Edit">Can Edit - All members can edit the project.</label>
+ <label class="darkLabel" nz-radio nzValue="Execute">Can Execute - All members can execute the project.</label>
+ </nz-radio-group>
+ </div>
+ </form>
+ <div style="text-align: center;">
+ <br>
+ <button nz-button nzType="primary" [disabled]="!f.valid" (click)="next()">
+ Next Step
+ </button>
+ </div>
+ </div>
+ <div style="margin:20px;" *ngSwitchCase="1">
+ <nz-tabset [nzTabPosition]="'top'" [nzType]="'card'">
+ <nz-tab [nzTitle]="blank">
+ <div class="newBlank">
+ <h3 style="padding-top: 130px;">Create a blank project</h3>
+ </div>
+ </nz-tab>
+ <ng-template #blank> <i nz-icon nzType="file" nzTheme="outline"></i> Blank </ng-template>
+ <nz-tab [nzTitle]="template" [nzDisabled]="true"> Template</nz-tab>
+ <ng-template #template> <i nz-icon nzType="database" nzTheme="outline"></i> Template </ng-template>
+ <nz-tab [nzTitle]="upload" [nzDisabled]="true"> upload</nz-tab>
+ <ng-template #upload> <i nz-icon nzType="to-top" nzTheme="outline"></i> Upload </ng-template>
+ <nz-tab [nzTitle]="github" [nzDisabled]="true"> upload</nz-tab>
+ <ng-template #github> <i nz-icon nzType="github" nzTheme="outline"></i>Git Repo </ng-template>
+ </nz-tabset>
+
+ <div style="text-align: center;">
+ <br>
+ <button nz-button nzType="default" (click)="pre()">
+ Previous Step
+ </button>
+ <button nz-button nzType="primary" (click)="next()">
+ Next Step
+ </button>
+ </div>
+ </div>
+ <div *ngSwitchCase="2">
+ <h3 style="margin:30px;color: rgb(82, 82, 82);"><strong>Project Files</strong></h3>
+ <nz-table style="margin:30px;" nzBordered #basicTable [nzData]="newProjectContent.dataSet" [nzNoResult]="'No data record'">
+ <thead>
+ <tr>
+ <th nzWidth="300px">Name</th>
+ <th nzWidth="40px">Size</th>
+ <th nzWidth="80px">Last Modified</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr *ngFor="let data of basicTable.data">
+ <td>{{ data.name }}</td>
+ <td>{{ data.size }}</td>
+ <td>{{ data.time }}</td>
+ </tr>
+ </tbody>
+ </nz-table>
+ <div style="text-align: center;">
+ <br>
+ <button nz-button nzType="default" (click)="pre()" style="margin: 3px;">
+ Previous Step
+ </button>
+ <button nz-button nzType="primary" (click)="done()" style="margin: 3px;">
+ Save
+ </button>
+ <button nz-button nzType="primary" (click)="openNotebook()" [disabled]="true" style="margin: 3px;">
+ Open in Notebook
+ </button>
+ </div>
+ </div>
+</div>
Review comment:
No newline at the end of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380464707
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/project/project.component.scss
##########
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+.editable-tag {
+ background: rgb(255, 255, 255);
+ border-style: dashed;
+}
Review comment:
No newline at the end of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380465521
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/training/training.component.scss
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+.horizontal_dotted_line{
+ border-bottom: 1px dotted [color];
+ width: [put your width here]px;
+ }
Review comment:
No newline at the end of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jasoonn commented on issue #186: SUBMARINE-383.
Implement workspace in workbench-ng
Posted by GitBox <gi...@apache.org>.
jasoonn commented on issue #186: SUBMARINE-383. Implement workspace in workbench-ng
URL: https://github.com/apache/submarine/pull/186#issuecomment-589211969
@liuxunorg Thank for your advice.
I have updated my title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement workspace in workbench-ng
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement workspace in workbench-ng
URL: https://github.com/apache/submarine/pull/186#discussion_r382911757
##########
File path: submarine-test/e2e/src/test/java/org/apache/submarine/integration/workspaceIT.java
##########
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.submarine.integration;
+
+import org.apache.submarine.AbstractSubmarineIT;
+import org.apache.submarine.WebDriverManager;
+import org.apache.submarine.SubmarineITUtils;
+import org.openqa.selenium.By;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+import org.testng.Assert;
+
+public class workspaceIT extends AbstractSubmarineIT {
+
+ public final static Logger LOG = LoggerFactory.getLogger(workspaceIT.class);
+
+ @BeforeClass
+ public static void startUp(){
+ driver = WebDriverManager.getWebDriver();
+ }
+
+ @AfterClass
+ public static void tearDown(){
+ driver.quit();
+ }
+
+ @Test
+ public void workspaceNavigation() throws Exception {
+ // Login
+ LOG.info("Login");
+ pollingWait(By.cssSelector("input[ng-reflect-name='userName']"), MAX_BROWSER_TIMEOUT_SEC).sendKeys("admin");
+ pollingWait(By.cssSelector("input[ng-reflect-name='password']"), MAX_BROWSER_TIMEOUT_SEC).sendKeys("admin");
+ clickAndWait(By.cssSelector("button[class='login-form-button ant-btn ant-btn-primary']"));
+ pollingWait(By.cssSelector("a[routerlink='/workbench/dashboard']"), MAX_BROWSER_TIMEOUT_SEC);
+
+ // Routing to workspace
+ pollingWait(By.xpath("//span[contains(text(), \"Workspace\")]"), MAX_BROWSER_TIMEOUT_SEC).click();
+ Assert.assertEquals(driver.getCurrentUrl(), "http://localhost:8080/workbench/workspace");
+
+ //Test project part
+ pollingWait(By.xpath("//li[contains(text(), \"Project\")]"), MAX_BROWSER_TIMEOUT_SEC).click();
+ Assert.assertEquals(pollingWait(By.xpath("//div[@id='addProjectbtn']"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true);
+ pollingWait(By.xpath("//div[@id='addProjectbtn']/button"), MAX_BROWSER_TIMEOUT_SEC).click();
+ //step1
+ Assert.assertEquals(pollingWait(By.xpath("//form"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true);
+ pollingWait(By.xpath("//input[@id='username']"), MAX_BROWSER_TIMEOUT_SEC).sendKeys("e2e test Project");
+ pollingWait(By.xpath("//textarea[@name='projectDescriptin']"), MAX_BROWSER_TIMEOUT_SEC).sendKeys("e2e test Project description");
+ pollingWait(By.xpath("//div[@class='centerDiv']/button"), MAX_BROWSER_TIMEOUT_SEC).click();
+ //step2
+ Assert.assertEquals(pollingWait(By.xpath("//nz-tabset"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true);
+ pollingWait(By.xpath("//div[@class='centerDiv']/button[last()]"), MAX_BROWSER_TIMEOUT_SEC).click();
+ //step3
+ Assert.assertEquals(pollingWait(By.xpath("//thead"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true);
+ pollingWait(By.xpath("//div[@class='centerDiv']/button[last()-1]"), MAX_BROWSER_TIMEOUT_SEC).click();
+ //return to project page
+ Assert.assertEquals(pollingWait(By.xpath("//div[@id='addProjectbtn']"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true);
+
+
+ //Test release part
+ pollingWait(By.xpath("//li[contains(text(), \"Release\")]"), MAX_BROWSER_TIMEOUT_SEC).click();
+ Assert.assertEquals(pollingWait(By.xpath("//nz-table[@id='releaseTable']"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true);
+
+ //Test training part
+ pollingWait(By.xpath("//li[contains(text(), \"Training\")]"), MAX_BROWSER_TIMEOUT_SEC).click();
+ Assert.assertEquals(pollingWait(By.xpath("//div[@id='trainingDiv']"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true);
+
+ //Test team part
+ pollingWait(By.xpath("//li[contains(text(), \"Team\")]"), MAX_BROWSER_TIMEOUT_SEC).click();
+ Assert.assertEquals(pollingWait(By.xpath("//div[@id='teamDiv']"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true);
+
+
+ // shared part
+ pollingWait(By.xpath("//li[contains(text(), \"Shared\")]"), MAX_BROWSER_TIMEOUT_SEC).click();
+ Assert.assertEquals(pollingWait(By.xpath("//nz-table[@id='sharedTable']"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true);
+
+
+ SubmarineITUtils.sleep(1000, true);
Review comment:
What's this for? The explicit wait is a better method than sleep. You can refer to the [link](https://github.com/apache/submarine/blob/master/submarine-test/e2e/src/test/java/org/apache/submarine/integration/sidebarIT.java) (line73 ~ line76)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement workspace in workbench-ng
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement workspace in workbench-ng
URL: https://github.com/apache/submarine/pull/186#discussion_r382912047
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/training/training.component.scss
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+.horizontal_dotted_line{
+ border-top: 2px dotted whitesmoke;
+ color:transparent;
+}
+
+#trainingDiv{
+ margin: 30px;
+ padding: 10px;
+ background-color:white;
+}
+
+.leaveMargin{
+ margin-left: 10px;
+}
+
+.leaveBothMargin{
+ margin: 10px;
+}
+
+.othersLabel{
+ color: rgb(122, 114, 114);
+ margin-left: 40px;
+}
+
+#trainingSearchTag{
+ width: 400px;
+ margin-left: 10px;
+}
+
+#spanningDiv{
+ margin: 30px;
+ padding: 30px;
+ background-color:white;
+}
Review comment:
No newline at end of file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380465447
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/team/team.component.scss
##########
@@ -0,0 +1,18 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
Review comment:
No newline at the end of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on issue #186: SUBMARINE-383.
Implement workspace in workbench-ng
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on issue #186: SUBMARINE-383. Implement workspace in workbench-ng
URL: https://github.com/apache/submarine/pull/186#issuecomment-590068328
@liuxunorg It looks good for me. I have no additional comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #186: SUBMARINE-383.
Implement workspace in workbench-ng
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #186: SUBMARINE-383. Implement workspace in workbench-ng
URL: https://github.com/apache/submarine/pull/186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380464573
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/release/release.component.scss
##########
@@ -0,0 +1,18 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
Review comment:
No newline at the end of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #186: SUBMARINE-383.
Implement frontend of workspace in workbench server with Angular
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#issuecomment-586873246
@jasoonn Thank for you contribution.
Can you attach screen image, like this https://github.com/hadoopsubmarine/submarine/pull/72
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380039679
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workbench.module.ts
##########
@@ -38,13 +46,20 @@ import { WorkspaceComponent } from './workspace/workspace.component';
InterpreterComponent,
JobComponent,
DataComponent,
- ModelComponent
+ ModelComponent,
+ ProjectComponent,
+ ReleaseComponent,
+ TrainingComponent,
+ TeamComponent,
+ SharedComponent,
+ NewProjectPageComponent
Review comment:
Do these components be used only in the Workspace? If so, we can declare these components with nested hierarchy, a more private method, to protect these components from being accessed by other components.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380048412
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/project/project.component.ts
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { Component, OnInit, ViewChild, ElementRef } from '@angular/core';
+
+@Component({
+ selector: 'app-project',
+ templateUrl: './project.component.html',
+ styleUrls: ['./project.component.scss']
+})
+export class ProjectComponent implements OnInit {
+ newProject = false;
+ existProjects = [];
+
+ @ViewChild('inputElement', { static: false }) inputElement: ElementRef;
+
+ constructor() { }
+
+ //Todo : get projects data from server
+ ngOnInit() {
+ this.existProjects.push({
+ projectName: 'projectName0', description: 'description', tags: ['12', 'Tag 2'], inputTagVisibility: false, projectInputTag: ''
+ });
+ this.existProjects.push({
+ projectName: 'projectName1', description: 'description', tags: ['Unremovable', 'Tag 2'], inputTagVisibility: false, projectInputTag: ''
+ });
+ this.existProjects.push({
+ projectName: 'projectName1', description: 'description', tags: ['Unremovable', 'Tag 2', 'Tag 3'], inputTagVisibility: false, projectInputTag: ''
+ });
+ this.existProjects.push({
+ projectName: 'projectName1', description: 'description', tags: ['Unremovable', 'Tag 2', 'Tag 3'], inputTagVisibility: false, projectInputTag: ''
+ })
+ }
+ //Todo: Update tag in server
Review comment:
Please refer to the above comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #186: SUBMARINE-383.
Implement workspace in workbench-ng
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #186: SUBMARINE-383. Implement workspace in workbench-ng
URL: https://github.com/apache/submarine/pull/186#issuecomment-589471057
@jasoonn @kevin85421 If this PR can be merged, please tell me, @yuanzac or @tangzhankun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jasoonn commented on issue #186: SUBMARINE-383.
Implement workspace in workbench-ng
Posted by GitBox <gi...@apache.org>.
jasoonn commented on issue #186: SUBMARINE-383. Implement workspace in workbench-ng
URL: https://github.com/apache/submarine/pull/186#issuecomment-590013991
@kevin85421 Thank for your advice.
I have updated the pr.
@yuanzac This pr pr is ready to merge. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380047773
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/project/new-project-page/new-project-page.component.ts
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { Component, OnInit, ViewChild, Output, EventEmitter, Input } from '@angular/core';
+import { NgForm } from '@angular/forms';
+
+
+@Component({
+ selector: 'app-new-project-page',
+ templateUrl: './new-project-page.component.html',
+ styleUrls: ['./new-project-page.component.scss']
+})
+export class NewProjectPageComponent implements OnInit {
+ @Output() closeProjectPage = new EventEmitter<boolean>();
+ @ViewChild('f', { static: true }) signupForm: NgForm;
+ //Todo: get team from API
Review comment:
// TODO(jasoonn): get team from API
By adding the comment, IDEA (the java editor) will display all TODOs in a view.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on issue #186: SUBMARINE-383.
Implement workspace in workbench-ng
Posted by GitBox <gi...@apache.org>.
yuanzac commented on issue #186: SUBMARINE-383. Implement workspace in workbench-ng
URL: https://github.com/apache/submarine/pull/186#issuecomment-589936347
@jasoonn,
Thanks for the contributions. Is this PR ready to be merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jasoonn commented on issue #186: SUBMARINE-383.
Implement frontend of workspace in workbench server with Angular
Posted by GitBox <gi...@apache.org>.
jasoonn commented on issue #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#issuecomment-587234185
@kevin85421 @liuxunorg Thank you for your advice.
I've updated my pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380030494
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workbench.component.html
##########
@@ -74,7 +74,7 @@ <h1>Submarine</h1>
</div>
</div>
</nz-header>
- <nz-content>
+ <nz-content style="margin: 0px;">
Review comment:
Use "id" to specify the conditions that need this style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380048119
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/project/new-project-page/new-project-page.component.ts
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { Component, OnInit, ViewChild, Output, EventEmitter, Input } from '@angular/core';
+import { NgForm } from '@angular/forms';
+
+
+@Component({
+ selector: 'app-new-project-page',
+ templateUrl: './new-project-page.component.html',
+ styleUrls: ['./new-project-page.component.scss']
+})
+export class NewProjectPageComponent implements OnInit {
+ @Output() closeProjectPage = new EventEmitter<boolean>();
+ @ViewChild('f', { static: true }) signupForm: NgForm;
+ //Todo: get team from API
+ teams = ['ciil'];
+
+ current = 0;
+
+ newProjectContent = { projectName: 'projectName', description: 'description', visibility: 'Private', team: '' ,permission: 'view', dataSet: []};
+
+
+ constructor() { }
+
+ ngOnInit() {
+ }
+
+
+ clearProject(){
+ this.closeProjectPage.emit(true);
+ }
+
+ pre(): void {
+ this.current -= 1;
+ }
+
+ next(): void {
+ this.current += 1;
+ }
+
+ //Todo : Add the new project
+ done(): void{
+ console.log(this.newProjectContent);
+ this.clearProject();
+ }
+
+ //Todo : open in notebook
Review comment:
Please refer to the above comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #186: SUBMARINE-383.
Implement workspace in workbench-ng
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #186: SUBMARINE-383. Implement workspace in workbench-ng
URL: https://github.com/apache/submarine/pull/186#issuecomment-590060474
Will merge if no more comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380048066
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/project/new-project-page/new-project-page.component.ts
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { Component, OnInit, ViewChild, Output, EventEmitter, Input } from '@angular/core';
+import { NgForm } from '@angular/forms';
+
+
+@Component({
+ selector: 'app-new-project-page',
+ templateUrl: './new-project-page.component.html',
+ styleUrls: ['./new-project-page.component.scss']
+})
+export class NewProjectPageComponent implements OnInit {
+ @Output() closeProjectPage = new EventEmitter<boolean>();
+ @ViewChild('f', { static: true }) signupForm: NgForm;
+ //Todo: get team from API
+ teams = ['ciil'];
+
+ current = 0;
+
+ newProjectContent = { projectName: 'projectName', description: 'description', visibility: 'Private', team: '' ,permission: 'view', dataSet: []};
+
+
+ constructor() { }
+
+ ngOnInit() {
+ }
+
+
+ clearProject(){
+ this.closeProjectPage.emit(true);
+ }
+
+ pre(): void {
+ this.current -= 1;
+ }
+
+ next(): void {
+ this.current += 1;
+ }
+
+ //Todo : Add the new project
Review comment:
Please refer to the above comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380464643
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/release/release.component.html
##########
@@ -0,0 +1,49 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<nz-input-group style="width: 200px;margin-top: 20px;margin-left: 20px;" [nzSuffix]="suffixIconSearch">
+ <input type="text" nz-input placeholder="input search text" />
+</nz-input-group>
+<ng-template #suffixIconSearch>
+ <i nz-icon nzType="search"></i>
+</ng-template>
+<nz-spin [nzSpinning]="isSpinning">
+ <nz-table style="margin-left:20px;margin-right:20px;" nzBordered #basicTable [nzData]="dataSet" [nzNoResult]="'No data'">
+ <thead>
+ <tr>
+ <th nzWidth="60px">Name</th>
+ <th nzWidth="60px">Owner</th>
+ <th nzWidth="60px">Status</th>
+ <th nzWidth="60px">Commit Info</th>
+ <th nzWidth="60px">LastUpdated</th>
+ <th nzWidth="60px">Action</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr *ngFor="let data of basicTable.data">
+ <td>{{ data.name }}</td>
+ <td>{{ data.owner }}</td>
+ <td>{{ data.status }}</td>
+ <td>{{ data.commitInfo }}</td>
+ <td>{{ data.time }}</td>
+ <td>{{ data.action }}</td>
+ </tr>
+ </tbody>
+ </nz-table>
+</nz-spin>
Review comment:
No newline at the end of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #186: SUBMARINE-383.
Implement frontend of workspace in workbench server with Angular
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#issuecomment-588994487
@jasoonn The title of PR is too long now, and the title will be truncated after being merged into the git repo.
So. Maybe you can change the title of PR to `SUBMARINE-383. Implement workspace in workbench-ng`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #186:
SUBMARINE-383. Implement frontend of workspace in workbench server with
Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380465359
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workspace/shared/shared.component.html
##########
@@ -0,0 +1,49 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<nz-input-group style="width: 200px;margin-top: 20px;margin-left: 20px;" [nzSuffix]="suffixIconSearch">
+ <input type="text" nz-input placeholder="input search text" />
+</nz-input-group>
+<ng-template #suffixIconSearch>
+ <i nz-icon nzType="search"></i>
+</ng-template>
+<nz-spin [nzSpinning]="isSpinning">
+ <nz-table style="margin-left:20px;margin-right:20px;" nzBordered #basicTable [nzData]="dataSet" [nzNoResult]="'No data'">
+ <thead>
+ <tr>
+ <th nzWidth="60px">Name</th>
+ <th nzWidth="60px">Owner</th>
+ <th nzWidth="60px">Status</th>
+ <th nzWidth="60px">Commit Info</th>
+ <th nzWidth="60px">LastUpdated</th>
+ <th nzWidth="60px">Action</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr *ngFor="let data of basicTable.data">
+ <td>{{ data.name }}</td>
+ <td>{{ data.owner }}</td>
+ <td>{{ data.status }}</td>
+ <td>{{ data.commitInfo }}</td>
+ <td>{{ data.time }}</td>
+ <td>{{ data.action }}</td>
+ </tr>
+ </tbody>
+ </nz-table>
+</nz-spin>
Review comment:
No newline at the end of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jasoonn closed pull request #186: SUBMARINE-383.
Implement frontend of workspace in workbench server with Angular
Posted by GitBox <gi...@apache.org>.
jasoonn closed pull request #186: SUBMARINE-383. Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org