You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/23 19:25:48 UTC
[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5318: boards/arm/samv7/same70-qmtech: enable slow crystal
pkarashchenko opened a new pull request #5318:
URL: https://github.com/apache/incubator-nuttx/pull/5318
## Summary
SAME70-QMTECH has 32kHz oscillator installed. Enable it.
## Impact
None
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5318: boards/arm/samv7/same70-qmtech: enable slow crystal
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5318:
URL: https://github.com/apache/incubator-nuttx/pull/5318#discussion_r790321856
##########
File path: boards/arm/samv7/same70-qmtech/include/board.h
##########
@@ -46,11 +46,11 @@
* CPU clock: 120MHz
*
* There can be two on-board crystals. However, the 32.768 crystal is not
- * populated on the stock SAME70. The fallback is to use th on-chip, slow RC
- * oscillator which has a frequency of 22-42 KHz, nominally 32 KHz.
+ * populated on the stock SAME70. The fallback is to use thee on-chip, slow
+ * RC oscillator which has a frequency of 22-42 KHz, nominally 32 KHz.
*/
-#undef BOARD_HAVE_SLOWXTAL /* Slow crystal not populated */
+#define BOARD_HAVE_SLOWXTAL 1 /* Slow crystal is populated */
#define BOARD_SLOWCLK_FREQUENCY (32000) /* 32 KHz RC oscillator (nominal) */
Review comment:
Yes. You are right!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5318: boards/arm/samv7/same70-qmtech: enable slow crystal
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #5318:
URL: https://github.com/apache/incubator-nuttx/pull/5318#discussion_r790321655
##########
File path: boards/arm/samv7/same70-qmtech/include/board.h
##########
@@ -46,11 +46,11 @@
* CPU clock: 120MHz
*
* There can be two on-board crystals. However, the 32.768 crystal is not
- * populated on the stock SAME70. The fallback is to use th on-chip, slow RC
- * oscillator which has a frequency of 22-42 KHz, nominally 32 KHz.
+ * populated on the stock SAME70. The fallback is to use thee on-chip, slow
+ * RC oscillator which has a frequency of 22-42 KHz, nominally 32 KHz.
*/
-#undef BOARD_HAVE_SLOWXTAL /* Slow crystal not populated */
+#define BOARD_HAVE_SLOWXTAL 1 /* Slow crystal is populated */
#define BOARD_SLOWCLK_FREQUENCY (32000) /* 32 KHz RC oscillator (nominal) */
Review comment:
Shouldn't the slowclk frequency be updated to 32768 ? The Y1 crystal in the board is 32.768 KHz, I think 32000 is when using the slow internal RC
##########
File path: boards/arm/samv7/same70-qmtech/include/board.h
##########
@@ -46,11 +46,11 @@
* CPU clock: 120MHz
*
* There can be two on-board crystals. However, the 32.768 crystal is not
Review comment:
Please fix the text too. It is saying that "the 32.768 crystal in not populated on ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5318: boards/arm/samv7/same70-qmtech: enable slow crystal
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5318:
URL: https://github.com/apache/incubator-nuttx/pull/5318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org