[jira] [Commented] (HADOOP-12637) Docker building support doesn't support root user

["Niels Basjes (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055704#comment-15055704 ] 

Niels Basjes commented on HADOOP-12637:
---------------------------------------

The actual scripting I wrote actually checks (and fails) when you are root.
The function I wrote is called "failIfUserIsRoot"
https://github.com/apache/hadoop/blob/trunk/dev-support/docker/hadoop_env_checks.sh#L58

Docker has the nasty effect of falling back to the root user in a container if something goes wrong (or if you use an 'old' docker version).
If this happens then the files that are mapped in the docker container are then written by 'root' during the build. The effect: When you leave the docker again you cannot delete these files and directories anymore.
Because it is in general a "Bad Idea" to work as the root user I used "are you root in the container" as a 'detection' to know something went wrong.

So if there is a need to change anything then I think a simple extra line in the BUILDING.TXT should suffice.


> Docker building support doesn't support root user
> -------------------------------------------------
>
>                 Key: HADOOP-12637
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12637
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>
> According to the instructions in *BUILDING.txt*, started the docker building but as root user. and then found it doesn't work. The related scripts need to be improved to support root user or if we won't, better to update *BUILDING.txt* to explicitly say root user isn't supported. This may save somebody's time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)