[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #4226: [Bug][Spark-Translation] Fix a bug of Spark Translation when has a timestamp/date type filed in source

["ashulin (via GitHub)" <gi...@apache.org>]

ashulin commented on code in PR #4226:
URL: https://github.com/apache/incubator-seatunnel/pull/4226#discussion_r1125629745


##########
seatunnel-e2e/seatunnel-transforms-v2-e2e/src/test/java/org/apache/seatunnel/e2e/transform/TestSparkDateTimeTransformIT.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.e2e.transform;
+
+import org.apache.seatunnel.e2e.common.AbstractSparkContainer;
+import org.apache.seatunnel.e2e.common.container.TestContainer;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.TestTemplate;
+import org.testcontainers.containers.Container;
+
+import java.io.IOException;
+
+public class TestSparkDateTimeTransformIT extends TestSuiteBase {
+
+    @TestTemplate
+    public void testSparkDateTimeTransform(TestContainer container)
+            throws IOException, InterruptedException {
+        if (container instanceof AbstractSparkContainer) {
+            Container.ExecResult execResult =
+                    container.executeJob("/spark_date_time_transform.conf");
+            Assertions.assertEquals(0, execResult.getExitCode());
+        }
+    }

Review Comment:
   ```suggestion
   @DisabledOnContainer(
           value = {},
           type = {EngineType.SEATUNNEL, EngineType.FLINK},
           disabledReason = "")
   public class TestSparkDateTimeTransformIT extends TestSuiteBase {
   
       @TestTemplate
       public void testSparkDateTimeTransform(TestContainer container)
               throws IOException, InterruptedException {
           Container.ExecResult execResult = container.executeJob("/spark_date_time_transform.conf");
           Assertions.assertEquals(0, execResult.getExitCode());
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org