You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/02/19 23:11:03 UTC
[GitHub] [calcite] xndai opened a new pull request #1817: [CALCITE-3807]
checkForSatisfiedConverters() is unnecessary
xndai opened a new pull request #1817: [CALCITE-3807] checkForSatisfiedConverters() is unnecessary
URL: https://github.com/apache/calcite/pull/1817
When VolcanoPlanner registers an abstract converter, it adds the converter into set.abstractConverters list, then calls checkSatisfiedConverter() to see if any converter is satisfied and can be remove from the list. But for every abstract converter, it always satisfies itself (changeTraitsUsingConverters() returns itself). Basically the converter would be removed from the list right after it's added. So this check is completely unnecessary and it slows down the planner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] danny0405 merged pull request #1817: [CALCITE-3807]
checkForSatisfiedConverters() is unnecessary
Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #1817: [CALCITE-3807] checkForSatisfiedConverters() is unnecessary
URL: https://github.com/apache/calcite/pull/1817
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services