You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "zbendhiba (via GitHub)" <gi...@apache.org> on 2023/03/21 14:31:34 UTC
[GitHub] [camel-quarkus] zbendhiba opened a new pull request, #4680: Init Migrating to Camel Quarkus 3.0 guide
zbendhiba opened a new pull request, #4680:
URL: https://github.com/apache/camel-quarkus/pull/4680
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4680: Init Migrating to Camel Quarkus 3.0 guide
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on PR #4680:
URL: https://github.com/apache/camel-quarkus/pull/4680#issuecomment-1477969390
I'm not sure then how we would like to communicate around those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba merged pull request #4680: Init Migrating to Camel Quarkus 3.0 guide
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba merged PR #4680:
URL: https://github.com/apache/camel-quarkus/pull/4680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4680: Init Migrating to Camel Quarkus 3.0 guide
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on PR #4680:
URL: https://github.com/apache/camel-quarkus/pull/4680#issuecomment-1477949541
@davsclaus @oscerd Can you confirm that the list of these removed extensions is a permanent removal?
I checked the list from the [Camel 4 Migration guide](https://camel.apache.org/manual/camel-4-migration-guide.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4680: Init Migrating to Camel Quarkus 3.0 guide
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on PR #4680:
URL: https://github.com/apache/camel-quarkus/pull/4680#issuecomment-1477973158
At the same time the artifacts don't exist in maven central for 3.0.0-M1 so I guess it's fair to post this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #4680: Init Migrating to Camel Quarkus 3.0 guide
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on code in PR #4680:
URL: https://github.com/apache/camel-quarkus/pull/4680#discussion_r1143563244
##########
docs/modules/ROOT/pages/migration-guide/3.0.0.adoc:
##########
@@ -0,0 +1,32 @@
+= Camel Quarkus 3.0.0 Migration Guide
+
+The following guide outlines how to adapt your code to changes that were made in Camel Quarkus 3.0.0.
+
+== Changes in Quarkus
+
+Please refer to https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0[Quarkus 3.0.0 Migration Guide].
+
+== Changes in Camel
+
+Pleaser refer to https://camel.apache.org/manual/camel-4-migration-guide.html[Apache Camel 3.x to 4.0 Migration guide].
+
+== Removed extensions
+
+The following extensions has been removed.
+
+[options="header"]
+|===
+| Component | Alternative component(s) | Status of removal
Review Comment:
Oh yeah thank you very much. I changed my version and forgot to remove this header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on pull request #4680: Init Migrating to Camel Quarkus 3.0 guide
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #4680:
URL: https://github.com/apache/camel-quarkus/pull/4680#issuecomment-1477956170
Yeah 90% are - camel-activemq may come back later, they talk about releasing a jakarta compatible client JAR. optaplanner and swift may come back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] oscerd commented on pull request #4680: Init Migrating to Camel Quarkus 3.0 guide
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #4680:
URL: https://github.com/apache/camel-quarkus/pull/4680#issuecomment-1477975533
It's a milestone so it's fine to go like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #4680: Init Migrating to Camel Quarkus 3.0 guide
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #4680:
URL: https://github.com/apache/camel-quarkus/pull/4680#discussion_r1143532470
##########
docs/modules/ROOT/pages/migration-guide/3.0.0.adoc:
##########
@@ -0,0 +1,32 @@
+= Camel Quarkus 3.0.0 Migration Guide
+
+The following guide outlines how to adapt your code to changes that were made in Camel Quarkus 3.0.0.
+
+== Changes in Quarkus
+
+Please refer to https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0[Quarkus 3.0.0 Migration Guide].
+
+== Changes in Camel
+
+Pleaser refer to https://camel.apache.org/manual/camel-4-migration-guide.html[Apache Camel 3.x to 4.0 Migration guide].
Review Comment:
Typo `Pleaser`.
Also nitpick - could use `xref` for the link.
##########
docs/modules/ROOT/pages/migration-guide/3.0.0.adoc:
##########
@@ -0,0 +1,32 @@
+= Camel Quarkus 3.0.0 Migration Guide
+
+The following guide outlines how to adapt your code to changes that were made in Camel Quarkus 3.0.0.
+
+== Changes in Quarkus
+
+Please refer to https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0[Quarkus 3.0.0 Migration Guide].
+
+== Changes in Camel
+
+Pleaser refer to https://camel.apache.org/manual/camel-4-migration-guide.html[Apache Camel 3.x to 4.0 Migration guide].
+
+== Removed extensions
+
+The following extensions has been removed.
+
+[options="header"]
+|===
+| Component | Alternative component(s) | Status of removal
Review Comment:
Do we need the `Status of removal` column? It's making the table render a bit weird:
https://github.com/apache/camel-quarkus/blob/6e87568aca7445f0a522c8a01b19298876e49c4d/docs/modules/ROOT/pages/migration-guide/3.0.0.adoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #4680: Init Migrating to Camel Quarkus 3.0 guide
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #4680:
URL: https://github.com/apache/camel-quarkus/pull/4680#discussion_r1143533052
##########
docs/modules/ROOT/pages/migration-guide/3.0.0.adoc:
##########
@@ -0,0 +1,32 @@
+= Camel Quarkus 3.0.0 Migration Guide
+
+The following guide outlines how to adapt your code to changes that were made in Camel Quarkus 3.0.0.
+
+== Changes in Quarkus
+
+Please refer to https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0[Quarkus 3.0.0 Migration Guide].
+
+== Changes in Camel
+
+Pleaser refer to https://camel.apache.org/manual/camel-4-migration-guide.html[Apache Camel 3.x to 4.0 Migration guide].
+
+== Removed extensions
+
+The following extensions has been removed.
Review Comment:
```suggestion
The following extensions have been removed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org