You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Clark Jefcoat (JIRA)" <ji...@apache.org> on 2010/02/08 18:54:28 UTC
[jira] Created: (HADOOP-6546) BloomMapFile can return false
negatives
BloomMapFile can return false negatives
---------------------------------------
Key: HADOOP-6546
URL: https://issues.apache.org/jira/browse/HADOOP-6546
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 0.20.1
Reporter: Clark Jefcoat
BloomMapFile can return false negatives when using keys of varying sizes. If the amount of data written by the write() method of your key class differs between instance of your key, your BloomMapFile may return false negatives.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6546) BloomMapFile can return false
negatives
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-6546:
--------------------------------
Status: Patch Available (was: Open)
Marking patch available so the Hudson QA bot tests this.
> BloomMapFile can return false negatives
> ---------------------------------------
>
> Key: HADOOP-6546
> URL: https://issues.apache.org/jira/browse/HADOOP-6546
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1
> Reporter: Clark Jefcoat
> Attachments: HADOOP-6546.patch
>
>
> BloomMapFile can return false negatives when using keys of varying sizes. If the amount of data written by the write() method of your key class differs between instance of your key, your BloomMapFile may return false negatives.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6546) BloomMapFile can return false
negatives
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847760#action_12847760 ]
Hudson commented on HADOOP-6546:
--------------------------------
Integrated in Hadoop-Common-trunk #282 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/282/])
. BloomMapFile can return false negatives. Contributed by Clark Jefcoat.
> BloomMapFile can return false negatives
> ---------------------------------------
>
> Key: HADOOP-6546
> URL: https://issues.apache.org/jira/browse/HADOOP-6546
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1
> Reporter: Clark Jefcoat
> Assignee: Clark Jefcoat
> Fix For: 0.22.0
>
> Attachments: HADOOP-6546.patch
>
>
> BloomMapFile can return false negatives when using keys of varying sizes. If the amount of data written by the write() method of your key class differs between instance of your key, your BloomMapFile may return false negatives.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6546) BloomMapFile can return false
negatives
Posted by "Clark Jefcoat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831021#action_12831021 ]
Clark Jefcoat commented on HADOOP-6546:
---------------------------------------
The issue is with the call
{{
bloomKey.set(buf.getData(), 1.0);
}}
which appears twice in the BloomMapFile source. The buf variable is a DataOutputBuffer. The documentation for DataOutputBuffer clearly states that getData() is only valid to getLength(). But bloomKey is an o.a.h.util.bloom.Key which expects the entire array that it is getting to be valid.
> BloomMapFile can return false negatives
> ---------------------------------------
>
> Key: HADOOP-6546
> URL: https://issues.apache.org/jira/browse/HADOOP-6546
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1
> Reporter: Clark Jefcoat
>
> BloomMapFile can return false negatives when using keys of varying sizes. If the amount of data written by the write() method of your key class differs between instance of your key, your BloomMapFile may return false negatives.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6546) BloomMapFile can return false
negatives
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831127#action_12831127 ]
Hadoop QA commented on HADOOP-6546:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12435190/HADOOP-6546.patch
against trunk revision 907549.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/345/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/345/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/345/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/345/console
This message is automatically generated.
> BloomMapFile can return false negatives
> ---------------------------------------
>
> Key: HADOOP-6546
> URL: https://issues.apache.org/jira/browse/HADOOP-6546
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1
> Reporter: Clark Jefcoat
> Attachments: HADOOP-6546.patch
>
>
> BloomMapFile can return false negatives when using keys of varying sizes. If the amount of data written by the write() method of your key class differs between instance of your key, your BloomMapFile may return false negatives.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6546) BloomMapFile can return false
negatives
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847648#action_12847648 ]
Hudson commented on HADOOP-6546:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #203 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/203/])
. BloomMapFile can return false negatives. Contributed by Clark Jefcoat.
> BloomMapFile can return false negatives
> ---------------------------------------
>
> Key: HADOOP-6546
> URL: https://issues.apache.org/jira/browse/HADOOP-6546
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1
> Reporter: Clark Jefcoat
> Assignee: Clark Jefcoat
> Fix For: 0.22.0
>
> Attachments: HADOOP-6546.patch
>
>
> BloomMapFile can return false negatives when using keys of varying sizes. If the amount of data written by the write() method of your key class differs between instance of your key, your BloomMapFile may return false negatives.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6546) BloomMapFile can return false
negatives
Posted by "Clark Jefcoat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Clark Jefcoat updated HADOOP-6546:
----------------------------------
Attachment: HADOOP-6546.patch
Simple tests to demonstrate the problem and a proposed solution are attached.
> BloomMapFile can return false negatives
> ---------------------------------------
>
> Key: HADOOP-6546
> URL: https://issues.apache.org/jira/browse/HADOOP-6546
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1
> Reporter: Clark Jefcoat
> Attachments: HADOOP-6546.patch
>
>
> BloomMapFile can return false negatives when using keys of varying sizes. If the amount of data written by the write() method of your key class differs between instance of your key, your BloomMapFile may return false negatives.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6546) BloomMapFile can return false
negatives
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-6546:
------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Assignee: Clark Jefcoat
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1 I've just committed this. Thanks Clark!
> BloomMapFile can return false negatives
> ---------------------------------------
>
> Key: HADOOP-6546
> URL: https://issues.apache.org/jira/browse/HADOOP-6546
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1
> Reporter: Clark Jefcoat
> Assignee: Clark Jefcoat
> Fix For: 0.22.0
>
> Attachments: HADOOP-6546.patch
>
>
> BloomMapFile can return false negatives when using keys of varying sizes. If the amount of data written by the write() method of your key class differs between instance of your key, your BloomMapFile may return false negatives.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.