You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/04/06 23:46:29 UTC
Review Request 45839: Fixed commit message hook to not lint the diff
in verbose mode.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45839/
-----------------------------------------------------------
Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.
Bugs: MESOS-5132
https://issues.apache.org/jira/browse/MESOS-5132
Repository: mesos
Description
-------
See summary.
Diffs
-----
support/hooks/commit-msg b32ee92da7ced33aea60ed4a02b2b98d3611fb9a
Diff: https://reviews.apache.org/r/45839/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 45839: Fixed commit message hook to not lint the
diff in verbose mode.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45839/
-----------------------------------------------------------
(Updated April 6, 2016, 11:08 p.m.)
Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.
Changes
-------
Added a comment as per Kevin's comment.
Bugs: MESOS-5132
https://issues.apache.org/jira/browse/MESOS-5132
Repository: mesos
Description (updated)
-------
Fixed commit message hook to not lint the diff in verbose mode.
Diffs (updated)
-----
support/hooks/commit-msg b32ee92da7ced33aea60ed4a02b2b98d3611fb9a
Diff: https://reviews.apache.org/r/45839/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 45839: Fixed commit message hook to not lint the
diff in verbose mode.
Posted by Michael Park <mp...@apache.org>.
> On April 6, 2016, 10:21 p.m., Kevin Klues wrote:
> > Ship It!
>
> Kevin Klues wrote:
> My only comment would be to add a comment about what this line is doing. It's not obvious that this is the delimiter used in verbose mode.
Oh, good point! Thanks, will do.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45839/#review127476
-----------------------------------------------------------
On April 6, 2016, 9:46 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45839/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 9:46 p.m.)
>
>
> Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-5132
> https://issues.apache.org/jira/browse/MESOS-5132
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/hooks/commit-msg b32ee92da7ced33aea60ed4a02b2b98d3611fb9a
>
> Diff: https://reviews.apache.org/r/45839/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 45839: Fixed commit message hook to not lint the
diff in verbose mode.
Posted by Kevin Klues <kl...@gmail.com>.
> On April 6, 2016, 10:21 p.m., Kevin Klues wrote:
> > Ship It!
My only comment would be to add a comment about what this line is doing. It's not obvious that this is the delimiter used in verbose mode.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45839/#review127476
-----------------------------------------------------------
On April 6, 2016, 9:46 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45839/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 9:46 p.m.)
>
>
> Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-5132
> https://issues.apache.org/jira/browse/MESOS-5132
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/hooks/commit-msg b32ee92da7ced33aea60ed4a02b2b98d3611fb9a
>
> Diff: https://reviews.apache.org/r/45839/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 45839: Fixed commit message hook to not lint the
diff in verbose mode.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45839/#review127476
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On April 6, 2016, 9:46 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45839/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 9:46 p.m.)
>
>
> Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-5132
> https://issues.apache.org/jira/browse/MESOS-5132
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/hooks/commit-msg b32ee92da7ced33aea60ed4a02b2b98d3611fb9a
>
> Diff: https://reviews.apache.org/r/45839/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>