[GitHub] [felix-atomos] fipro78 commented on a diff in pull request #70: add handling for running build on Windows

["fipro78 (via GitHub)" <gi...@apache.org>]

fipro78 commented on code in PR #70:
URL: https://github.com/apache/felix-atomos/pull/70#discussion_r1145899360


##########
atomos.utils/atomos.utils.substrate.impl/src/main/java/org/apache/felix/atomos/utils/substrate/impl/NativeImageArgumentsImpl.java:
##########
@@ -121,7 +121,7 @@ public List<String> arguments()
             .map(Path::toAbsolutePath)//
             .sorted(NativeImageArgumentsImpl::byAbsolutePath)//
             .map(Path::toString)//
-            .collect(Collectors.joining(":"));
+            .collect(Collectors.joining(NativeImageCliUtil.isWindows() ? ";" : ":"));

Review Comment:
   It is not only the path separator that is different between windows and unix. It is also the separator in the classpath or modulepath that is a semicolon on windows but a colon on unix. That is a different place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org