You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/30 05:52:50 UTC

[GitHub] [flink] Myasuka opened a new pull request #19276: [FLINK-26882][tests] Fix unstable RescaleCheckpointManuallyITCase

Myasuka opened a new pull request #19276:
URL: https://github.com/apache/flink/pull/19276


   ## What is the purpose of the change
   
   Fix unstable `RescaleCheckpointManuallyITCase` via ensuring contents of state within SubtaskIndexFlatMapper are all included in the last checkpoint.
   
   ## Brief change log
   
   Fix unstable `RescaleCheckpointManuallyITCase`.
   
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka merged pull request #19276: [FLINK-26882][tests] Fix unstable RescaleCheckpointManuallyITCase

Posted by GitBox <gi...@apache.org>.
Myasuka merged pull request #19276:
URL: https://github.com/apache/flink/pull/19276


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19276: [FLINK-26882][tests] Fix unstable RescaleCheckpointManuallyITCase

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19276:
URL: https://github.com/apache/flink/pull/19276#issuecomment-1082652854


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f36dddbeccdeed5a0d55656f5c8db27afd750952",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33936",
       "triggerID" : "f36dddbeccdeed5a0d55656f5c8db27afd750952",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f36dddbeccdeed5a0d55656f5c8db27afd750952 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33936) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19276: [FLINK-26882][tests] Fix unstable RescaleCheckpointManuallyITCase

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19276:
URL: https://github.com/apache/flink/pull/19276#issuecomment-1082652854


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f36dddbeccdeed5a0d55656f5c8db27afd750952",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33936",
       "triggerID" : "f36dddbeccdeed5a0d55656f5c8db27afd750952",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f36dddbeccdeed5a0d55656f5c8db27afd750952 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33936) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19276: [FLINK-26882][tests] Fix unstable RescaleCheckpointManuallyITCase

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19276:
URL: https://github.com/apache/flink/pull/19276#issuecomment-1082652854


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f36dddbeccdeed5a0d55656f5c8db27afd750952",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f36dddbeccdeed5a0d55656f5c8db27afd750952",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f36dddbeccdeed5a0d55656f5c8db27afd750952 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka commented on pull request #19276: [FLINK-26882][tests] Fix unstable RescaleCheckpointManuallyITCase

Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #19276:
URL: https://github.com/apache/flink/pull/19276#issuecomment-1082760461


   @akalash Thanks for your review!
   
   Since the jobgraph is `source->flatMap->sink`, and we get the result from the `sink` for verify, which means all keyed state in `flatMap` already seen and stored the records. Thus, no real data should exist in the channel between `source` to  `flatMap`, and it should be safe even for unaligned checkpoint here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka commented on pull request #19276: [FLINK-26882][tests] Fix unstable RescaleCheckpointManuallyITCase

Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #19276:
URL: https://github.com/apache/flink/pull/19276#issuecomment-1082791524


   My local CI https://dev.azure.com/myasuka/flink/_build/results?buildId=415&view=results has turned green. I think we can merge it now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org