You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by Rafael Schloming <rh...@alum.mit.edu> on 2012/10/23 20:41:24 UTC
initial release candidate
Hi Everyone,
I've posted an initial release candidate here:
http://people.apache.org/~rhs/qpid-proton-0.1/
Please keep in mind there hasn't been a wide variety of install testing so
go ahead and try on as many different OS distro/versions as you can find
and let me know if/when things break.
--Rafael
Re: initial release candidate
Posted by Rafael Schloming <rh...@alum.mit.edu>.
On Wed, Oct 24, 2012 at 8:20 AM, Rob Godfrey <ro...@gmail.com>wrote:
> The proton-j package doesn't seem to have a README or a LICENSE file
> included. The maven build can't run the tests as the directory
> structure doesn't include all the necessary files (nor does it have
> the same structure as the svn).
>
Which files are missing?
> As an aside, the checkin for PROTON-85 caused failure of the tests
> when run against proton-j. This was due to Jython not converting
> Python UUIDs to Java UUIDs. I've now checked in a change to the shim
> which handles this conversion (inelegantly) and the tests now pass.
>
This got picked up in RC2.
--Rafael
Re: initial release candidate
Posted by Rob Godfrey <ro...@gmail.com>.
The proton-j package doesn't seem to have a README or a LICENSE file
included. The maven build can't run the tests as the directory
structure doesn't include all the necessary files (nor does it have
the same structure as the svn).
As an aside, the checkin for PROTON-85 caused failure of the tests
when run against proton-j. This was due to Jython not converting
Python UUIDs to Java UUIDs. I've now checked in a change to the shim
which handles this conversion (inelegantly) and the tests now pass.
-- Rob
On 23 October 2012 20:41, Rafael Schloming <rh...@alum.mit.edu> wrote:
> Hi Everyone,
>
> I've posted an initial release candidate here:
>
> http://people.apache.org/~rhs/qpid-proton-0.1/
>
> Please keep in mind there hasn't been a wide variety of install testing so
> go ahead and try on as many different OS distro/versions as you can find
> and let me know if/when things break.
>
> --Rafael
Re: initial release candidate
Posted by Andrew Stitcher <as...@redhat.com>.
On Wed, 2012-10-24 at 08:01 -0400, Rafael Schloming wrote:
> On Tue, Oct 23, 2012 at 4:00 PM, Andrew Stitcher <as...@redhat.com>wrote:
>
> > On Tue, 2012-10-23 at 14:41 -0400, Rafael Schloming wrote:
> > > Hi Everyone,
> > >
> > > I've posted an initial release candidate here:
> > >
> > > http://people.apache.org/~rhs/qpid-proton-0.1/
> > >
> > > Please keep in mind there hasn't been a wide variety of install testing
> > so
> > > go ahead and try on as many different OS distro/versions as you can find
> > > and let me know if/when things break.
> > >
> > > --Rafael
> >
> > Quick attempt to build on FreeBSD 9.0 results in the following errors:
> >
>
> Did you forget to paste the errors?
Oops, pasted:
[Note that libuuid *is* installed - it's just in /usr/local a place that
apparently doesn't get searched by default]
Andrew
Re: initial release candidate
Posted by Rafael Schloming <rh...@alum.mit.edu>.
On Tue, Oct 23, 2012 at 4:00 PM, Andrew Stitcher <as...@redhat.com>wrote:
> On Tue, 2012-10-23 at 14:41 -0400, Rafael Schloming wrote:
> > Hi Everyone,
> >
> > I've posted an initial release candidate here:
> >
> > http://people.apache.org/~rhs/qpid-proton-0.1/
> >
> > Please keep in mind there hasn't been a wide variety of install testing
> so
> > go ahead and try on as many different OS distro/versions as you can find
> > and let me know if/when things break.
> >
> > --Rafael
>
> Quick attempt to build on FreeBSD 9.0 results in the following errors:
>
Did you forget to paste the errors?
--Rafael
Re: initial release candidate
Posted by Andrew Stitcher <as...@redhat.com>.
On Tue, 2012-10-23 at 14:41 -0400, Rafael Schloming wrote:
> Hi Everyone,
>
> I've posted an initial release candidate here:
>
> http://people.apache.org/~rhs/qpid-proton-0.1/
>
> Please keep in mind there hasn't been a wide variety of install testing so
> go ahead and try on as many different OS distro/versions as you can find
> and let me know if/when things break.
>
> --Rafael
Quick attempt to build on FreeBSD 9.0 results in the following errors:
Re: initial release candidate
Posted by rhs <rs...@gmail.com>.
I'll add a note to the readme.
On Oct 23, 2012 4:11 PM, "William Henry" <wh...@redhat.com> wrote:
> Nope. That makes sense. I just followed the instructions.
>
> William
>
> ----- Original Message -----
> > Were you running make install as root?
> >
> > --Rafael
> >
> > On Tue, Oct 23, 2012 at 3:31 PM, William Henry <wh...@redhat.com>
> > wrote:
> >
> > > My Make failed: did as instucted all docs install:
> > >
> > > [100%] Built target _cproton
> > > Scanning dependencies of target docs-py
> > > Warning: 1 markup error was found while processing docstrings. Use
> > > the
> > > verbose switch (-v) to display markup
> > > errors.
> > > Built target docs-py
> > > Scanning dependencies of target docs
> > > Built target docs
> > > Install the project...
> > > -- Install configuration: ""
> > > -- Installing: /usr/local/bin/proton
> > > CMake Error at cmake_install.cmake:42 (FILE):
> > > file INSTALL cannot copy file
> > > "/home/whenry/os/proton-c-0.1/build/proton"
> > > to "/usr/local/bin/proton".
> > >
> > >
> > > make: *** [install] Error 1
> > >
> > >
> > > Also I logged a Jira on the examples/README,txt
> > >
> > > Also I don't see a config.sh file anymore to get the python
> > > examples to
> > > work. ?? No instuctions.
> > >
> > > William
> > >
> > > ----- Original Message -----
> > > > On Tue, Oct 23, 2012 at 3:17 PM, Rafael Schloming
> > > > <rh...@alum.mit.edu>
> > > > wrote:
> > > >
> > > > > The doc issue should be fixed on trunk. I'll see if anymore
> > > > > problems come
> > > > > up.
> > > > >
> > > >
> > > > Oops, hit send too soon... I'll see if anymore problems come up
> > > > before
> > > > generating more tarballs.
> > > >
> > > > --Rafael
> > > >
> > > >
> > > > >
> > > > > --Rafael
> > > > >
> > > > >
> > > > > On Tue, Oct 23, 2012 at 3:01 PM, Ted Ross <tr...@redhat.com>
> > > > > wrote:
> > > > >
> > > > >> On 10/23/2012 02:41 PM, Rafael Schloming wrote:
> > > > >>
> > > > >>> Hi Everyone,
> > > > >>>
> > > > >>> I've posted an initial release candidate here:
> > > > >>>
> > > > >>> http://people.apache.org/~rhs/**qpid-proton-0.1/<
> > > http://people.apache.org/~rhs/qpid-proton-0.1/>
> > > > >>>
> > > > >>> Please keep in mind there hasn't been a wide variety of
> > > > >>> install
> > > > >>> testing
> > > > >>> so
> > > > >>> go ahead and try on as many different OS distro/versions as
> > > > >>> you
> > > > >>> can find
> > > > >>> and let me know if/when things break.
> > > > >>>
> > > > >>> --Rafael
> > > > >>>
> > > > >>> Excellent!
> > > > >>
> > > > >> I successfully installed it on Fedora 17. I'll try another
> > > > >> distro
> > > > >> later.
> > > > >>
> > > > >> When I built without the docs, "make install" failed. With
> > > > >> the
> > > > >> docs,
> > > > >> everything works.
> > > > >>
> > > > >> -Ted
> > > > >>
> > > > >>
> > > > >
> > > >
> > >
> >
>
Re: initial release candidate
Posted by William Henry <wh...@redhat.com>.
Nope. That makes sense. I just followed the instructions.
William
----- Original Message -----
> Were you running make install as root?
>
> --Rafael
>
> On Tue, Oct 23, 2012 at 3:31 PM, William Henry <wh...@redhat.com>
> wrote:
>
> > My Make failed: did as instucted all docs install:
> >
> > [100%] Built target _cproton
> > Scanning dependencies of target docs-py
> > Warning: 1 markup error was found while processing docstrings. Use
> > the
> > verbose switch (-v) to display markup
> > errors.
> > Built target docs-py
> > Scanning dependencies of target docs
> > Built target docs
> > Install the project...
> > -- Install configuration: ""
> > -- Installing: /usr/local/bin/proton
> > CMake Error at cmake_install.cmake:42 (FILE):
> > file INSTALL cannot copy file
> > "/home/whenry/os/proton-c-0.1/build/proton"
> > to "/usr/local/bin/proton".
> >
> >
> > make: *** [install] Error 1
> >
> >
> > Also I logged a Jira on the examples/README,txt
> >
> > Also I don't see a config.sh file anymore to get the python
> > examples to
> > work. ?? No instuctions.
> >
> > William
> >
> > ----- Original Message -----
> > > On Tue, Oct 23, 2012 at 3:17 PM, Rafael Schloming
> > > <rh...@alum.mit.edu>
> > > wrote:
> > >
> > > > The doc issue should be fixed on trunk. I'll see if anymore
> > > > problems come
> > > > up.
> > > >
> > >
> > > Oops, hit send too soon... I'll see if anymore problems come up
> > > before
> > > generating more tarballs.
> > >
> > > --Rafael
> > >
> > >
> > > >
> > > > --Rafael
> > > >
> > > >
> > > > On Tue, Oct 23, 2012 at 3:01 PM, Ted Ross <tr...@redhat.com>
> > > > wrote:
> > > >
> > > >> On 10/23/2012 02:41 PM, Rafael Schloming wrote:
> > > >>
> > > >>> Hi Everyone,
> > > >>>
> > > >>> I've posted an initial release candidate here:
> > > >>>
> > > >>> http://people.apache.org/~rhs/**qpid-proton-0.1/<
> > http://people.apache.org/~rhs/qpid-proton-0.1/>
> > > >>>
> > > >>> Please keep in mind there hasn't been a wide variety of
> > > >>> install
> > > >>> testing
> > > >>> so
> > > >>> go ahead and try on as many different OS distro/versions as
> > > >>> you
> > > >>> can find
> > > >>> and let me know if/when things break.
> > > >>>
> > > >>> --Rafael
> > > >>>
> > > >>> Excellent!
> > > >>
> > > >> I successfully installed it on Fedora 17. I'll try another
> > > >> distro
> > > >> later.
> > > >>
> > > >> When I built without the docs, "make install" failed. With
> > > >> the
> > > >> docs,
> > > >> everything works.
> > > >>
> > > >> -Ted
> > > >>
> > > >>
> > > >
> > >
> >
>
Re: initial release candidate
Posted by Rafael Schloming <rh...@alum.mit.edu>.
Were you running make install as root?
--Rafael
On Tue, Oct 23, 2012 at 3:31 PM, William Henry <wh...@redhat.com> wrote:
> My Make failed: did as instucted all docs install:
>
> [100%] Built target _cproton
> Scanning dependencies of target docs-py
> Warning: 1 markup error was found while processing docstrings. Use the
> verbose switch (-v) to display markup
> errors.
> Built target docs-py
> Scanning dependencies of target docs
> Built target docs
> Install the project...
> -- Install configuration: ""
> -- Installing: /usr/local/bin/proton
> CMake Error at cmake_install.cmake:42 (FILE):
> file INSTALL cannot copy file "/home/whenry/os/proton-c-0.1/build/proton"
> to "/usr/local/bin/proton".
>
>
> make: *** [install] Error 1
>
>
> Also I logged a Jira on the examples/README,txt
>
> Also I don't see a config.sh file anymore to get the python examples to
> work. ?? No instuctions.
>
> William
>
> ----- Original Message -----
> > On Tue, Oct 23, 2012 at 3:17 PM, Rafael Schloming <rh...@alum.mit.edu>
> > wrote:
> >
> > > The doc issue should be fixed on trunk. I'll see if anymore
> > > problems come
> > > up.
> > >
> >
> > Oops, hit send too soon... I'll see if anymore problems come up
> > before
> > generating more tarballs.
> >
> > --Rafael
> >
> >
> > >
> > > --Rafael
> > >
> > >
> > > On Tue, Oct 23, 2012 at 3:01 PM, Ted Ross <tr...@redhat.com> wrote:
> > >
> > >> On 10/23/2012 02:41 PM, Rafael Schloming wrote:
> > >>
> > >>> Hi Everyone,
> > >>>
> > >>> I've posted an initial release candidate here:
> > >>>
> > >>> http://people.apache.org/~rhs/**qpid-proton-0.1/<
> http://people.apache.org/~rhs/qpid-proton-0.1/>
> > >>>
> > >>> Please keep in mind there hasn't been a wide variety of install
> > >>> testing
> > >>> so
> > >>> go ahead and try on as many different OS distro/versions as you
> > >>> can find
> > >>> and let me know if/when things break.
> > >>>
> > >>> --Rafael
> > >>>
> > >>> Excellent!
> > >>
> > >> I successfully installed it on Fedora 17. I'll try another distro
> > >> later.
> > >>
> > >> When I built without the docs, "make install" failed. With the
> > >> docs,
> > >> everything works.
> > >>
> > >> -Ted
> > >>
> > >>
> > >
> >
>
Re: initial release candidate
Posted by William Henry <wh...@redhat.com>.
My Make failed: did as instucted all docs install:
[100%] Built target _cproton
Scanning dependencies of target docs-py
Warning: 1 markup error was found while processing docstrings. Use the verbose switch (-v) to display markup
errors.
Built target docs-py
Scanning dependencies of target docs
Built target docs
Install the project...
-- Install configuration: ""
-- Installing: /usr/local/bin/proton
CMake Error at cmake_install.cmake:42 (FILE):
file INSTALL cannot copy file "/home/whenry/os/proton-c-0.1/build/proton"
to "/usr/local/bin/proton".
make: *** [install] Error 1
Also I logged a Jira on the examples/README,txt
Also I don't see a config.sh file anymore to get the python examples to work. ?? No instuctions.
William
----- Original Message -----
> On Tue, Oct 23, 2012 at 3:17 PM, Rafael Schloming <rh...@alum.mit.edu>
> wrote:
>
> > The doc issue should be fixed on trunk. I'll see if anymore
> > problems come
> > up.
> >
>
> Oops, hit send too soon... I'll see if anymore problems come up
> before
> generating more tarballs.
>
> --Rafael
>
>
> >
> > --Rafael
> >
> >
> > On Tue, Oct 23, 2012 at 3:01 PM, Ted Ross <tr...@redhat.com> wrote:
> >
> >> On 10/23/2012 02:41 PM, Rafael Schloming wrote:
> >>
> >>> Hi Everyone,
> >>>
> >>> I've posted an initial release candidate here:
> >>>
> >>> http://people.apache.org/~rhs/**qpid-proton-0.1/<http://people.apache.org/~rhs/qpid-proton-0.1/>
> >>>
> >>> Please keep in mind there hasn't been a wide variety of install
> >>> testing
> >>> so
> >>> go ahead and try on as many different OS distro/versions as you
> >>> can find
> >>> and let me know if/when things break.
> >>>
> >>> --Rafael
> >>>
> >>> Excellent!
> >>
> >> I successfully installed it on Fedora 17. I'll try another distro
> >> later.
> >>
> >> When I built without the docs, "make install" failed. With the
> >> docs,
> >> everything works.
> >>
> >> -Ted
> >>
> >>
> >
>
Re: initial release candidate
Posted by Rafael Schloming <rh...@alum.mit.edu>.
On Tue, Oct 23, 2012 at 3:17 PM, Rafael Schloming <rh...@alum.mit.edu> wrote:
> The doc issue should be fixed on trunk. I'll see if anymore problems come
> up.
>
Oops, hit send too soon... I'll see if anymore problems come up before
generating more tarballs.
--Rafael
>
> --Rafael
>
>
> On Tue, Oct 23, 2012 at 3:01 PM, Ted Ross <tr...@redhat.com> wrote:
>
>> On 10/23/2012 02:41 PM, Rafael Schloming wrote:
>>
>>> Hi Everyone,
>>>
>>> I've posted an initial release candidate here:
>>>
>>> http://people.apache.org/~rhs/**qpid-proton-0.1/<http://people.apache.org/~rhs/qpid-proton-0.1/>
>>>
>>> Please keep in mind there hasn't been a wide variety of install testing
>>> so
>>> go ahead and try on as many different OS distro/versions as you can find
>>> and let me know if/when things break.
>>>
>>> --Rafael
>>>
>>> Excellent!
>>
>> I successfully installed it on Fedora 17. I'll try another distro later.
>>
>> When I built without the docs, "make install" failed. With the docs,
>> everything works.
>>
>> -Ted
>>
>>
>
Re: initial release candidate
Posted by Rafael Schloming <rh...@alum.mit.edu>.
The doc issue should be fixed on trunk. I'll see if anymore problems come
up.
--Rafael
On Tue, Oct 23, 2012 at 3:01 PM, Ted Ross <tr...@redhat.com> wrote:
> On 10/23/2012 02:41 PM, Rafael Schloming wrote:
>
>> Hi Everyone,
>>
>> I've posted an initial release candidate here:
>>
>> http://people.apache.org/~rhs/**qpid-proton-0.1/<http://people.apache.org/~rhs/qpid-proton-0.1/>
>>
>> Please keep in mind there hasn't been a wide variety of install testing so
>> go ahead and try on as many different OS distro/versions as you can find
>> and let me know if/when things break.
>>
>> --Rafael
>>
>> Excellent!
>
> I successfully installed it on Fedora 17. I'll try another distro later.
>
> When I built without the docs, "make install" failed. With the docs,
> everything works.
>
> -Ted
>
>
Re: initial release candidate
Posted by Ted Ross <tr...@redhat.com>.
On 10/23/2012 02:41 PM, Rafael Schloming wrote:
> Hi Everyone,
>
> I've posted an initial release candidate here:
>
> http://people.apache.org/~rhs/qpid-proton-0.1/
>
> Please keep in mind there hasn't been a wide variety of install testing so
> go ahead and try on as many different OS distro/versions as you can find
> and let me know if/when things break.
>
> --Rafael
>
Excellent!
I successfully installed it on Fedora 17. I'll try another distro later.
When I built without the docs, "make install" failed. With the docs,
everything works.
-Ted
Re: initial release candidate
Posted by Rafael Schloming <rh...@alum.mit.edu>.
Doh, missed that one in the noise. I'll roll that into the next one.
--Rafael
On Tue, Oct 23, 2012 at 3:28 PM, Hiram Chirino <hi...@hiramchirino.com>wrote:
> -1
>
> The java distro does not have the pom versions updated. See my comments on
> https://issues.apache.org/jira/browse/PROTON-47
>
> On Tue, Oct 23, 2012 at 2:41 PM, Rafael Schloming <rh...@alum.mit.edu>
> wrote:
>
> > Hi Everyone,
> >
> > I've posted an initial release candidate here:
> >
> > http://people.apache.org/~rhs/qpid-proton-0.1/
> >
> > Please keep in mind there hasn't been a wide variety of install testing
> so
> > go ahead and try on as many different OS distro/versions as you can find
> > and let me know if/when things break.
> >
> > --Rafael
> >
>
>
>
> --
>
> **
>
> *Hiram Chirino*
>
> *Engineering | Red Hat, Inc.*
>
> *hchirino@redhat.com <hc...@redhat.com> | fusesource.com | redhat.com*
>
> *skype: hiramchirino | twitter: @hiramchirino<
> http://twitter.com/hiramchirino>
> *
>
> *blog: Hiram Chirino's Bit Mojo <http://hiramchirino.com/blog/>*
>
Re: initial release candidate
Posted by Hiram Chirino <hi...@hiramchirino.com>.
-1
The java distro does not have the pom versions updated. See my comments on
https://issues.apache.org/jira/browse/PROTON-47
On Tue, Oct 23, 2012 at 2:41 PM, Rafael Schloming <rh...@alum.mit.edu> wrote:
> Hi Everyone,
>
> I've posted an initial release candidate here:
>
> http://people.apache.org/~rhs/qpid-proton-0.1/
>
> Please keep in mind there hasn't been a wide variety of install testing so
> go ahead and try on as many different OS distro/versions as you can find
> and let me know if/when things break.
>
> --Rafael
>
--
**
*Hiram Chirino*
*Engineering | Red Hat, Inc.*
*hchirino@redhat.com <hc...@redhat.com> | fusesource.com | redhat.com*
*skype: hiramchirino | twitter: @hiramchirino<http://twitter.com/hiramchirino>
*
*blog: Hiram Chirino's Bit Mojo <http://hiramchirino.com/blog/>*
Re: initial release candidate
Posted by "Darryl L. Pierce" <dp...@redhat.com>.
On Tue, Oct 23, 2012 at 03:54:30PM -0400, Rafael Schloming wrote:
> > What I'd like to see would be to have qpid-proton and qpid-proton-java
> > as the two source tarballs if possible. That way I can keep the RPM
> > named qpid-proton (I would rather not put -c into the name).
>
> I'm not so sure about this one. I think at some point we might want
> qpid-proton for something else, e.g. an independently distributed python
> interface definition and test suite. Why does the source tarball force a
> particular RPM name?
I was misremembering one of the review guidelines regarding package
naming. You can disregard that part of my request.
Regarding a separate package as you describe, in Fedora it would be
named python-qpid-proton (or similar) since it would be a Python
language package so wouldn't cause a problem for what we're doing today.
--
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
Re: initial release candidate
Posted by Rafael Schloming <rh...@alum.mit.edu>.
On Tue, Oct 23, 2012 at 3:37 PM, Darryl L. Pierce <dp...@redhat.com>wrote:
> On Tue, Oct 23, 2012 at 02:41:24PM -0400, Rafael Schloming wrote:
> > Hi Everyone,
> >
> > I've posted an initial release candidate here:
> >
> > http://people.apache.org/~rhs/qpid-proton-0.1/
> >
> > Please keep in mind there hasn't been a wide variety of install testing
> so
> > go ahead and try on as many different OS distro/versions as you can find
> > and let me know if/when things break.
>
> Well done. I do have a request on the release tarball, though. Can we
> fix the filenames and internal directories? The qpid-proton-c-$VERSION file
> contains proton-c-$VERSION as the root directory, which makes the
> specfile choke.
>
I'll update the internal directories to match.
>
> What I'd like to see would be to have qpid-proton and qpid-proton-java
> as the two source tarballs if possible. That way I can keep the RPM
> named qpid-proton (I would rather not put -c into the name).
>
I'm not so sure about this one. I think at some point we might want
qpid-proton for something else, e.g. an independently distributed python
interface definition and test suite. Why does the source tarball force a
particular RPM name?
--Rafael
Re: initial release candidate
Posted by "Darryl L. Pierce" <dp...@redhat.com>.
On Tue, Oct 23, 2012 at 02:41:24PM -0400, Rafael Schloming wrote:
> Hi Everyone,
>
> I've posted an initial release candidate here:
>
> http://people.apache.org/~rhs/qpid-proton-0.1/
>
> Please keep in mind there hasn't been a wide variety of install testing so
> go ahead and try on as many different OS distro/versions as you can find
> and let me know if/when things break.
Well done. I do have a request on the release tarball, though. Can we
fix the filenames and internal directories? The qpid-proton-c-$VERSION file
contains proton-c-$VERSION as the root directory, which makes the
specfile choke.
What I'd like to see would be to have qpid-proton and qpid-proton-java
as the two source tarballs if possible. That way I can keep the RPM
named qpid-proton (I would rather not put -c into the name).
--
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
Re: initial release candidate
Posted by Rafael Schloming <rh...@alum.mit.edu>.
On Thu, Oct 25, 2012 at 8:18 AM, Ken Giusti <kg...@redhat.com> wrote:
> The following patch fixes the problem with older versions of the SSL
> library.
>
> It also works on the latest Fedora 17, so I think it's low risk.
>
> Shall I commit it?
>
Sure
--Rafael
Re: initial release candidate
Posted by Ken Giusti <kg...@redhat.com>.
The following patch fixes the problem with older versions of the SSL library.
It also works on the latest Fedora 17, so I think it's low risk.
Shall I commit it?
----8<----
diff --git a/proton-c/src/ssl/openssl.c b/proton-c/src/ssl/openssl.c
index 6ea951f..dd775cd 100644
--- a/proton-c/src/ssl/openssl.c
+++ b/proton-c/src/ssl/openssl.c
@@ -296,6 +296,14 @@ int pn_ssl_set_credentials( pn_ssl_t *ssl,
ssl->has_certificate = true;
+ // bug in older versions of OpenSSL: servers may request client cert even if anonymous
+ // cipher was negotiated. TLSv1 will reject such a request. Hack: once a cert is
+ // configured, allow only authenticated ciphers.
+ if (!SSL_CTX_set_cipher_list( ssl->ctx, CIPHERS_AUTHENTICATE )) {
+ _log_ssl_error(ssl, "Failed to set cipher list to %s\n", CIPHERS_AUTHENTICATE);
+ return -6;
+ }
+
_log( ssl, "Configured local certificate file %s\n", certificate_file );
return 0;
}
@@ -543,6 +551,7 @@ pn_ssl_t *pn_ssl(pn_transport_t *transport)
ssl_initialized = 1;
SSL_library_init();
SSL_load_error_strings();
+ OpenSSL_add_all_algorithms();
}
pn_ssl_t *ssl = calloc(1, sizeof(pn_ssl_t));
---->8----
----- Original Message -----
> Interesting - that test uses a certificate I created and checked into
> the repo. I generated the certificate using a newer toolset.
>
> I'll have a look at it...
>
>
> -K
>
> ----- Original Message -----
> > My (64-bit) Ubuntu 12.04 works fine...
> >
> > On Ubuntu 10.04 I'm seeing SSL errors... presumably these are
> > related
> > to the age of the ssl library and the algorithms it supports...
> >
> > proton_tests.ssl.SslTest.test_client_authentication
> > .............................................................................................................................SSL_CTX_use_PrivateKey_file(
> > /home/rob/qpid-proton-c-0.1/tests/proton_tests/ssl_db/server-private-key.pem
> > ) failed
> > error:06074079:digital envelope routines:EVP_PBE_CipherInit:unknown
> > pbe algorithm
> > error:23077073:PKCS12 routines:PKCS12_pbe_crypt:pkcs12 algor
> > cipherinit error
> > error:2306A075:PKCS12 routines:PKCS12_item_decrypt_d2i:pkcs12 pbe
> > crypt error
> > error:0907B00D:PEM routines:PEM_READ_BIO_PRIVATEKEY:ASN1 lib
> > error:140B0009:SSL routines:SSL_CTX_use_PrivateKey_file:PEM lib
> > fail
> > Error during test: Traceback (most recent call last):
> > File "./proton-test", line 331, in run
> > phase()
> > File "/home/rob/qpid-proton-c-0.1/tests/proton_tests/ssl.py",
> > line
> > 130, in test_client_authentication
> > "server-password")
> > File "/home/rob/qpid-proton-c-0.1/bindings/python/proton.py",
> > line
> > 2111, in set_credentials
> > password) )
> > File "/home/rob/qpid-proton-c-0.1/bindings/python/proton.py",
> > line
> > 2096, in _check
> > raise exc("SSL failure.")
> > SSLException: SSL failure.
> >
> > -- Rob
> >
> > On 24 October 2012 18:05, Ken Giusti <kg...@redhat.com> wrote:
> > > Ubuntu 12.04-1 LTS, fully patched and up to date:
> > >
> > > 1) had to install the following packages - similar to the README,
> > > but ubuntu specific:
> > >
> > > sudo apt-get install cmake swig libssl-dev python-dev ruby
> > > ruby-dev
> > > python-epydoc uuid-dev
> > >
> > > [note: cmake is version 2.8.7, so I didn't get that OPTIONAL
> > > issue]
> > >
> > > 2) make and install went well!
> > >
> > > 3) example/send.py and recv.py worked - need to try with SSL
> > > next..
> > >
> > > 4) am seeing a failure in the python-tests:
> > >
> > > proton_tests.codec.DataTest.testDecimal128
> > > ............................................................................................................
> > > pass
> > > proton_tests.codec.DataTest.testDecimal32
> > > .............................................................................................................
> > > pass
> > > proton_tests.codec.DataTest.testDecimal64
> > > .............................................................................................................
> > > fail
> > > Error during test: Traceback (most recent call last):
> > > File "./proton-test", line 331, in run
> > > phase()
> > > File
> > > "/home/kgiusti/proton-rc/qpid-proton-c-0.1/tests/proton_tests/codec.py",
> > > line 246, in testDecimal64
> > > self._test("decimal64", 0, 1, 2, 3, 4, 2**60)
> > > File
> > > "/home/kgiusti/proton-rc/qpid-proton-c-0.1/tests/proton_tests/codec.py",
> > > line 183, in _test
> > > putter(v)
> > > File
> > > "/home/kgiusti/proton-rc/install/lib/python2.7/dist-packages/proton.py",
> > > line 1134, in put_decimal64
> > > self._check(pn_data_put_decimal64(self._data, d))
> > > TypeError: in method 'pn_data_put_decimal64', argument 2 of
> > > type
> > > 'pn_decimal64_t'
> > > proton_tests.codec.DataTest.testDescribedEmptyArray
> > > ...................................................................................................
> > > pass
> > >
> > > This happens to be on a 32-bit VM - I'll look into it.
> > >
> > > -K
> > >
> > > ----- Original Message -----
> > >> Hi Everyone,
> > >>
> > >> I've posted an initial release candidate here:
> > >>
> > >> http://people.apache.org/~rhs/qpid-proton-0.1/
> > >>
> > >> Please keep in mind there hasn't been a wide variety of install
> > >> testing so
> > >> go ahead and try on as many different OS distro/versions as you
> > >> can
> > >> find
> > >> and let me know if/when things break.
> > >>
> > >> --Rafael
> > >>
> >
>
Re: initial release candidate
Posted by Ken Giusti <kg...@redhat.com>.
Interesting - that test uses a certificate I created and checked into the repo. I generated the certificate using a newer toolset.
I'll have a look at it...
-K
----- Original Message -----
> My (64-bit) Ubuntu 12.04 works fine...
>
> On Ubuntu 10.04 I'm seeing SSL errors... presumably these are related
> to the age of the ssl library and the algorithms it supports...
>
> proton_tests.ssl.SslTest.test_client_authentication
> .............................................................................................................................SSL_CTX_use_PrivateKey_file(
> /home/rob/qpid-proton-c-0.1/tests/proton_tests/ssl_db/server-private-key.pem
> ) failed
> error:06074079:digital envelope routines:EVP_PBE_CipherInit:unknown
> pbe algorithm
> error:23077073:PKCS12 routines:PKCS12_pbe_crypt:pkcs12 algor
> cipherinit error
> error:2306A075:PKCS12 routines:PKCS12_item_decrypt_d2i:pkcs12 pbe
> crypt error
> error:0907B00D:PEM routines:PEM_READ_BIO_PRIVATEKEY:ASN1 lib
> error:140B0009:SSL routines:SSL_CTX_use_PrivateKey_file:PEM lib
> fail
> Error during test: Traceback (most recent call last):
> File "./proton-test", line 331, in run
> phase()
> File "/home/rob/qpid-proton-c-0.1/tests/proton_tests/ssl.py",
> line
> 130, in test_client_authentication
> "server-password")
> File "/home/rob/qpid-proton-c-0.1/bindings/python/proton.py",
> line
> 2111, in set_credentials
> password) )
> File "/home/rob/qpid-proton-c-0.1/bindings/python/proton.py",
> line
> 2096, in _check
> raise exc("SSL failure.")
> SSLException: SSL failure.
>
> -- Rob
>
> On 24 October 2012 18:05, Ken Giusti <kg...@redhat.com> wrote:
> > Ubuntu 12.04-1 LTS, fully patched and up to date:
> >
> > 1) had to install the following packages - similar to the README,
> > but ubuntu specific:
> >
> > sudo apt-get install cmake swig libssl-dev python-dev ruby ruby-dev
> > python-epydoc uuid-dev
> >
> > [note: cmake is version 2.8.7, so I didn't get that OPTIONAL issue]
> >
> > 2) make and install went well!
> >
> > 3) example/send.py and recv.py worked - need to try with SSL next..
> >
> > 4) am seeing a failure in the python-tests:
> >
> > proton_tests.codec.DataTest.testDecimal128
> > ............................................................................................................
> > pass
> > proton_tests.codec.DataTest.testDecimal32
> > .............................................................................................................
> > pass
> > proton_tests.codec.DataTest.testDecimal64
> > .............................................................................................................
> > fail
> > Error during test: Traceback (most recent call last):
> > File "./proton-test", line 331, in run
> > phase()
> > File
> > "/home/kgiusti/proton-rc/qpid-proton-c-0.1/tests/proton_tests/codec.py",
> > line 246, in testDecimal64
> > self._test("decimal64", 0, 1, 2, 3, 4, 2**60)
> > File
> > "/home/kgiusti/proton-rc/qpid-proton-c-0.1/tests/proton_tests/codec.py",
> > line 183, in _test
> > putter(v)
> > File
> > "/home/kgiusti/proton-rc/install/lib/python2.7/dist-packages/proton.py",
> > line 1134, in put_decimal64
> > self._check(pn_data_put_decimal64(self._data, d))
> > TypeError: in method 'pn_data_put_decimal64', argument 2 of type
> > 'pn_decimal64_t'
> > proton_tests.codec.DataTest.testDescribedEmptyArray
> > ...................................................................................................
> > pass
> >
> > This happens to be on a 32-bit VM - I'll look into it.
> >
> > -K
> >
> > ----- Original Message -----
> >> Hi Everyone,
> >>
> >> I've posted an initial release candidate here:
> >>
> >> http://people.apache.org/~rhs/qpid-proton-0.1/
> >>
> >> Please keep in mind there hasn't been a wide variety of install
> >> testing so
> >> go ahead and try on as many different OS distro/versions as you
> >> can
> >> find
> >> and let me know if/when things break.
> >>
> >> --Rafael
> >>
>
Re: initial release candidate
Posted by Rob Godfrey <ro...@gmail.com>.
My (64-bit) Ubuntu 12.04 works fine...
On Ubuntu 10.04 I'm seeing SSL errors... presumably these are related
to the age of the ssl library and the algorithms it supports...
proton_tests.ssl.SslTest.test_client_authentication
.............................................................................................................................SSL_CTX_use_PrivateKey_file(
/home/rob/qpid-proton-c-0.1/tests/proton_tests/ssl_db/server-private-key.pem
) failed
error:06074079:digital envelope routines:EVP_PBE_CipherInit:unknown
pbe algorithm
error:23077073:PKCS12 routines:PKCS12_pbe_crypt:pkcs12 algor cipherinit error
error:2306A075:PKCS12 routines:PKCS12_item_decrypt_d2i:pkcs12 pbe crypt error
error:0907B00D:PEM routines:PEM_READ_BIO_PRIVATEKEY:ASN1 lib
error:140B0009:SSL routines:SSL_CTX_use_PrivateKey_file:PEM lib
fail
Error during test: Traceback (most recent call last):
File "./proton-test", line 331, in run
phase()
File "/home/rob/qpid-proton-c-0.1/tests/proton_tests/ssl.py", line
130, in test_client_authentication
"server-password")
File "/home/rob/qpid-proton-c-0.1/bindings/python/proton.py", line
2111, in set_credentials
password) )
File "/home/rob/qpid-proton-c-0.1/bindings/python/proton.py", line
2096, in _check
raise exc("SSL failure.")
SSLException: SSL failure.
-- Rob
On 24 October 2012 18:05, Ken Giusti <kg...@redhat.com> wrote:
> Ubuntu 12.04-1 LTS, fully patched and up to date:
>
> 1) had to install the following packages - similar to the README, but ubuntu specific:
>
> sudo apt-get install cmake swig libssl-dev python-dev ruby ruby-dev python-epydoc uuid-dev
>
> [note: cmake is version 2.8.7, so I didn't get that OPTIONAL issue]
>
> 2) make and install went well!
>
> 3) example/send.py and recv.py worked - need to try with SSL next..
>
> 4) am seeing a failure in the python-tests:
>
> proton_tests.codec.DataTest.testDecimal128 ............................................................................................................ pass
> proton_tests.codec.DataTest.testDecimal32 ............................................................................................................. pass
> proton_tests.codec.DataTest.testDecimal64 ............................................................................................................. fail
> Error during test: Traceback (most recent call last):
> File "./proton-test", line 331, in run
> phase()
> File "/home/kgiusti/proton-rc/qpid-proton-c-0.1/tests/proton_tests/codec.py", line 246, in testDecimal64
> self._test("decimal64", 0, 1, 2, 3, 4, 2**60)
> File "/home/kgiusti/proton-rc/qpid-proton-c-0.1/tests/proton_tests/codec.py", line 183, in _test
> putter(v)
> File "/home/kgiusti/proton-rc/install/lib/python2.7/dist-packages/proton.py", line 1134, in put_decimal64
> self._check(pn_data_put_decimal64(self._data, d))
> TypeError: in method 'pn_data_put_decimal64', argument 2 of type 'pn_decimal64_t'
> proton_tests.codec.DataTest.testDescribedEmptyArray ................................................................................................... pass
>
> This happens to be on a 32-bit VM - I'll look into it.
>
> -K
>
> ----- Original Message -----
>> Hi Everyone,
>>
>> I've posted an initial release candidate here:
>>
>> http://people.apache.org/~rhs/qpid-proton-0.1/
>>
>> Please keep in mind there hasn't been a wide variety of install
>> testing so
>> go ahead and try on as many different OS distro/versions as you can
>> find
>> and let me know if/when things break.
>>
>> --Rafael
>>
Re: initial release candidate
Posted by Ken Giusti <kg...@redhat.com>.
Ubuntu 12.04-1 LTS, fully patched and up to date:
1) had to install the following packages - similar to the README, but ubuntu specific:
sudo apt-get install cmake swig libssl-dev python-dev ruby ruby-dev python-epydoc uuid-dev
[note: cmake is version 2.8.7, so I didn't get that OPTIONAL issue]
2) make and install went well!
3) example/send.py and recv.py worked - need to try with SSL next..
4) am seeing a failure in the python-tests:
proton_tests.codec.DataTest.testDecimal128 ............................................................................................................ pass
proton_tests.codec.DataTest.testDecimal32 ............................................................................................................. pass
proton_tests.codec.DataTest.testDecimal64 ............................................................................................................. fail
Error during test: Traceback (most recent call last):
File "./proton-test", line 331, in run
phase()
File "/home/kgiusti/proton-rc/qpid-proton-c-0.1/tests/proton_tests/codec.py", line 246, in testDecimal64
self._test("decimal64", 0, 1, 2, 3, 4, 2**60)
File "/home/kgiusti/proton-rc/qpid-proton-c-0.1/tests/proton_tests/codec.py", line 183, in _test
putter(v)
File "/home/kgiusti/proton-rc/install/lib/python2.7/dist-packages/proton.py", line 1134, in put_decimal64
self._check(pn_data_put_decimal64(self._data, d))
TypeError: in method 'pn_data_put_decimal64', argument 2 of type 'pn_decimal64_t'
proton_tests.codec.DataTest.testDescribedEmptyArray ................................................................................................... pass
This happens to be on a 32-bit VM - I'll look into it.
-K
----- Original Message -----
> Hi Everyone,
>
> I've posted an initial release candidate here:
>
> http://people.apache.org/~rhs/qpid-proton-0.1/
>
> Please keep in mind there hasn't been a wide variety of install
> testing so
> go ahead and try on as many different OS distro/versions as you can
> find
> and let me know if/when things break.
>
> --Rafael
>
Re: initial release candidate
Posted by William Henry <wh...@redhat.com>.
Well done.
William
----- Original Message -----
> Hi Everyone,
>
> I've posted an initial release candidate here:
>
> http://people.apache.org/~rhs/qpid-proton-0.1/
>
> Please keep in mind there hasn't been a wide variety of install
> testing so
> go ahead and try on as many different OS distro/versions as you can
> find
> and let me know if/when things break.
>
> --Rafael
>