You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/04 02:16:13 UTC

[GitHub] [arrow] kou commented on a diff in pull request #13282: ARROW-16609: [C++] xxhash not installed into dist/lib/include when building C++

kou commented on code in PR #13282:
URL: https://github.com/apache/arrow/pull/13282#discussion_r889437852


##########
cpp/src/arrow/util/int_util.h:
##########
@@ -21,6 +21,7 @@
 #include <type_traits>
 
 #include "arrow/status.h"
+#include "arrow/util/int_util_overflow.h"

Review Comment:
   I don't know why we should not include `<intsafe.h>` in our public headers but we should not include it here.
   Only needed `python/**/*.cc` in #13311 should include it instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org