You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by we...@apache.org on 2016/02/24 22:24:41 UTC
reef git commit: [REEF-547] Remove deprecated registerErrorHandler
method in RemoteManager
Repository: reef
Updated Branches:
refs/heads/master 23f7386b3 -> b5386f77e
[REEF-547] Remove deprecated registerErrorHandler method in RemoteManager
This is the last of the deprecated APIs listed in JIRA.
JIRA:
[REEF-547](https://issues.apache.org/jira/browse/REEF-547)
Pull request:
This closes #855
Project: http://git-wip-us.apache.org/repos/asf/reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/b5386f77
Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/b5386f77
Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/b5386f77
Branch: refs/heads/master
Commit: b5386f77e8d9e695db48091010d68ba33fa57118
Parents: 23f7386
Author: Mariia Mykhailova <ma...@apache.org>
Authored: Tue Feb 23 14:43:20 2016 -0800
Committer: Markus Weimer <we...@apache.org>
Committed: Wed Feb 24 13:23:47 2016 -0800
----------------------------------------------------------------------
.../apache/reef/runtime/common/utils/RemoteManager.java | 9 ---------
.../java/org/apache/reef/wake/remote/RemoteManager.java | 12 ------------
.../remote/impl/DefaultRemoteManagerImplementation.java | 12 ------------
3 files changed, 33 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/reef/blob/b5386f77/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/RemoteManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/RemoteManager.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/RemoteManager.java
index 9da6bff..0eeff08 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/RemoteManager.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/RemoteManager.java
@@ -68,15 +68,6 @@ public class RemoteManager {
return this.raw.registerHandler(messageType, theHandler);
}
- // TODO[JIRA REEF-547]: This method uses deprecated raw.registerErrorHandler.
- /**
- * @deprecated in 0.14, will be deleted in 0.15
- */
- @Deprecated
- public AutoCloseable registerErrorHandler(final EventHandler<Exception> theHandler) {
- return this.raw.registerErrorHandler(theHandler);
- }
-
public String getMyIdentifier() {
return this.raw.getMyIdentifier().toString();
}
http://git-wip-us.apache.org/repos/asf/reef/blob/b5386f77/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java
index a84391d..17b9b13 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java
@@ -77,18 +77,6 @@ public interface RemoteManager extends Stage {
final EventHandler<RemoteMessage<T>> theHandler);
/**
- * Register an EventHandler that gets called by Wake in the presence of
- * errors. Note that user-level errors that need to cross the network need
- * to be handled as standard messages.
- *
- * @param theHandler the exception event handler
- * @return the subscription that can be used to unsubscribe later
- * @deprecated before 0.14, will be deleted in 0.15
- */
- @Deprecated
- AutoCloseable registerErrorHandler(final EventHandler<Exception> theHandler);
-
- /**
* Access the Identifier of this.
*
* @return the Identifier of this.
http://git-wip-us.apache.org/repos/asf/reef/blob/b5386f77/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerImplementation.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerImplementation.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerImplementation.java
index 3e972fe..d525c51 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerImplementation.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerImplementation.java
@@ -153,18 +153,6 @@ public final class DefaultRemoteManagerImplementation implements RemoteManager {
}
/**
- * Registers an exception handler and returns a subscription.
- */
- @Override
- public AutoCloseable registerErrorHandler(final EventHandler<Exception> theHandler) {
- if (LOG.isLoggable(Level.FINE)) {
- LOG.log(Level.FINE, "RemoteManager: {0} handler: {1}",
- new Object[]{this.name, theHandler.getClass().getName()});
- }
- return this.handlerContainer.registerErrorHandler(theHandler);
- }
-
- /**
* Returns my identifier.
*/
@Override