You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by an...@apache.org on 2016/01/28 09:57:09 UTC
[2/2] android commit: CB-10443 Pass original options instead of
remaining
CB-10443 Pass original options instead of remaining
Nopt parses all options regardless of what is passed as "knownOpts". This leaves the remain property an emtpy array.
This ultimately leads to a bug in the parseOpts function where the options undergo a second parsing from nopt.
The end result is - this options are not respected at all..
This closes #248
Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/7669378c
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/7669378c
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/7669378c
Branch: refs/heads/master
Commit: 7669378c6eca5ed4eef9e339caacc3c7efdcc43f
Parents: 1494082
Author: Dimitar Kerezov <di...@telerik.com>
Authored: Thu Jan 28 09:51:50 2016 +0200
Committer: Vladimir Kotikov <v-...@microsoft.com>
Committed: Thu Jan 28 11:55:29 2016 +0300
----------------------------------------------------------------------
bin/templates/cordova/build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-android/blob/7669378c/bin/templates/cordova/build
----------------------------------------------------------------------
diff --git a/bin/templates/cordova/build b/bin/templates/cordova/build
index da44783..de86a36 100755
--- a/bin/templates/cordova/build
+++ b/bin/templates/cordova/build
@@ -39,7 +39,7 @@ var buildOpts = nopt({
}, { 'd' : '--verbose' });
// Make buildOptions compatible with PlatformApi build method spec
-buildOpts.argv = buildOpts.argv.remain;
+buildOpts.argv = buildOpts.argv.original;
new Api().build(buildOpts)
.catch(function(err) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org