You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/04/06 20:43:54 UTC
[GitHub] [openwhisk] bdoyle0182 opened a new pull request #4874: add
activationId to event message
bdoyle0182 opened a new pull request #4874: add activationId to event message
URL: https://github.com/apache/openwhisk/pull/4874
## Description
This change adds the activationId to messages on the events topic of type `Activation`. This is useful for external services that listen in on the events topic that may want to make reference to the activations
it is consuming.
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [x] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [x] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [x] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on issue #4874: add activationId to
events message
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on issue #4874: add activationId to events message
URL: https://github.com/apache/openwhisk/pull/4874#issuecomment-612132669
Just to confirm the impact on backward compatability.
* Any existing code which is processing the user-events using older version of Message parsing code would work as is as it would just ignore activationId
* New code reading older events - Should not happen in general
Should we account for case where parser should be able to handle missing activationId i.e. mark it as `Option`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah merged pull request #4874: add activationId to
events message
Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #4874: add activationId to events message
URL: https://github.com/apache/openwhisk/pull/4874
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] bdoyle0182 commented on issue #4874: add activationId
to events message
Posted by GitBox <gi...@apache.org>.
bdoyle0182 commented on issue #4874: add activationId to events message
URL: https://github.com/apache/openwhisk/pull/4874#issuecomment-612135057
> Just to confirm the impact on backward compatability.
>
> * Any existing code which is processing the user-events using older version of Message parsing code would work as is as it would just ignore activationId
> * New code reading older events - Should not happen in general
>
> Should we account for case where parser should be able to handle missing activationId i.e. mark it as `Option`
Not sure if it needs to be an `Option` as any existing external service to openwhisk parsing the events topic just wouldn't look for activationId right? It would just ignore until it started looking for the field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] bdoyle0182 edited a comment on issue #4874: add
activationId to events message
Posted by GitBox <gi...@apache.org>.
bdoyle0182 edited a comment on issue #4874: add activationId to events message
URL: https://github.com/apache/openwhisk/pull/4874#issuecomment-612135057
> Just to confirm the impact on backward compatability.
>
> * Any existing code which is processing the user-events using older version of Message parsing code would work as is as it would just ignore activationId
> * New code reading older events - Should not happen in general
>
> Should we account for case where parser should be able to handle missing activationId i.e. mark it as `Option`
Not sure if it needs to be an `Option` as any existing external service to openwhisk parsing the events topic just wouldn't look for activationId right? It would just ignore until it started looking for the field.
And the client with the parser can just upgrade openwhisk, all messages will have the new field after a few minutes, then upgrade their parser to parse for activationId to if they want so don't think accounting for that last case is useful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] bdoyle0182 edited a comment on issue #4874: add
activationId to events message
Posted by GitBox <gi...@apache.org>.
bdoyle0182 edited a comment on issue #4874: add activationId to events message
URL: https://github.com/apache/openwhisk/pull/4874#issuecomment-612135057
> Just to confirm the impact on backward compatability.
>
> * Any existing code which is processing the user-events using older version of Message parsing code would work as is as it would just ignore activationId
> * New code reading older events - Should not happen in general
>
> Should we account for case where parser should be able to handle missing activationId i.e. mark it as `Option`
Not sure if it needs to be an `Option` as any existing external service to openwhisk parsing the events topic just wouldn't look for activationId right? It would just ignore until it started looking for the field.
And the client with the parser can just upgrade openwhisk, all messages will have the new field after a few minutes, then upgrade their parser to parse for activationId too if they want so don't think accounting for that last case is useful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah commented on issue #4874: add activationId to
events message
Posted by GitBox <gi...@apache.org>.
rabbah commented on issue #4874: add activationId to events message
URL: https://github.com/apache/openwhisk/pull/4874#issuecomment-611740138
Thanks @bdoyle0182.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services