[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #211: [Baseline] Apply baseline to iceberg-orc #158

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #211: [Baseline] Apply baseline to iceberg-orc #158
URL: https://github.com/apache/incubator-iceberg/pull/211#discussion_r292554522
 
 

 ##########
 File path: orc/src/main/java/org/apache/iceberg/orc/ORC.java
 ##########
 @@ -124,18 +123,18 @@ private ReadBuilder(InputFile file) {
     /**
      * Restricts the read to the given range: [start, start + length).
      *
-     * @param start the start position for this read
-     * @param length the length of the range this read should scan
+     * @param newStart the start position for this read
+     * @param newLength the length of the range this read should scan
      * @return this builder for method chaining
      */
-    public ReadBuilder split(long start, long length) {
-      this.start = start;
-      this.length = length;
+    public ReadBuilder split(long newStart, long newLength) {
+      this.start = newStart;
+      this.length = newLength;
       return this;
     }
 
-    public ReadBuilder schema(org.apache.iceberg.Schema schema) {
-      this.schema = schema;
+    public ReadBuilder schema(org.apache.iceberg.Schema projectedSchema) {
 
 Review comment:
   Nit: should probably be "projectSchema" not "projected". It doesn't make sense to use past tense; this is configuring a read that hasn't happened yet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org