Re: [PR] ADD git-sync container lifecycle hooks [airflow]

["getChan (via GitHub)" <gi...@apache.org>]

getChan commented on PR #40369:
URL: https://github.com/apache/airflow/pull/40369#issuecomment-2186635970

   > What if there is a global `.Values.containerLifecycleHooks`? Don't we want something like in [here](https://github.com/apache/airflow/blob/main/chart%2Ftemplates%2Fscheduler%2Fscheduler-deployment.yaml#L44)? Or do we not want it defined for this at the global level?
   @nevcohen 
   thanks for opinion.
   I added global lifecycle hook condition. 
   ```
   {{- $containerLifecycleHooksGitSync := or .Values.dags.gitSync.containerLifecycleHooks .Values.containerLifecycleHooks }}
   ```
   It works same as other container hooks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org