Re: [PR] openlineage: Add AirflowDagRunFacet to dag runEvents [airflow]

["kacpermuda (via GitHub)" <gi...@apache.org>]

kacpermuda commented on code in PR #40854:
URL: https://github.com/apache/airflow/pull/40854#discussion_r1686194775


##########
airflow/providers/openlineage/plugins/adapter.py:
##########
@@ -329,19 +330,26 @@ def dag_started(
         self,
         dag_run: DagRun,
         msg: str,
-        nominal_start_time: str,
-        nominal_end_time: str,

Review Comment:
   Instead of building it in listener, we moved it to the inside of the adapter's method. I'm okay with that, but not sure if the adapter methods are part of "public" api and it's `breaking` change @mobuchowski ? 



##########
airflow/providers/openlineage/plugins/adapter.py:
##########
@@ -329,19 +330,26 @@ def dag_started(
         self,
         dag_run: DagRun,
         msg: str,
-        nominal_start_time: str,
-        nominal_end_time: str,
         job_facets: dict[str, BaseFacet] | None = None,  # Custom job facets
+        run_facets: dict[str, BaseFacet] | None = None,  # Custom run facets
     ):
+        if not run_facets:
+            run_facets = {}

Review Comment:
   Is this used anywhere now that we don't build this new run facet in listener? I think we can remove it for now if not used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org