You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by "SamTV12345 (via GitHub)" <gi...@apache.org> on 2023/05/31 19:42:47 UTC

[GitHub] [activemq-artemis] SamTV12345 commented on pull request #4307: ARTEMIS-3042 Add docker multistage build

SamTV12345 commented on PR #4307:
URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1570835609

   > Minor suggestion:
   > 
   > > apt install tree curl -y
   > 
   > can be replaced with existing tools:
   > 
   > * tree -> ls -l (easy one)
   > * curl -> wget (more complex)
   
   This is performed in the builder section. This section is executed one time at the beginning of the pipeline. Any subsequent pipeline runs in the future will have this command cached and it will never be rerun as it is done just at the beginning. I tuned the Dockerfile to cache the things that are static like apt packages and add the dynamic parts of the app e.g. artemis at the end.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org