You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Roland Weber <RO...@de.ibm.com> on 2005/11/28 08:29:35 UTC
HttpComponents - dependency on clover.jar
Hi Oleg,
this weekend I tried to compile http-core but failed because a
<taskdef> requires clover.jar, which was not among the files
I got out of subversion. While you're rewriting http-core, could
you spend a few minutes to make the taskdef optional?
Maybe something like this in build-common.xml:
<target name="prepare-clover">
<taskdef resource="clovertasks" />
</target>
and add the dependency on prepare-clover to the tasks that
need it, so that others can be executed without.
cheers,
Roland
bugzilla@apache.org
27.11.2005 14:03
Please respond to
"HttpClient Project"
To
httpclient-dev@jakarta.apache.org
cc
Subject
DO NOT REPLY [Bug 37634] - Findbugs on httpcomponents
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37634>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=37634
olegk@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Target Milestone|--- |4.0
------- Additional Comments From olegk@apache.org 2005-11-27 14:03
-------
Sebastian,
I am right in the midst of a major rewrite of http-core. I'll apply the
patches
as soon as this refactoring is finished
Oleg
--
Configure bugmail:
http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: HttpComponents - dependency on clover.jar
Posted by Roland Weber <RO...@de.ibm.com>.
Hi Oleg,
> Should be fixed now. Please re-test
>
I'll try again this week-end.
cheers,
Roland
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: HttpComponents - dependency on clover.jar
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Mon, 2005-11-28 at 08:29 +0100, Roland Weber wrote:
> Hi Oleg,
>
> this weekend I tried to compile http-core but failed because a
> <taskdef> requires clover.jar, which was not among the files
> I got out of subversion. While you're rewriting http-core, could
> you spend a few minutes to make the taskdef optional?
> Maybe something like this in build-common.xml:
>
> <target name="prepare-clover">
> <taskdef resource="clovertasks" />
> </target>
>
> and add the dependency on prepare-clover to the tasks that
> need it, so that others can be executed without.
>
Roland,
Should be fixed now. Please re-test
Oleg
> cheers,
> Roland
>
>
>
>
>
> bugzilla@apache.org
> 27.11.2005 14:03
> Please respond to
> "HttpClient Project"
>
>
> To
> httpclient-dev@jakarta.apache.org
> cc
>
> Subject
> DO NOT REPLY [Bug 37634] - Findbugs on httpcomponents
>
>
>
>
>
>
> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
> RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
> <http://issues.apache.org/bugzilla/show_bug.cgi?id=37634>.
> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
> INSERTED IN THE BUG DATABASE.
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=37634
>
>
> olegk@apache.org changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Status|NEW |ASSIGNED
> Target Milestone|--- |4.0
>
>
>
>
> ------- Additional Comments From olegk@apache.org 2005-11-27 14:03
> -------
> Sebastian,
> I am right in the midst of a major rewrite of http-core. I'll apply the
> patches
> as soon as this refactoring is finished
>
> Oleg
>
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: HttpComponents - initial feedback
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Mon, Dec 05, 2005 at 08:02:53AM +0100, Roland Weber wrote:
> Hi Oleg,
>
> HttpComponents now compiles without clover.jar. I haven't found
> time to write any code to the new API since I spent most of my
> computer time this week-end with configuring mail tools. From
> randomly skipping through the JavaDocs, I have three comments of
> varying significance:
>
> 1. (cosmetic)
> HttpContext could have a removeAttribute(String), like
> javax.servlet.ServletRequest and javax.portlet.PortletRequest
>
Agreed.
> 2. (architectural)
> AbstractHttpProcessor should be based on java.util.List rather
> than java.util.Set. I'm sure we'll soon encounter cases where
> the order of interceptors is relevant, for example if multiple
> transfer encodings should be applied. Also, we should not rule
> out that the same interceptor could be applied multiple times,
> for example if it is a sanity-check interceptor for debugging.
>
Agreed.
> 3. (esoteric)
> I noticed some socket and IP specific methods in HttpClientConnection
> and HttpServerConnection. I admit that this is far-fetched, but HTTP
> is not specific to IP (RFC 2616, section 1.4, last paragraph on
> page 12). I wonder whether it would be much effort to isolate the
> dependencies on java.net.INetAddress and/or java.net.Socket to make
> the HttpComponents API independent of it. If we ever want to do it,
> we should do it now.
I have to say some people already dismissed HttpComponents as a complete
waste because of what they see is excessive abstraction and abuse of
interfaces. I would be a little reluctant to add a whole new level of
abstraction for something that is not backed by a real world application
but let us think it over. Opinions?
Many thanks for the code review
Oleg
>
> cheers,
> Roland
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: Broken links to mailing lists
Posted by Ortwin Glück <od...@odi.ch>.
Roland,
That happened due to a Maven bug. It should work with the current
version. The archive links are also broken. By the way mail-archives are
using a new software *again*, sigh. And this time it looks like they
forgot a search facility. How stupid is that?
Odi
Roland Weber wrote:
> Hi folks,
>
> our subscribe and unsubscribe links are broken.
> They are missing the mailto: scheme prefix.
>
> http://jakarta.apache.org/commons/httpclient/mail-lists.html
>
>
> cheers,
> Roland
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
>
--
[web] http://www.odi.ch/
[blog] http://www.odi.ch/weblog/
[pgp] key 0x81CF3416
finger print F2B1 B21F F056 D53E 5D79 A5AF 02BE 70F5 81CF 3416
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Broken links to mailing lists
Posted by Roland Weber <RO...@de.ibm.com>.
Hi folks,
our subscribe and unsubscribe links are broken.
They are missing the mailto: scheme prefix.
http://jakarta.apache.org/commons/httpclient/mail-lists.html
cheers,
Roland
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: HttpComponents - initial feedback
Posted by Michael Becke <mb...@gmail.com>.
Yes, completely agree. We should keep the API as practical as possible.
Mike
On 12/5/05, Ortwin Glück <od...@odi.ch> wrote:
>
>
> Roland Weber wrote:
> > That's why I rated this as esoteric. You can implement any kind of
> > protocol via JNI. The protocols I can think of are either not meant
> > for HTTP, or can be mapped to the Socket API. The best I can come
> > up with here are pipes, but why should anybody want to use HTTP
> > via pipes?
> > The mail about a native implementation of SSL sockets a few days ago
> > made me think of this. On second thoughts, they were still providing
> > java.net.Socket, they just couldn't create the SSL socket on top of
> > an existing Java socket.
> >
> > Back in the old days, when working on my diploma thesis and before,
> > I was programming on an operating system for a message passing
> > parallel computer. We didn't have anything like TCP/IP there, but
> > an OS specific communication infrastructure. Of course there was no
> > Java either :-) But that's why I am sometimes thinking queer and
> > non-TCP, like in this case.
> >
> > cheers,
> > Roland
>
> Roland,
>
> Thanks for explaining. But I think we should not start to implement
> purely academic scenarios. It only leads to overengineered architecture
> and adds complexity that is otherwise unecessary. In the end it scares
> people and make the API harder to use. Unless nobody comes up and asks
> if we can support HTTP over IPX or something, I wouldn't bother.
>
> Odi
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: HttpComponents - initial feedback
Posted by Roland Weber <RO...@de.ibm.com>.
Hi Odi,
> Unless nobody comes up and asks
> if we can support HTTP over IPX or something, I wouldn't bother.
Fair enough.
cheers,
Roland
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: HttpComponents - initial feedback
Posted by Ortwin Glück <od...@odi.ch>.
Roland Weber wrote:
> That's why I rated this as esoteric. You can implement any kind of
> protocol via JNI. The protocols I can think of are either not meant
> for HTTP, or can be mapped to the Socket API. The best I can come
> up with here are pipes, but why should anybody want to use HTTP
> via pipes?
> The mail about a native implementation of SSL sockets a few days ago
> made me think of this. On second thoughts, they were still providing
> java.net.Socket, they just couldn't create the SSL socket on top of
> an existing Java socket.
>
> Back in the old days, when working on my diploma thesis and before,
> I was programming on an operating system for a message passing
> parallel computer. We didn't have anything like TCP/IP there, but
> an OS specific communication infrastructure. Of course there was no
> Java either :-) But that's why I am sometimes thinking queer and
> non-TCP, like in this case.
>
> cheers,
> Roland
Roland,
Thanks for explaining. But I think we should not start to implement
purely academic scenarios. It only leads to overengineered architecture
and adds complexity that is otherwise unecessary. In the end it scares
people and make the API harder to use. Unless nobody comes up and asks
if we can support HTTP over IPX or something, I wouldn't bother.
Odi
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: HttpComponents - initial feedback
Posted by Roland Weber <RO...@de.ibm.com>.
Hi Odi,
> > 3. (esoteric)
>
> What other protocols are there used today in place of IP? Does Java
> support them?
That's why I rated this as esoteric. You can implement any kind of
protocol via JNI. The protocols I can think of are either not meant
for HTTP, or can be mapped to the Socket API. The best I can come
up with here are pipes, but why should anybody want to use HTTP
via pipes?
The mail about a native implementation of SSL sockets a few days ago
made me think of this. On second thoughts, they were still providing
java.net.Socket, they just couldn't create the SSL socket on top of
an existing Java socket.
Back in the old days, when working on my diploma thesis and before,
I was programming on an operating system for a message passing
parallel computer. We didn't have anything like TCP/IP there, but
an OS specific communication infrastructure. Of course there was no
Java either :-) But that's why I am sometimes thinking queer and
non-TCP, like in this case.
cheers,
Roland
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: HttpComponents - initial feedback
Posted by Ortwin Glück <od...@odi.ch>.
Roland Weber wrote:
> 3. (esoteric)
> I noticed some socket and IP specific methods in HttpClientConnection
> and HttpServerConnection. I admit that this is far-fetched, but HTTP
> is not specific to IP (RFC 2616, section 1.4, last paragraph on
> page 12). I wonder whether it would be much effort to isolate the
> dependencies on java.net.INetAddress and/or java.net.Socket to make
> the HttpComponents API independent of it. If we ever want to do it,
> we should do it now.
What other protocols are there used today in place of IP? Does Java
support them?
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: HttpComponents - initial feedback
Posted by Oleg Kalnichevski <ol...@apache.org>.
Roland Weber wrote:
> Hi Oleg,
>
> HttpComponents now compiles without clover.jar. I haven't found
> time to write any code to the new API since I spent most of my
> computer time this week-end with configuring mail tools. From
> randomly skipping through the JavaDocs, I have three comments of
> varying significance:
>
> 1. (cosmetic)
> HttpContext could have a removeAttribute(String), like
> javax.servlet.ServletRequest and javax.portlet.PortletRequest
>
Done
> 2. (architectural)
> AbstractHttpProcessor should be based on java.util.List rather
> than java.util.Set. I'm sure we'll soon encounter cases where
> the order of interceptors is relevant, for example if multiple
> transfer encodings should be applied. Also, we should not rule
> out that the same interceptor could be applied multiple times,
> for example if it is a sanity-check interceptor for debugging.
>
Done
> 3. (esoteric)
> I noticed some socket and IP specific methods in HttpClientConnection
> and HttpServerConnection. I admit that this is far-fetched, but HTTP
> is not specific to IP (RFC 2616, section 1.4, last paragraph on
> page 12). I wonder whether it would be much effort to isolate the
> dependencies on java.net.INetAddress and/or java.net.Socket to make
> the HttpComponents API independent of it. If we ever want to do it,
> we should do it now.
>
> cheers,
> Roland
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
HttpComponents - initial feedback
Posted by Roland Weber <RO...@de.ibm.com>.
Hi Oleg,
HttpComponents now compiles without clover.jar. I haven't found
time to write any code to the new API since I spent most of my
computer time this week-end with configuring mail tools. From
randomly skipping through the JavaDocs, I have three comments of
varying significance:
1. (cosmetic)
HttpContext could have a removeAttribute(String), like
javax.servlet.ServletRequest and javax.portlet.PortletRequest
2. (architectural)
AbstractHttpProcessor should be based on java.util.List rather
than java.util.Set. I'm sure we'll soon encounter cases where
the order of interceptors is relevant, for example if multiple
transfer encodings should be applied. Also, we should not rule
out that the same interceptor could be applied multiple times,
for example if it is a sanity-check interceptor for debugging.
3. (esoteric)
I noticed some socket and IP specific methods in HttpClientConnection
and HttpServerConnection. I admit that this is far-fetched, but HTTP
is not specific to IP (RFC 2616, section 1.4, last paragraph on
page 12). I wonder whether it would be much effort to isolate the
dependencies on java.net.INetAddress and/or java.net.Socket to make
the HttpComponents API independent of it. If we ever want to do it,
we should do it now.
cheers,
Roland
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: HttpComponents - dependency on clover.jar
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Mon, Nov 28, 2005 at 08:29:35AM +0100, Roland Weber wrote:
> Hi Oleg,
>
> this weekend I tried to compile http-core but failed because a
> <taskdef> requires clover.jar, which was not among the files
> I got out of subversion. While you're rewriting http-core, could
> you spend a few minutes to make the taskdef optional?
> Maybe something like this in build-common.xml:
>
> <target name="prepare-clover">
> <taskdef resource="clovertasks" />
> </target>
>
> and add the dependency on prepare-clover to the tasks that
> need it, so that others can be executed without.
>
> cheers,
> Roland
>
>
Roland,
One should still be able to compile and build http-core without
clover.jar. Only test task fails as far as I can tell. I'll fix the
build.xml shortly
Anyways, I am looking forward to getting your feedback Please note
http-core is currently in a state of flux. I have been rewriting the
parsing code to reduce the amount of intermediate garbage generated
while parsing HTTP messages. I will write a detailed report of what has
been done once things are more or less complete
Oleg
>
>
>
> bugzilla@apache.org
> 27.11.2005 14:03
> Please respond to
> "HttpClient Project"
>
>
> To
> httpclient-dev@jakarta.apache.org
> cc
>
> Subject
> DO NOT REPLY [Bug 37634] - Findbugs on httpcomponents
>
>
>
>
>
>
> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG?
> RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
> <http://issues.apache.org/bugzilla/show_bug.cgi?id=37634>.
> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND?
> INSERTED IN THE BUG DATABASE.
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=37634
>
>
> olegk@apache.org changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Status|NEW |ASSIGNED
> Target Milestone|--- |4.0
>
>
>
>
> ------- Additional Comments From olegk@apache.org 2005-11-27 14:03
> -------
> Sebastian,
> I am right in the midst of a major rewrite of http-core. I'll apply the
> patches
> as soon as this refactoring is finished
>
> Oleg
>
> --
> Configure bugmail:
> http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org