You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by rf...@apache.org on 2019/04/02 19:54:18 UTC
[maven-plugin-testing] 01/01: Fix checkstyle reported errors
This is an automated email from the ASF dual-hosted git repository.
rfscholte pushed a commit to branch stabilize
in repository https://gitbox.apache.org/repos/asf/maven-plugin-testing.git
commit 3c58e9370ad3755132719dbdc6654f11a85ddc1f
Author: rfscholte <rf...@apache.org>
AuthorDate: Tue Apr 2 21:54:08 2019 +0200
Fix checkstyle reported errors
---
.../maven/plugin/testing/AbstractMojoTestCase.java | 12 +++---
.../maven/plugin/testing/MojoParameters.java | 4 +-
.../org/apache/maven/plugin/testing/MojoRule.java | 26 +++++++------
.../testing/ResolverExpressionEvaluatorStub.java | 2 +-
.../apache/maven/plugin/testing/WithoutMojo.java | 15 ++++----
.../plugin/testing/stubs/MavenProjectStub.java | 3 +-
.../testing/stubs/StubArtifactCollector.java | 1 -
.../plugin/testing/stubs/StubArtifactResolver.java | 44 +++++++++++++---------
.../maven/shared/test/plugin/ProjectTool.java | 17 ++++-----
.../shared/tools/easymock/TestFileManager.java | 4 +-
pom.xml | 4 +-
11 files changed, 74 insertions(+), 58 deletions(-)
diff --git a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java
index 8b047a7..80058bb 100644
--- a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java
+++ b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java
@@ -478,7 +478,8 @@ public abstract class AbstractMojoTestCase
if ( mojoDescriptor.getComponentConfigurator() != null )
{
- configurator = getContainer().lookup( ComponentConfigurator.class, mojoDescriptor.getComponentConfigurator() );
+ configurator =
+ getContainer().lookup( ComponentConfigurator.class, mojoDescriptor.getComponentConfigurator() );
}
configurator.configureComponent( mojo, pluginConfiguration, evaluator, getContainer().getContainerRealm() );
@@ -512,13 +513,13 @@ public abstract class AbstractMojoTestCase
protected MojoExecution newMojoExecution( String goal )
{
MojoDescriptor mojoDescriptor = mojoDescriptors.get( goal );
- assertNotNull(String.format("The MojoDescriptor for the goal %s cannot be null.", goal), mojoDescriptor );
+ assertNotNull( String.format( "The MojoDescriptor for the goal %s cannot be null.", goal ), mojoDescriptor );
MojoExecution execution = new MojoExecution( mojoDescriptor );
finalizeMojoConfiguration( execution );
return execution;
}
- // copy&paste from org.apache.maven.lifecycle.internal.DefaultLifecycleExecutionPlanCalculator.finalizeMojoConfiguration(MojoExecution)
+ // copy&paste from o.a.m.l.i.DefaultLifecycleExecutionPlanCalculator.finalizeMojoConfiguration(MojoExecution)
private void finalizeMojoConfiguration( MojoExecution mojoExecution )
{
MojoDescriptor mojoDescriptor = mojoExecution.getMojoDescriptor();
@@ -529,7 +530,7 @@ public abstract class AbstractMojoTestCase
executionConfiguration = new Xpp3Dom( "configuration" );
}
- Xpp3Dom defaultConfiguration = MojoDescriptorCreator.convert( mojoDescriptor );;
+ Xpp3Dom defaultConfiguration = MojoDescriptorCreator.convert( mojoDescriptor );
Xpp3Dom finalConfiguration = new Xpp3Dom( "configuration" );
@@ -546,7 +547,8 @@ public abstract class AbstractMojoTestCase
Xpp3Dom parameterDefaults = defaultConfiguration.getChild( parameter.getName() );
- parameterConfiguration = Xpp3Dom.mergeXpp3Dom( parameterConfiguration, parameterDefaults, Boolean.TRUE );
+ parameterConfiguration =
+ Xpp3Dom.mergeXpp3Dom( parameterConfiguration, parameterDefaults, Boolean.TRUE );
if ( parameterConfiguration != null )
{
diff --git a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/MojoParameters.java b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/MojoParameters.java
index 7412bc4..2ac2e14 100644
--- a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/MojoParameters.java
+++ b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/MojoParameters.java
@@ -1,7 +1,5 @@
package org.apache.maven.plugin.testing;
-import org.codehaus.plexus.util.xml.Xpp3Dom;
-
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
@@ -21,6 +19,8 @@ import org.codehaus.plexus.util.xml.Xpp3Dom;
* under the License.
*/
+import org.codehaus.plexus.util.xml.Xpp3Dom;
+
/**
* Static helpers to create and manipulate mojo execution configuration parameters
*
diff --git a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/MojoRule.java b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/MojoRule.java
index 0f8e91e..0bd68fd 100644
--- a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/MojoRule.java
+++ b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/MojoRule.java
@@ -64,10 +64,12 @@ public class MojoRule
public MojoRule()
{
- this( new AbstractMojoTestCase() {} );
+ this( new AbstractMojoTestCase()
+ {
+ } );
}
- public MojoRule(AbstractMojoTestCase testCase)
+ public MojoRule( AbstractMojoTestCase testCase )
{
this.testCase = testCase;
}
@@ -291,28 +293,30 @@ public class MojoRule
}
@Override
- public Statement apply(final Statement base, Description description) {
- if (description.getAnnotation(WithoutMojo.class) != null) // skip.
+ public Statement apply( final Statement base, Description description )
+ {
+ if ( description.getAnnotation( WithoutMojo.class ) != null ) // skip.
{
return base;
}
- return new Statement()
+ return new Statement()
{
@Override
- public void evaluate() throws Throwable
+ public void evaluate()
+ throws Throwable
{
testCase.setUp();
before();
- try
+ try
{
base.evaluate();
- }
- finally
+ }
+ finally
{
after();
}
- }
- };
+ }
+ };
}
/**
diff --git a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/ResolverExpressionEvaluatorStub.java b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/ResolverExpressionEvaluatorStub.java
index 20bea3b..a6ecabd 100644
--- a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/ResolverExpressionEvaluatorStub.java
+++ b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/ResolverExpressionEvaluatorStub.java
@@ -85,7 +85,7 @@ public class ResolverExpressionEvaluatorStub
{
return PlexusTestCase.getBasedir();
}
- else if ( expression.startsWith( "basedir" )|| expression.startsWith( "project.basedir" ) )
+ else if ( expression.startsWith( "basedir" ) || expression.startsWith( "project.basedir" ) )
{
int pathSeparator = expression.indexOf( "/" );
diff --git a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/WithoutMojo.java b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/WithoutMojo.java
index ae7cd72..afd0f34 100644
--- a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/WithoutMojo.java
+++ b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/WithoutMojo.java
@@ -1,8 +1,5 @@
package org.apache.maven.plugin.testing;
-import java.lang.annotation.Documented;
-import java.lang.annotation.Retention;
-
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
@@ -24,6 +21,9 @@ import java.lang.annotation.Retention;
import static java.lang.annotation.ElementType.METHOD;
import static java.lang.annotation.RetentionPolicy.RUNTIME;
+
+import java.lang.annotation.Documented;
+import java.lang.annotation.Retention;
import java.lang.annotation.Target;
/**
@@ -32,9 +32,10 @@ import java.lang.annotation.Target;
*
* @author Mirko Friedenhagen
*/
-@Retention(RUNTIME)
+@Retention( RUNTIME )
@Documented
-@Target(METHOD)
-public @interface WithoutMojo {
-
+@Target( METHOD )
+public @interface WithoutMojo
+{
+
}
diff --git a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/stubs/MavenProjectStub.java b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/stubs/MavenProjectStub.java
index f8d775f..c9b3a55 100644
--- a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/stubs/MavenProjectStub.java
+++ b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/stubs/MavenProjectStub.java
@@ -1456,7 +1456,8 @@ public class MavenProjectStub
*
* @see org.apache.maven.project.MavenProject#createArtifacts(org.apache.maven.artifact.factory.ArtifactFactory, java.lang.String, org.apache.maven.artifact.resolver.filter.ArtifactFilter)
*/
- public Set<Artifact> createArtifacts( ArtifactFactory artifactFactory, String string, ArtifactFilter artifactFilter )
+ public Set<Artifact> createArtifacts( ArtifactFactory artifactFactory, String string,
+ ArtifactFilter artifactFilter )
{
return Collections.<Artifact>emptySet();
}
diff --git a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/stubs/StubArtifactCollector.java b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/stubs/StubArtifactCollector.java
index be7e156..869069c 100644
--- a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/stubs/StubArtifactCollector.java
+++ b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/stubs/StubArtifactCollector.java
@@ -26,7 +26,6 @@ import java.util.Set;
import org.apache.maven.artifact.Artifact;
import org.apache.maven.artifact.metadata.ArtifactMetadataSource;
import org.apache.maven.artifact.repository.ArtifactRepository;
-import org.apache.maven.artifact.repository.RepositoryRequest;
import org.apache.maven.artifact.resolver.ArtifactCollector;
import org.apache.maven.artifact.resolver.ArtifactResolutionException;
import org.apache.maven.artifact.resolver.ArtifactResolutionRequest;
diff --git a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/stubs/StubArtifactResolver.java b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/stubs/StubArtifactResolver.java
index cc02ec0..4df64e9 100644
--- a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/stubs/StubArtifactResolver.java
+++ b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/stubs/StubArtifactResolver.java
@@ -72,7 +72,8 @@ public class StubArtifactResolver
*
* @see org.apache.maven.artifact.resolver.ArtifactResolver#resolve(org.apache.maven.artifact.Artifact, java.util.List, org.apache.maven.artifact.repository.ArtifactRepository)
*/
- public void resolve( Artifact artifact, List<ArtifactRepository> remoteRepositories, ArtifactRepository localRepository )
+ public void resolve( Artifact artifact, List<ArtifactRepository> remoteRepositories,
+ ArtifactRepository localRepository )
throws ArtifactResolutionException, ArtifactNotFoundException
{
if ( !this.throwArtifactNotFoundException && !this.throwArtifactResolutionException )
@@ -105,8 +106,9 @@ public class StubArtifactResolver
* @see org.apache.maven.artifact.resolver.ArtifactResolver#resolveTransitively(java.util.Set, org.apache.maven.artifact.Artifact, java.util.List, org.apache.maven.artifact.repository.ArtifactRepository, org.apache.maven.artifact.metadata.ArtifactMetadataSource)
*/
public ArtifactResolutionResult resolveTransitively( Set<Artifact> artifacts, Artifact originatingArtifact,
- List<ArtifactRepository> remoteRepositories, ArtifactRepository localRepository,
- ArtifactMetadataSource source )
+ List<ArtifactRepository> remoteRepositories,
+ ArtifactRepository localRepository,
+ ArtifactMetadataSource source )
throws ArtifactResolutionException, ArtifactNotFoundException
{
return null;
@@ -117,8 +119,10 @@ public class StubArtifactResolver
* @see org.apache.maven.artifact.resolver.ArtifactResolver#resolveTransitively(java.util.Set, org.apache.maven.artifact.Artifact, java.util.List, org.apache.maven.artifact.repository.ArtifactRepository, org.apache.maven.artifact.metadata.ArtifactMetadataSource, java.util.List)
*/
public ArtifactResolutionResult resolveTransitively( Set<Artifact> artifacts, Artifact originatingArtifact,
- List<ArtifactRepository> remoteRepositories, ArtifactRepository localRepository,
- ArtifactMetadataSource source, List<ResolutionListener> listeners )
+ List<ArtifactRepository> remoteRepositories,
+ ArtifactRepository localRepository,
+ ArtifactMetadataSource source,
+ List<ResolutionListener> listeners )
throws ArtifactResolutionException, ArtifactNotFoundException
{
return null;
@@ -129,8 +133,9 @@ public class StubArtifactResolver
* @see org.apache.maven.artifact.resolver.ArtifactResolver#resolveTransitively(java.util.Set, org.apache.maven.artifact.Artifact, org.apache.maven.artifact.repository.ArtifactRepository, java.util.List, org.apache.maven.artifact.metadata.ArtifactMetadataSource, org.apache.maven.artifact.resolver.filter.ArtifactFilter)
*/
public ArtifactResolutionResult resolveTransitively( Set<Artifact> artifacts, Artifact originatingArtifact,
- ArtifactRepository localRepository, List<ArtifactRepository> remoteRepositories,
- ArtifactMetadataSource source, ArtifactFilter filter )
+ ArtifactRepository localRepository,
+ List<ArtifactRepository> remoteRepositories,
+ ArtifactMetadataSource source, ArtifactFilter filter )
throws ArtifactResolutionException, ArtifactNotFoundException
{
return null;
@@ -141,8 +146,9 @@ public class StubArtifactResolver
* @see org.apache.maven.artifact.resolver.ArtifactResolver#resolveTransitively(java.util.Set, org.apache.maven.artifact.Artifact, java.util.Map, org.apache.maven.artifact.repository.ArtifactRepository, java.util.List, org.apache.maven.artifact.metadata.ArtifactMetadataSource)
*/
public ArtifactResolutionResult resolveTransitively( Set<Artifact> artifacts, Artifact originatingArtifact,
- Map managedVersions, ArtifactRepository localRepository,
- List<ArtifactRepository> remoteRepositories, ArtifactMetadataSource source )
+ Map managedVersions, ArtifactRepository localRepository,
+ List<ArtifactRepository> remoteRepositories,
+ ArtifactMetadataSource source )
throws ArtifactResolutionException, ArtifactNotFoundException
{
return null;
@@ -153,9 +159,9 @@ public class StubArtifactResolver
* @see org.apache.maven.artifact.resolver.ArtifactResolver#resolveTransitively(java.util.Set, org.apache.maven.artifact.Artifact, java.util.Map, org.apache.maven.artifact.repository.ArtifactRepository, java.util.List, org.apache.maven.artifact.metadata.ArtifactMetadataSource, org.apache.maven.artifact.resolver.filter.ArtifactFilter)
*/
public ArtifactResolutionResult resolveTransitively( Set<Artifact> artifacts, Artifact originatingArtifact,
- Map managedVersions, ArtifactRepository localRepository,
- List<ArtifactRepository> remoteRepositories, ArtifactMetadataSource source,
- ArtifactFilter filter )
+ Map managedVersions, ArtifactRepository localRepository,
+ List<ArtifactRepository> remoteRepositories,
+ ArtifactMetadataSource source, ArtifactFilter filter )
throws ArtifactResolutionException, ArtifactNotFoundException
{
return null;
@@ -166,9 +172,10 @@ public class StubArtifactResolver
* @see org.apache.maven.artifact.resolver.ArtifactResolver#resolveTransitively(java.util.Set, org.apache.maven.artifact.Artifact, java.util.Map, org.apache.maven.artifact.repository.ArtifactRepository, java.util.List, org.apache.maven.artifact.metadata.ArtifactMetadataSource, org.apache.maven.artifact.resolver.filter.ArtifactFilter, java.util.List)
*/
public ArtifactResolutionResult resolveTransitively( Set<Artifact> artifacts, Artifact originatingArtifact,
- Map managedVersions, ArtifactRepository localRepository,
- List<ArtifactRepository> remoteRepositories, ArtifactMetadataSource source,
- ArtifactFilter filter, List<ResolutionListener> listeners )
+ Map managedVersions, ArtifactRepository localRepository,
+ List<ArtifactRepository> remoteRepositories,
+ ArtifactMetadataSource source, ArtifactFilter filter,
+ List<ResolutionListener> listeners )
throws ArtifactResolutionException, ArtifactNotFoundException
{
return null;
@@ -179,14 +186,15 @@ public class StubArtifactResolver
*
* @see org.apache.maven.artifact.resolver.ArtifactResolver#resolveAlways(org.apache.maven.artifact.Artifact, java.util.List, org.apache.maven.artifact.repository.ArtifactRepository)
*/
- public void resolveAlways( Artifact artifact, List<ArtifactRepository> remoteRepositories, ArtifactRepository localRepository )
+ public void resolveAlways( Artifact artifact, List<ArtifactRepository> remoteRepositories,
+ ArtifactRepository localRepository )
throws ArtifactResolutionException, ArtifactNotFoundException
{
// nop
}
- public void resolve( Artifact artifact, List<ArtifactRepository> remoteRepositories, ArtifactRepository localRepository,
- TransferListener downloadMonitor )
+ public void resolve( Artifact artifact, List<ArtifactRepository> remoteRepositories,
+ ArtifactRepository localRepository, TransferListener downloadMonitor )
throws ArtifactResolutionException, ArtifactNotFoundException
{
// TODO Auto-generated method stub
diff --git a/maven-plugin-testing-tools/src/main/java/org/apache/maven/shared/test/plugin/ProjectTool.java b/maven-plugin-testing-tools/src/main/java/org/apache/maven/shared/test/plugin/ProjectTool.java
index fa7f686..9480017 100644
--- a/maven-plugin-testing-tools/src/main/java/org/apache/maven/shared/test/plugin/ProjectTool.java
+++ b/maven-plugin-testing-tools/src/main/java/org/apache/maven/shared/test/plugin/ProjectTool.java
@@ -240,7 +240,9 @@ public class ProjectTool
try
{
ProjectBuildingRequest request = new DefaultProjectBuildingRequest();
- request.setLocalRepository( artifactRepositoryFactory.createArtifactRepository( "local", new File( "target/localrepo" ).getCanonicalFile().toURL().toExternalForm(), "default", null, null ) );
+ request.setLocalRepository( artifactRepositoryFactory.createArtifactRepository( "local",
+ new File( "target/localrepo" ).getCanonicalFile().toURL().toExternalForm(),
+ "default", null, null ) );
request.setRepositorySession( MavenRepositorySystemUtils.newSession() );
MavenProject project = projectBuilder.build( pomInfo.getPomFile(), request ).getProject();
@@ -256,21 +258,18 @@ public class ProjectTool
}
catch ( ProjectBuildingException e )
{
- throw new TestToolsException(
- "Error building MavenProject instance from test pom: " + pomInfo.getPomFile(),
+ throw new TestToolsException( "Error building MavenProject instance from test pom: " + pomInfo.getPomFile(),
e );
}
catch ( UnknownRepositoryLayoutException e )
{
- throw new TestToolsException(
- "Error building ArtifactRepository instance from test pom: " + pomInfo.getPomFile(),
- e );
+ throw new TestToolsException( "Error building ArtifactRepository instance from test pom: "
+ + pomInfo.getPomFile(), e );
}
catch ( IOException e )
{
- throw new TestToolsException(
- "Error building ArtifactRepository instance from test pom: " + pomInfo.getPomFile(),
- e );
+ throw new TestToolsException( "Error building ArtifactRepository instance from test pom: "
+ + pomInfo.getPomFile(), e );
}
}
diff --git a/maven-test-tools/src/main/java/org/apache/maven/shared/tools/easymock/TestFileManager.java b/maven-test-tools/src/main/java/org/apache/maven/shared/tools/easymock/TestFileManager.java
index 461f079..b1a3ab9 100644
--- a/maven-test-tools/src/main/java/org/apache/maven/shared/tools/easymock/TestFileManager.java
+++ b/maven-test-tools/src/main/java/org/apache/maven/shared/tools/easymock/TestFileManager.java
@@ -110,9 +110,11 @@ public class TestFileManager
*/
public synchronized File createTempDir()
{
+ final int sleepDefault = 20;
+
try
{
- Thread.sleep( 20 );
+ Thread.sleep( sleepDefault );
}
catch ( InterruptedException e )
{
diff --git a/pom.xml b/pom.xml
index 1985a20..9797c5e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -25,8 +25,8 @@ under the License.
<parent>
<artifactId>maven-parent</artifactId>
<groupId>org.apache.maven</groupId>
- <version>24</version>
- <relativePath>../pom/maven/pom.xml</relativePath>
+ <version>33</version>
+ <relativePath/>
</parent>
<groupId>org.apache.maven.plugin-testing</groupId>