You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by we...@apache.org on 2009/02/06 12:53:17 UTC
svn commit: r741545 - in
/myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces:
_util/_JSF2Utils.js _util/_Logger.js ajax/jsf.js
Author: werpu
Date: Fri Feb 6 11:53:16 2009
New Revision: 741545
URL: http://svn.apache.org/viewvc?rev=741545&view=rev
Log:
https://issues.apache.org/jira/browse/MYFACES-2112
https://issues.apache.org/jira/browse/MYFACES-2110
improved the logging messages ...
Modified:
myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/_util/_JSF2Utils.js
myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/_util/_Logger.js
myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/ajax/jsf.js
Modified: myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/_util/_JSF2Utils.js
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/_util/_JSF2Utils.js?rev=741545&r1=741544&r2=741545&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/_util/_JSF2Utils.js (original)
+++ myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/_util/_JSF2Utils.js Fri Feb 6 11:53:16 2009
@@ -194,6 +194,7 @@
if(null == myfaces._JSF2Utils._logger) {
myfaces._JSF2Utils._logger = myfaces._Logger.getInstance();
}
+ return myfaces._JSF2Utils._logger;
};
// Logging helper for use in Firebug
@@ -201,14 +202,14 @@
myfaces._JSF2Utils.logWarning = function(varArgs/*,...*/)
{
var logger = myfaces._JSF2Utils._getLogger();
- logger.warn(varArgs);
+ logger["warn"].apply(logger, arguments);
// else???
};
myfaces._JSF2Utils.logDebug = function(varArgs/*,...*/)
{
var logger = myfaces._JSF2Utils._getLogger();
- logger.debug(varArgs);
+ logger["debug"].apply(logger, arguments);
// else???
};
@@ -216,7 +217,7 @@
myfaces._JSF2Utils.logInfo = function(varArgs/*,...*/)
{
var logger = myfaces._JSF2Utils._getLogger();
- logger.info(varArgs);
+ logger["info"].apply(logger, arguments);
// else???
};
@@ -225,7 +226,7 @@
myfaces._JSF2Utils.logError = function(varArgs/*,...*/)
{
var logger = myfaces._JSF2Utils._getLogger();
- logger.error(varArgs);
+ logger["error"].apply(logger, arguments);
};
myfaces._JSF2Utils._hitchArgs = function(scope, method /*,...*/) {
Modified: myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/_util/_Logger.js
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/_util/_Logger.js?rev=741545&r1=741544&r2=741545&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/_util/_Logger.js (original)
+++ myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/_util/_Logger.js Fri Feb 6 11:53:16 2009
@@ -89,18 +89,18 @@
if(this._hasConsole) {
if(myfaces._Logger.LOG_CONSOLE) {
//TODO find out how to reference the proper line number etc...
- console[logType.toLowerCase()](myfaces._JSF2Utils.arrayToString( varArgs ));
+ console[logType.toLowerCase()](myfaces._JSF2Utils.arrayToString( arguments[1] ));
}
} else if(null != this._targetDiv) {
if(myfaces._Logger.LOG_DIV) {
- this._targetDiv.innerHTML = this._targetDiv.innerHTML + "<br /> ["+logType+"] : "+ myfaces._JSF2Utils.arrayToString(varArgs, " ");
+ this._targetDiv.innerHTML = this._targetDiv.innerHTML + "<br /> ["+logType+"] : "+ myfaces._JSF2Utils.arrayToString(arguments[1], " ");
}
} else { /*in case a target fails we use document.write*/
if(myfaces._Logger.LOG_DOCUMENT) {
- document.write("<br /> ["+logType+"] : " + myfaces._JSF2Utils.arrayToString(varArgs, " "));
+ document.write("<br /> ["+logType+"] : " + myfaces._JSF2Utils.arrayToString(arguments[1], " "));
}
if(myfaces._Logger.LOG_ALERT) {
- alert("<br /> ["+logType+"] : " + myfaces._JSF2Utils.arrayToString(varArgs, " "));
+ alert("<br /> ["+logType+"] : " + myfaces._JSF2Utils.arrayToString(arguments[1], " "));
}
}
@@ -108,7 +108,6 @@
myfaces._Logger.prototype.debug = function(/*Object*/varArgs/*,...*/) {
if(this._logLevel > this.LOG_LEVEL_DEBUG) return;
-
this._logIt("DEBUG", arguments);
};
myfaces._Logger.prototype.error = function(varArgs/*,...*/) {
Modified: myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/ajax/jsf.js
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/ajax/jsf.js?rev=741545&r1=741544&r2=741545&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/ajax/jsf.js (original)
+++ myfaces/core/branches/2_0_0/api/src/main/javascript/META-INF/resources/javax/faces/ajax/jsf.js Fri Feb 6 11:53:16 2009
@@ -374,6 +374,8 @@
if(!myfaces._JSF2Utils.exists(request, "responseXML")) {
jsf.ajax.sendError(request, context, "emptyResponse");
+ myfaces._JSF2Utils.logError("jsf.ajax.response", "responseXML", "empty response");
+
return;
}
//TODO handle the ppr part here
@@ -404,3 +406,6 @@
*/
return this._projectStage;
};
+
+
+