[GitHub] [gobblin] arjun4084346 commented on a change in pull request #3361: [GOBBLIN-1513] fixed the construction of regex filters

[GitBox <gi...@apache.org>]

arjun4084346 commented on a change in pull request #3361:
URL: https://github.com/apache/gobblin/pull/3361#discussion_r686145529



##########
File path: gobblin-utility/src/main/java/org/apache/gobblin/util/filters/RegexPathFilter.java
##########
@@ -34,6 +35,11 @@
 
   private final Pattern regex;
   private final boolean include;
+  public static final String REGEX = "path.filter.regex";

Review comment:
       imo, this and other path filters can be used to filter any path. They are not tied up with filtering only gobblin datasets.
   In past, there have been discussion about where to keep configs, a) in ConfigurationKeys or somewhere else along with other configs or b) in the class which actually use them.
   For now, I will move it to DatasetUtils




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org