You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2023/01/20 09:55:59 UTC

[GitHub] [hudi] LinMingQiang opened a new pull request, #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …

LinMingQiang opened a new pull request, #7718:
URL: https://github.com/apache/hudi/pull/7718

   …parameter HIVE_SYNC_TABLE_STRATEGY
   
   ### Change Logs
   HoodieSparkSqlWriter#getHiveTableNames
   _Describe context and summary for this change. Highlight if any code was copied._
   
   ### Impact
   HoodieSparkSqlWriter#getHiveTableNames
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   none
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] LinMingQiang commented on pull request #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …

Posted by GitBox <gi...@apache.org>.
LinMingQiang commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1398604505

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1788541845

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1790010506

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812",
       "triggerID" : "1409966254",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "1788907052",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "1789982470",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4864528010313c4bcf59866ff67ef11b8f1e14d0 UNKNOWN
   * ac50108a775e47dc5151eedf6645bccdebf2cb4b Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] LinMingQiang commented on a diff in pull request #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …

Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on code in PR #7718:
URL: https://github.com/apache/hudi/pull/7718#discussion_r1097152042


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -879,13 +880,17 @@ object HoodieSparkSqlWriter {
     if (tableType.equals(COW_TABLE_TYPE_OPT_VAL)) {
       List(tableName)
     } else {
-      val roSuffix = if (hoodieConfig.getBooleanOrDefault(HIVE_SKIP_RO_SUFFIX_FOR_READ_OPTIMIZED_TABLE)) {
-        ""
+      if (!hoodieConfig.getStringOrDefault(HIVE_SYNC_TABLE_STRATEGY).equals(HoodieSyncTableStrategy.ALL.name())) {
+        List(tableName)
       } else {
-        HiveSyncTool.SUFFIX_READ_OPTIMIZED_TABLE
+        val roSuffix = if (hoodieConfig.getBooleanOrDefault(HIVE_SKIP_RO_SUFFIX_FOR_READ_OPTIMIZED_TABLE)) {
+          ""
+        } else {

Review Comment:
   Okay, I'll do it.



##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -879,13 +880,17 @@ object HoodieSparkSqlWriter {
     if (tableType.equals(COW_TABLE_TYPE_OPT_VAL)) {
       List(tableName)
     } else {
-      val roSuffix = if (hoodieConfig.getBooleanOrDefault(HIVE_SKIP_RO_SUFFIX_FOR_READ_OPTIMIZED_TABLE)) {
-        ""
+      if (!hoodieConfig.getStringOrDefault(HIVE_SYNC_TABLE_STRATEGY).equals(HoodieSyncTableStrategy.ALL.name())) {
+        List(tableName)
       } else {
-        HiveSyncTool.SUFFIX_READ_OPTIMIZED_TABLE
+        val roSuffix = if (hoodieConfig.getBooleanOrDefault(HIVE_SKIP_RO_SUFFIX_FOR_READ_OPTIMIZED_TABLE)) {
+          ""
+        } else {

Review Comment:
   👌, I'll do it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1790004228

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812",
       "triggerID" : "1409966254",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "1788907052",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1789982470",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4864528010313c4bcf59866ff67ef11b8f1e14d0 UNKNOWN
   * ac50108a775e47dc5151eedf6645bccdebf2cb4b Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1398178136

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0da7f5ff6c70c773c035aae60d84ec460252aae6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1398346998

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0da7f5ff6c70c773c035aae60d84ec460252aae6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1788299725

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] LinMingQiang commented on pull request #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …

Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1409966254

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1747344956

   @LinMingQiang : Can you resolve conflicts and add tests. Thanks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1788952234

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812",
       "triggerID" : "1409966254",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1788907052",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4864528010313c4bcf59866ff67ef11b8f1e14d0 UNKNOWN
   * ac50108a775e47dc5151eedf6645bccdebf2cb4b Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1410407282

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812",
       "triggerID" : "1409966254",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 0da7f5ff6c70c773c035aae60d84ec460252aae6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1788296811

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812",
       "triggerID" : "1409966254",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0da7f5ff6c70c773c035aae60d84ec460252aae6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812) 
   * 4864528010313c4bcf59866ff67ef11b8f1e14d0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1788861337

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812",
       "triggerID" : "1409966254",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4864528010313c4bcf59866ff67ef11b8f1e14d0 UNKNOWN
   * ac50108a775e47dc5151eedf6645bccdebf2cb4b Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang closed pull request #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …
URL: https://github.com/apache/hudi/pull/7718


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1398807606

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 0da7f5ff6c70c773c035aae60d84ec460252aae6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 commented on a diff in pull request #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7718:
URL: https://github.com/apache/hudi/pull/7718#discussion_r1095456393


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -879,13 +880,17 @@ object HoodieSparkSqlWriter {
     if (tableType.equals(COW_TABLE_TYPE_OPT_VAL)) {
       List(tableName)
     } else {
-      val roSuffix = if (hoodieConfig.getBooleanOrDefault(HIVE_SKIP_RO_SUFFIX_FOR_READ_OPTIMIZED_TABLE)) {
-        ""
+      if (!hoodieConfig.getStringOrDefault(HIVE_SYNC_TABLE_STRATEGY).equals(HoodieSyncTableStrategy.ALL.name())) {
+        List(tableName)
       } else {
-        HiveSyncTool.SUFFIX_READ_OPTIMIZED_TABLE
+        val roSuffix = if (hoodieConfig.getBooleanOrDefault(HIVE_SKIP_RO_SUFFIX_FOR_READ_OPTIMIZED_TABLE)) {
+          ""
+        } else {

Review Comment:
   Can we try to add some tests here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1788298960

   > @LinMingQiang : Can you resolve conflicts and add tests. Thanks.
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1789982470

   
   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1398187113

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0da7f5ff6c70c773c035aae60d84ec460252aae6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1398609592

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 0da7f5ff6c70c773c035aae60d84ec460252aae6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1788596489

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812",
       "triggerID" : "1409966254",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "",
       "status" : "CANCELED",
       "url" : "TBD",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4864528010313c4bcf59866ff67ef11b8f1e14d0 UNKNOWN
   *  Unknown: [CANCELED](TBD) 
   * ac50108a775e47dc5151eedf6645bccdebf2cb4b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1787241348

   > @LinMingQiang : Can you resolve conflicts and add tests. Thanks.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1410031883

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812",
       "triggerID" : "1409966254",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 0da7f5ff6c70c773c035aae60d84ec460252aae6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1788586108

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812",
       "triggerID" : "1409966254",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "",
       "status" : "CANCELED",
       "url" : "TBD",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4864528010313c4bcf59866ff67ef11b8f1e14d0 UNKNOWN
   *  Unknown: [CANCELED](TBD) 
   * ac50108a775e47dc5151eedf6645bccdebf2cb4b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1788341844

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812",
       "triggerID" : "1409966254",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4864528010313c4bcf59866ff67ef11b8f1e14d0 UNKNOWN
   * 96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1788966768

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812",
       "triggerID" : "1409966254",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20576",
       "triggerID" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1788541845",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "ac50108a775e47dc5151eedf6645bccdebf2cb4b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608",
       "triggerID" : "1788907052",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4864528010313c4bcf59866ff67ef11b8f1e14d0 UNKNOWN
   * ac50108a775e47dc5151eedf6645bccdebf2cb4b Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20608) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1788308615

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14496",
       "triggerID" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14500",
       "triggerID" : "1398604505",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0da7f5ff6c70c773c035aae60d84ec460252aae6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14812",
       "triggerID" : "1409966254",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4864528010313c4bcf59866ff67ef11b8f1e14d0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "",
       "status" : "CANCELED",
       "url" : "TBD",
       "triggerID" : "1788299725",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4864528010313c4bcf59866ff67ef11b8f1e14d0 UNKNOWN
   *  Unknown: [CANCELED](TBD) 
   * 96f0e0ab21f32e06b0fdd7a552f428cb2acee7f5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider … [hudi]

Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #7718:
URL: https://github.com/apache/hudi/pull/7718#issuecomment-1788907052

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org