You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by bhupeshchawda <gi...@git.apache.org> on 2015/12/28 08:07:34 UTC
[GitHub] incubator-apex-malhar pull request: MLHR-1953 - Added JdbcPOJOGene...
GitHub user bhupeshchawda opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/147
MLHR-1953 - Added JdbcPOJOGenericUpdateOperator. Added Unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bhupeshchawda/incubator-apex-malhar SPOI-6793-jdbc-output-module
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/147.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #147
----
commit b50bea657e8ba35655fa62484f63a49472699a70
Author: bhupeshchawda <bh...@gmail.com>
Date: 2015-12-15T07:58:53Z
MLHR-1953 - Added JdbcPOJOGenericUpdateOperator. Added Unit tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: MLHR-1953 - Added JdbcPOJOGene...
Posted by DT-Priyanka <gi...@git.apache.org>.
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/147#discussion_r48467695
--- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/JdbcPOJOOutputOperator.java ---
@@ -69,18 +69,18 @@
implements Operator.ActivationListener<OperatorContext>
{
@NotNull
- private List<FieldInfo> fieldInfos;
+ protected List<FieldInfo> fieldInfos;
--- End diff --
As this has getters and setters we need not change the access level.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: MLHR-1953 - Added JdbcPOJOGene...
Posted by bhupeshchawda <gi...@git.apache.org>.
Github user bhupeshchawda closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/147
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: MLHR-1953 - Added JdbcPOJOGene...
Posted by DT-Priyanka <gi...@git.apache.org>.
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/147#discussion_r48467728
--- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/JdbcPOJOOutputOperator.java ---
@@ -69,18 +69,18 @@
implements Operator.ActivationListener<OperatorContext>
{
@NotNull
- private List<FieldInfo> fieldInfos;
+ protected List<FieldInfo> fieldInfos;
- private List<Integer> columnDataTypes;
+ protected List<Integer> columnDataTypes;
@NotNull
private String tablename;
- private final transient List<JdbcPOJOInputOperator.ActiveFieldInfo> columnFieldGetters;
+ protected final transient List<JdbcPOJOInputOperator.ActiveFieldInfo> columnFieldGetters;
private String insertStatement;
- private transient Class<?> pojoClass;
+ protected transient Class<?> pojoClass;
--- End diff --
Same, is there need to change this access level?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: MLHR-1953 - Added JdbcPOJOGene...
Posted by DT-Priyanka <gi...@git.apache.org>.
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/147#discussion_r48467721
--- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/JdbcPOJOOutputOperator.java ---
@@ -69,18 +69,18 @@
implements Operator.ActivationListener<OperatorContext>
{
@NotNull
- private List<FieldInfo> fieldInfos;
+ protected List<FieldInfo> fieldInfos;
- private List<Integer> columnDataTypes;
+ protected List<Integer> columnDataTypes;
@NotNull
private String tablename;
- private final transient List<JdbcPOJOInputOperator.ActiveFieldInfo> columnFieldGetters;
+ protected final transient List<JdbcPOJOInputOperator.ActiveFieldInfo> columnFieldGetters;
--- End diff --
why have you changed this access level?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---