[GitHub] tbouron commented on issue #117: require login to webconsole for webapps

[GitBox <gi...@apache.org>]

tbouron commented on issue #117: require login to webconsole for webapps
URL: https://github.com/apache/brooklyn-ui/pull/117#issuecomment-447371396
 
 
   @ahgittin This should be ok for basic auth but I think will fail for any other kind of auth (if implemented in the future) All resources are now blocked by your change, meaning that any HTML nor JS can be read until the user login. 
   
   Again, not a issue for basic auth but this will bite back if (or when) we will move to another kind of auth: oAuth for instance will require to redirect to a provider. Maybe this can be done directly at the jetty level but not sure. Similarly, If we handle login via a login page, this will need to be accessible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services