You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/04 20:30:05 UTC

[GitHub] xtinec commented on a change in pull request #5813: Enable CSS Hot Module Replacement and optimize css output for production

xtinec commented on a change in pull request #5813: Enable CSS Hot Module Replacement and optimize css output for production
URL: https://github.com/apache/incubator-superset/pull/5813#discussion_r215056354
 
 

 ##########
 File path: superset/assets/webpack.config.js
 ##########
 @@ -2,7 +2,9 @@ const path = require('path');
 const webpack = require('webpack');
 const CleanWebpackPlugin = require('clean-webpack-plugin');
 const MiniCssExtractPlugin = require('mini-css-extract-plugin');
+const OptimizeCSSAssetsPlugin = require("optimize-css-assets-webpack-plugin");
 
 Review comment:
   [Nit] `''` here to get past the linter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org